Skip to content

Commit ff4d641

Browse files
fix: Add margin around speaker name and make text selectable (#4715)
Co-authored-by: iamareebjamal <[email protected]>
1 parent 6861fb5 commit ff4d641

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

app/templates/components/public/session-item.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<UiAccordion>
22
<div class="title" {{action 'hideSpeakerImage'}} role="button">
33
<div class="ui">
4-
<h3 class="ui header">
4+
<h3 class="ui header" id="session-id-{{this.session.id}}">
55
{{this.session.title}}
66
<div class="sub header">
77
{{this.session.sessionType.name}}

app/templates/components/public/speaker-item.hbs

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<div class="thumbnail-square">
55
<img alt="speaker" class="ui rounded image" src="{{if this.speaker.thumbnailImageUrl this.speaker.thumbnailImageUrl (if this.speaker.photoUrl this.speaker.photoUrl '/images/placeholders/avatar.png')}}">
66
</div>
7-
<h3 class="ui centered header no margin">
7+
<h3 class="ui centered header">
88
{{this.speaker.name}}
99
</h3>
1010
<p class="ui small centered disabled header no padding">
@@ -13,7 +13,7 @@
1313
</div>
1414
</div>
1515
<div class="ui vertical fluid menu content padded">
16-
<div class="item">
16+
<div class="item" style={{css user-select='text'}}>
1717
<p class="word-break">
1818
{{#if this.speaker.shortBiography}}
1919
{{sanitize this.speaker.shortBiography}}
@@ -52,16 +52,18 @@
5252
</strong>
5353
{{/if}}
5454
</p>
55-
<div class="ui fluid padded" style={{css color=session.track.fontColor background-color=session.track.color}}>
56-
<h3 class="item">
57-
{{#if (and session.startsAt session.endsAt)}}
58-
{{moment-format session.startsAt 'HH:mm'}} - {{moment-format session.endsAt 'hh:mm'}}
55+
<a href="{{href-to 'public.sessions.list' 'all'}}#session-id-{{session.id}}">
56+
<div class="ui fluid padded" style={{css color=session.track.fontColor background-color=session.track.color}}>
57+
<h3 class="item" style={{css user-select='text'}}>
58+
{{#if (and session.startsAt session.endsAt)}}
59+
{{moment-format session.startsAt 'HH:mm'}} - {{moment-format session.endsAt 'hh:mm'}}
60+
<br>
61+
{{/if}}
62+
&bull;&nbsp; {{session.title}}
5963
<br>
60-
{{/if}}
61-
&bull;&nbsp; {{session.title}}
62-
<br>
63-
</h3>
64-
</div>
64+
</h3>
65+
</div>
66+
</a>
6567
<br>
6668
{{/if}}
6769
{{/each}}

0 commit comments

Comments
 (0)