Merge pull request #2683 from niranjan94/enhancement/added-on-delte

Added proper on delete contraints to all Foreign Keys

Author: niranjan94

app/models/email_notifications.py

@@ -10,8 +10,8 @@ class EmailNotification(db.Model):
     new_paper = db.Column(db.Integer)
     session_accept_reject = db.Column(db.Integer)
     session_schedule = db.Column(db.Integer)
-    user_id = db.Column(db.Integer, db.ForeignKey('user.id'))
-    event_id = db.Column(db.Integer, db.ForeignKey('events.id'))
+    user_id = db.Column(db.Integer, db.ForeignKey('user.id', ondelete='CASCADE'))
+    event_id = db.Column(db.Integer, db.ForeignKey('events.id', ondelete='CASCADE'))
 
     def __init__(self,
                  next_event=0,

app/models/event.py

@@ -79,7 +79,7 @@ class Event(db.Model):
     topic = db.Column(db.String)
     sub_topic = db.Column(db.String)
     ticket_url = db.Column(db.String)
-    creator_id = db.Column(db.Integer, db.ForeignKey('user.id'))
+    creator_id = db.Column(db.Integer, db.ForeignKey('user.id', ondelete='CASCADE'))
     creator = db.relationship('User')
     db.UniqueConstraint('track.name')
     code_of_conduct = db.Column(db.String)

app/models/order.py

@@ -6,8 +6,8 @@
 
 class OrderTicket(db.Model):
     __tablename__ = 'orders_tickets'
-    order_id = db.Column(db.Integer, db.ForeignKey('orders.id'), primary_key=True)
-    ticket_id = db.Column(db.Integer, db.ForeignKey('ticket.id'), primary_key=True)
+    order_id = db.Column(db.Integer, db.ForeignKey('orders.id', ondelete='CASCADE'), primary_key=True)
+    ticket_id = db.Column(db.Integer, db.ForeignKey('ticket.id', ondelete='CASCADE'), primary_key=True)
     quantity = db.Column(db.Integer)
     ticket = db.relationship('Ticket', backref='order_tickets')
 
@@ -23,9 +23,9 @@ class Order(db.Model):
     state = db.Column(db.String)
     country = db.Column(db.String)
     zipcode = db.Column(db.String)
-    user_id = db.Column(db.Integer, db.ForeignKey('user.id'))
-    event_id = db.Column(db.Integer, db.ForeignKey('events.id'))
-    marketer_id = db.Column(db.Integer, db.ForeignKey('user.id'))
+    user_id = db.Column(db.Integer, db.ForeignKey('user.id', ondelete='SET NULL'))
+    event_id = db.Column(db.Integer, db.ForeignKey('events.id', ondelete='SET NULL'))
+    marketer_id = db.Column(db.Integer, db.ForeignKey('user.id', ondelete='SET NULL'))
     created_at = db.Column(db.DateTime)
     completed_at = db.Column(db.DateTime, nullable=True, default=None)
     transaction_id = db.Column(db.String)

app/models/system_role.py

@@ -38,10 +38,10 @@ class UserSystemRole(db.Model):
     __tablename__ = 'user_system_role'
 
     id = db.Column(db.Integer, primary_key=True)
-    user_id = db.Column(db.Integer, db.ForeignKey('user.id'))
+    user_id = db.Column(db.Integer, db.ForeignKey('user.id', ondelete='CASCADE'))
     user = db.relationship('User', backref='sys_roles')
 
-    role_id = db.Column(db.Integer, db.ForeignKey('custom_sys_role.id'))
+    role_id = db.Column(db.Integer, db.ForeignKey('custom_sys_role.id', ondelete='CASCADE'))
     role = db.relationship('CustomSysRole')
 
     def __init__(self, user, role):

app/models/ticket.py

@@ -2,8 +2,8 @@
 from . import db
 
 ticket_tags_table = db.Table('association', db.Model.metadata,
-                             db.Column('ticket_id', db.Integer, db.ForeignKey('ticket.id')),
-                             db.Column('ticket_tag_id', db.Integer, db.ForeignKey('ticket_tag.id'))
+                             db.Column('ticket_id', db.Integer, db.ForeignKey('ticket.id', ondelete='CASCADE')),
+                             db.Column('ticket_tag_id', db.Integer, db.ForeignKey('ticket_tag.id', ondelete='CASCADE'))
                              )
 
 
@@ -123,7 +123,7 @@ class TicketTag(db.Model):
     id = db.Column(db.Integer, primary_key=True)
     name = db.Column(db.String)
 
-    event_id = db.Column(db.Integer, db.ForeignKey('events.id'))
+    event_id = db.Column(db.Integer, db.ForeignKey('events.id', ondelete='CASCADE'))
     event = db.relationship('Event', backref='ticket_tags')
 
     def __init__(self, name, event_id):
@@ -147,9 +147,9 @@ class BookedTicket(db.Model):
                                           name='user_ticket_uc'),)
 
     id = db.Column(db.Integer, primary_key=True)
-    user_id = db.Column(db.Integer, db.ForeignKey('user.id'))
+    user_id = db.Column(db.Integer, db.ForeignKey('user.id', ondelete='CASCADE'))
     user = db.relationship('User', backref='booked_tickets')
-    ticket_id = db.Column(db.Integer, db.ForeignKey('ticket.id'))
+    ticket_id = db.Column(db.Integer, db.ForeignKey('ticket.id', ondelete='CASCADE'))
     ticket = db.relationship('Ticket', backref='booked_tickets')
     quantity = db.Column(db.Integer)
 

app/models/ticket_holder.py

@@ -17,7 +17,7 @@ class TicketHolder(db.Model):
     city = db.Column(db.String)
     state = db.Column(db.String)
     country = db.Column(db.String)
-    ticket_id = db.Column(db.Integer, db.ForeignKey('ticket.id'))
+    ticket_id = db.Column(db.Integer, db.ForeignKey('ticket.id', ondelete='CASCADE'))
     order_id = db.Column(db.Integer, db.ForeignKey('orders.id', ondelete='CASCADE'))
     order = db.relationship('Order', backref='ticket_holders')
     ticket = db.relationship('Ticket', backref='ticket_holders')

app/models/users_events_roles.py

@@ -8,10 +8,10 @@ class UsersEventsRoles(db.Model):
 
     event_id = db.Column(db.Integer, db.ForeignKey('events.id', ondelete='CASCADE'))
 
-    user_id = db.Column(db.Integer, db.ForeignKey('user.id'))
+    user_id = db.Column(db.Integer, db.ForeignKey('user.id', ondelete='CASCADE'))
     user = db.relationship("User")
 
-    role_id = db.Column(db.Integer, db.ForeignKey('role.id'))
+    role_id = db.Column(db.Integer, db.ForeignKey('role.id', ondelete='CASCADE'))
     role = db.relationship("Role")
 
     def __init__(self, user=None, event=None, role=None, user_id=None, role_id=None, event_id=None):

migrations/versions/e95a9cd83678_.py

@@ -0,0 +1,97 @@
+"""empty message
+
+Revision ID: e95a9cd83678
+Revises: 3f145ecaf358
+Create Date: 2016-12-21 13:17:24.682386
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = 'e95a9cd83678'
+down_revision = '3f145ecaf358'
+
+from alembic import op
+import sqlalchemy as sa
+import sqlalchemy_utils
+
+
+def upgrade():
+    ### commands auto generated by Alembic - please adjust! ###
+    op.drop_constraint(u'association_ticket_tag_id_fkey', 'association', type_='foreignkey')
+    op.drop_constraint(u'association_ticket_id_fkey', 'association', type_='foreignkey')
+    op.create_foreign_key(None, 'association', 'ticket_tag', ['ticket_tag_id'], ['id'], ondelete='CASCADE')
+    op.create_foreign_key(None, 'association', 'ticket', ['ticket_id'], ['id'], ondelete='CASCADE')
+    op.drop_constraint(u'booked_ticket_ticket_id_fkey', 'booked_ticket', type_='foreignkey')
+    op.drop_constraint(u'booked_ticket_user_id_fkey', 'booked_ticket', type_='foreignkey')
+    op.create_foreign_key(None, 'booked_ticket', 'user', ['user_id'], ['id'], ondelete='CASCADE')
+    op.create_foreign_key(None, 'booked_ticket', 'ticket', ['ticket_id'], ['id'], ondelete='CASCADE')
+    op.drop_constraint(u'email_notification_user_id_fkey', 'email_notification', type_='foreignkey')
+    op.drop_constraint(u'email_notification_event_id_fkey', 'email_notification', type_='foreignkey')
+    op.create_foreign_key(None, 'email_notification', 'events', ['event_id'], ['id'], ondelete='CASCADE')
+    op.create_foreign_key(None, 'email_notification', 'user', ['user_id'], ['id'], ondelete='CASCADE')
+    op.drop_constraint(u'events_creator_id_fkey', 'events', type_='foreignkey')
+    op.create_foreign_key(None, 'events', 'user', ['creator_id'], ['id'], ondelete='CASCADE')
+    op.drop_constraint(u'orders_user_id_fkey', 'orders', type_='foreignkey')
+    op.drop_constraint(u'orders_event_id_fkey', 'orders', type_='foreignkey')
+    op.drop_constraint(u'orders_marketer_id_fkey', 'orders', type_='foreignkey')
+    op.create_foreign_key(None, 'orders', 'user', ['marketer_id'], ['id'], ondelete='SET NULL')
+    op.create_foreign_key(None, 'orders', 'user', ['user_id'], ['id'], ondelete='SET NULL')
+    op.create_foreign_key(None, 'orders', 'events', ['event_id'], ['id'], ondelete='SET NULL')
+    op.drop_constraint(u'orders_tickets_ticket_id_fkey', 'orders_tickets', type_='foreignkey')
+    op.drop_constraint(u'orders_tickets_order_id_fkey', 'orders_tickets', type_='foreignkey')
+    op.create_foreign_key(None, 'orders_tickets', 'ticket', ['ticket_id'], ['id'], ondelete='CASCADE')
+    op.create_foreign_key(None, 'orders_tickets', 'orders', ['order_id'], ['id'], ondelete='CASCADE')
+    op.drop_constraint(u'ticket_holders_ticket_id_fkey', 'ticket_holders', type_='foreignkey')
+    op.create_foreign_key(None, 'ticket_holders', 'ticket', ['ticket_id'], ['id'], ondelete='CASCADE')
+    op.drop_constraint(u'ticket_tag_event_id_fkey', 'ticket_tag', type_='foreignkey')
+    op.create_foreign_key(None, 'ticket_tag', 'events', ['event_id'], ['id'], ondelete='CASCADE')
+    op.drop_constraint(u'user_system_role_user_id_fkey', 'user_system_role', type_='foreignkey')
+    op.drop_constraint(u'user_system_role_role_id_fkey', 'user_system_role', type_='foreignkey')
+    op.create_foreign_key(None, 'user_system_role', 'custom_sys_role', ['role_id'], ['id'], ondelete='CASCADE')
+    op.create_foreign_key(None, 'user_system_role', 'user', ['user_id'], ['id'], ondelete='CASCADE')
+    op.drop_constraint(u'users_events_roles_role_id_fkey', 'users_events_roles', type_='foreignkey')
+    op.drop_constraint(u'users_events_roles_user_id_fkey', 'users_events_roles', type_='foreignkey')
+    op.create_foreign_key(None, 'users_events_roles', 'role', ['role_id'], ['id'], ondelete='CASCADE')
+    op.create_foreign_key(None, 'users_events_roles', 'user', ['user_id'], ['id'], ondelete='CASCADE')
+    ### end Alembic commands ###
+
+
+def downgrade():
+    ### commands auto generated by Alembic - please adjust! ###
+    op.drop_constraint(None, 'users_events_roles', type_='foreignkey')
+    op.drop_constraint(None, 'users_events_roles', type_='foreignkey')
+    op.create_foreign_key(u'users_events_roles_user_id_fkey', 'users_events_roles', 'user', ['user_id'], ['id'])
+    op.create_foreign_key(u'users_events_roles_role_id_fkey', 'users_events_roles', 'role', ['role_id'], ['id'])
+    op.drop_constraint(None, 'user_system_role', type_='foreignkey')
+    op.drop_constraint(None, 'user_system_role', type_='foreignkey')
+    op.create_foreign_key(u'user_system_role_role_id_fkey', 'user_system_role', 'custom_sys_role', ['role_id'], ['id'])
+    op.create_foreign_key(u'user_system_role_user_id_fkey', 'user_system_role', 'user', ['user_id'], ['id'])
+    op.drop_constraint(None, 'ticket_tag', type_='foreignkey')
+    op.create_foreign_key(u'ticket_tag_event_id_fkey', 'ticket_tag', 'events', ['event_id'], ['id'])
+    op.drop_constraint(None, 'ticket_holders', type_='foreignkey')
+    op.create_foreign_key(u'ticket_holders_ticket_id_fkey', 'ticket_holders', 'ticket', ['ticket_id'], ['id'])
+    op.drop_constraint(None, 'orders_tickets', type_='foreignkey')
+    op.drop_constraint(None, 'orders_tickets', type_='foreignkey')
+    op.create_foreign_key(u'orders_tickets_order_id_fkey', 'orders_tickets', 'orders', ['order_id'], ['id'])
+    op.create_foreign_key(u'orders_tickets_ticket_id_fkey', 'orders_tickets', 'ticket', ['ticket_id'], ['id'])
+    op.drop_constraint(None, 'orders', type_='foreignkey')
+    op.drop_constraint(None, 'orders', type_='foreignkey')
+    op.drop_constraint(None, 'orders', type_='foreignkey')
+    op.create_foreign_key(u'orders_marketer_id_fkey', 'orders', 'user', ['marketer_id'], ['id'])
+    op.create_foreign_key(u'orders_event_id_fkey', 'orders', 'events', ['event_id'], ['id'])
+    op.create_foreign_key(u'orders_user_id_fkey', 'orders', 'user', ['user_id'], ['id'])
+    op.drop_constraint(None, 'events', type_='foreignkey')
+    op.create_foreign_key(u'events_creator_id_fkey', 'events', 'user', ['creator_id'], ['id'])
+    op.drop_constraint(None, 'email_notification', type_='foreignkey')
+    op.drop_constraint(None, 'email_notification', type_='foreignkey')
+    op.create_foreign_key(u'email_notification_event_id_fkey', 'email_notification', 'events', ['event_id'], ['id'])
+    op.create_foreign_key(u'email_notification_user_id_fkey', 'email_notification', 'user', ['user_id'], ['id'])
+    op.drop_constraint(None, 'booked_ticket', type_='foreignkey')
+    op.drop_constraint(None, 'booked_ticket', type_='foreignkey')
+    op.create_foreign_key(u'booked_ticket_user_id_fkey', 'booked_ticket', 'user', ['user_id'], ['id'])
+    op.create_foreign_key(u'booked_ticket_ticket_id_fkey', 'booked_ticket', 'ticket', ['ticket_id'], ['id'])
+    op.drop_constraint(None, 'association', type_='foreignkey')
+    op.drop_constraint(None, 'association', type_='foreignkey')
+    op.create_foreign_key(u'association_ticket_id_fkey', 'association', 'ticket', ['ticket_id'], ['id'])
+    op.create_foreign_key(u'association_ticket_tag_id_fkey', 'association', 'ticket_tag', ['ticket_tag_id'], ['id'])
+    ### end Alembic commands ###