Skip to content

Commit 95266c0

Browse files
author
Hieu Lam - TMA
authored
fix-8985: [Badge wizard] Fields section always expands when clicking saving. (#9013)
1 parent 975f321 commit 95266c0

File tree

6 files changed

+33
-0
lines changed

6 files changed

+33
-0
lines changed

app/api/badge_forms.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ def before_patch(_args, kwargs, data):
137137
badgeFieldForm.margin_right = badgeField['margin_right']
138138
badgeFieldForm.qr_custom_field = badgeField.get('qr_custom_field')
139139
badgeFieldForm.is_deleted = badgeField['is_deleted']
140+
badgeFieldForm.is_field_expanded = badgeField['is_field_expanded']
140141
db.session.add(badgeFieldForm)
141142

142143
@staticmethod

app/api/custom/schema/badge_form_field.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,4 @@ class BadgeFieldFormSchema(Schema):
2323
margin_left = fields.Integer(allow_none=True)
2424
margin_right = fields.Integer(allow_none=True)
2525
qr_custom_field = fields.List(fields.String(), allow_none=True, default=None)
26+
is_field_expanded = fields.Boolean(allow_none=True, default=True)

app/api/data_layers/BadgeFormLayer.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ def create_object(data, _view_kwargs):
5050
'margin_right',
5151
'qr_custom_field',
5252
'is_deleted',
53+
'is_field_expanded',
5354
]
5455
for item in data['badge_fields']:
5556
badgeFieldForm = BadgeFieldForms()

app/api/schema/badge_field_forms.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,4 @@ class Meta:
4343
margin_right = fields.Integer(required=False)
4444
text_rotation = fields.Integer(required=False)
4545
qr_custom_field = fields.List(fields.String(), required=False)
46+
is_field_expanded = fields.Boolean(required=False, default=False)

app/models/badge_field_form.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ class BadgeFieldForms(db.Model):
3131
margin_left = db.Column(db.Integer, nullable=True)
3232
margin_right = db.Column(db.Integer, nullable=True)
3333
qr_custom_field = db.Column(ARRAY(String), nullable=True)
34+
is_field_expanded = db.Column(db.Boolean, nullable=True)
3435

3536
def __repr__(self):
3637
return f'<BadgeFieldForms {self.id}>'
@@ -56,6 +57,7 @@ def convert_to_dict(self):
5657
'margin_left': self.margin_left,
5758
'margin_right': self.margin_right,
5859
'qr_custom_field': self.qr_custom_field,
60+
'is_field_expanded': self.is_field_expanded,
5961
}
6062

6163
def get_badge_field(self):
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
"""empty message
2+
3+
Revision ID: 8bd9e8e80517
4+
Revises: e3075e4e1327
5+
Create Date: 2023-07-26 10:30:16.958006
6+
7+
"""
8+
9+
from alembic import op
10+
import sqlalchemy as sa
11+
12+
13+
# revision identifiers, used by Alembic.
14+
revision = '8bd9e8e80517'
15+
down_revision = 'e3075e4e1327'
16+
17+
18+
def upgrade():
19+
# ### commands auto generated by Alembic - please adjust! ###
20+
op.add_column('badge_field_forms', sa.Column('is_field_expanded', sa.Boolean(), nullable=True))
21+
# ### end Alembic commands ###
22+
23+
24+
def downgrade():
25+
# ### commands auto generated by Alembic - please adjust! ###
26+
op.drop_column('badge_field_forms', 'is_field_expanded')
27+
# ### end Alembic commands ###

0 commit comments

Comments
 (0)