fix: Refresh cache on PATCH request (#5497)

Author: iamareebjamal

app/api/settings.py

@@ -7,6 +7,7 @@
 from app.api.schema.settings import SettingSchemaAdmin, SettingSchemaNonAdmin, SettingSchemaPublic
 from app.models import db
 from app.models.setting import Setting
+from app.settings import refresh_settings
 
 
 class Environment:
@@ -43,3 +44,7 @@ def before_get(self, args, kwargs):
     schema = SettingSchemaAdmin
     data_layer = {'session': db.session,
                   'model': Setting}
+
+    def after_patch(self, result):
+        # Update settings cache after PATCH
+        refresh_settings()

app/settings/__init__.py

@@ -6,11 +6,11 @@
 from app.models.setting import Setting, Environment
 
 
-def get_settings():
+def get_settings(from_db=False):
     """
     Use this to get latest system settings
     """
-    if 'custom_settings' in current_app.config:
+    if not from_db and 'custom_settings' in current_app.config:
         return current_app.config['custom_settings']
     s = Setting.query.order_by(desc(Setting.id)).first()
     if s is None:
@@ -22,6 +22,11 @@ def get_settings():
     return current_app.config['custom_settings']
 
 
+def refresh_settings():
+    # Force fetch settings from DB, thus refreshing it
+    get_settings(from_db=True)
+
+
 def get_setts():
     return Setting.query.order_by(desc(Setting.id)).first()