Skip to content

Commit ec24c30

Browse files
abhinavk96iamareebjamal
authored andcommitted
fix: Make discount code & access code URL follow json api conventions (#6238)
1 parent 0ed4363 commit ec24c30

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

app/api/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@
474474
'/tickets/<int:ticket_id>/discount-codes')
475475
api.route(DiscountCodeDetail, 'discount_code_detail', '/discount-codes/<int:id>',
476476
'/events/<int:event_id>/discount-code', '/event-invoices/<int:event_invoice_id>/discount-code',
477-
'/event/<int:discount_event_id>/discount-code/<code>')
477+
'/events/<int:discount_event_id>/discount-codes/<code>')
478478
api.route(DiscountCodeRelationshipRequired, 'discount_code_event',
479479
'/discount-codes/<int:id>/relationships/event')
480480
api.route(DiscountCodeRelationshipOptional, 'discount_code_events',
@@ -542,7 +542,7 @@
542542
'/events/<event_identifier>/access-codes', '/users/<int:user_id>/access-codes',
543543
'/tickets/<int:ticket_id>/access-codes')
544544
api.route(AccessCodeDetail, 'access_code_detail', '/access-codes/<int:id>',
545-
'/event/<int:access_event_id>/access-code/<code>')
545+
'/events/<int:access_event_id>/access-codes/<code>')
546546
api.route(AccessCodeRelationshipRequired, 'access_code_event',
547547
'/access-codes/<int:id>/relationships/event')
548548
api.route(AccessCodeRelationshipOptional, 'access_code_user',

docs/api/api_blueprint.apib

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17815,7 +17815,7 @@ Delete a single discount code (Check permission to delete).
1781517815
}
1781617816
}
1781717817

17818-
## Get Discount Code Detail using the code [/v1/event/{event_id}/discount-code/{code}]
17818+
## Get Discount Code Detail using the code [/v1/events/{event_id}/discount-codes/{code}]
1781917819
+ Parameters
1782017820
+ code: DC101 (string) - code associated with a discount code. (DC101 is an example of code)
1782117821
+ event_id: 1 (integer) - ID of the Event in the form of an integer
@@ -18429,7 +18429,7 @@ Delete a single Access code.
1842918429
}
1843018430
}
1843118431

18432-
## Access Code Detail using the Code [/v1/event/{event_id}/access-code/{code}]
18432+
## Access Code Detail using the Code [/v1/events/{event_id}/access-codes/{code}]
1843318433
+ Parameters
1843418434
+ code: AC101 (string) - code of the access-code.
1843518435
+ event_id: 1 (integer) - ID of the Event in the form of an integer.

tests/hook_main.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2804,7 +2804,7 @@ def discount_delete(transaction):
28042804
@hooks.before("Discount Codes > Get Discount Code Detail using the code > Get Discount Code Detail")
28052805
def discount_code_get_detail_using_code(transaction):
28062806
"""
2807-
GET event/1/discount-codes/DC101
2807+
GET events/1/discount-codes/DC101
28082808
:param transaction:
28092809
:return:
28102810
"""
@@ -2941,7 +2941,7 @@ def access_code_delete(transaction):
29412941
@hooks.before("Access Codes > Access Code Detail using the Code > Access Code Detail")
29422942
def access_code_get_detail_using_code(transaction):
29432943
"""
2944-
GET event/1/access-code/AC101
2944+
GET events/1/access-codes/AC101
29452945
:param transaction:
29462946
:return:
29472947
"""

0 commit comments

Comments
 (0)