feature-8827: Make names part of the custom form area in attendee forms (#8936)

* feature-8827: Make names part of the custom form area in attendee forms

* feature-8827: Make names part of the custom form area in attendee forms

Author: Hieu Lam - TMA

app/api/helpers/events.py

@@ -14,27 +14,6 @@ def create_custom_forms_for_attendees(event):
     is_included = True
     is_fixed = True
     event_id = event.id
-    form_type = 'text'
-
-    first_name_form = CustomForms(
-        form=form,
-        is_required=is_required,
-        is_included=is_included,
-        is_fixed=is_fixed,
-        event_id=event_id,
-        type=form_type,
-        field_identifier='firstname',
-    )
-
-    last_name_form = CustomForms(
-        form=form,
-        is_required=is_required,
-        is_included=is_included,
-        is_fixed=is_fixed,
-        event_id=event_id,
-        type=form_type,
-        field_identifier='lastname',
-    )
 
     email_form = CustomForms(
         form=form,
@@ -46,6 +25,4 @@ def create_custom_forms_for_attendees(event):
         field_identifier='email',
     )
 
-    save_to_db(first_name_form, 'First name form saved')
-    save_to_db(last_name_form, 'Last name form saved')
     save_to_db(email_form, 'Email form saved')

tests/all/integration/api/helpers/test_events.py

@@ -14,7 +14,7 @@ def test_should_create_attendee_forms(self):
             event = EventFactoryBasic()
             save_to_db(event)
             create_custom_forms_for_attendees(event)
-            assert get_count(CustomForms.query) == 3
+            assert get_count(CustomForms.query) == 1
 
 
 if __name__ == '__main__':