Skip to content

Commit 58ba1f1

Browse files
committed
changed var to let for better scoping
Signed-off-by: Vedansh Saini <[email protected]>
1 parent 1a2f231 commit 58ba1f1

File tree

2 files changed

+128
-128
lines changed

2 files changed

+128
-128
lines changed

src/scripts/main.js

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
/* global $,Materialize*/
2-
var enableToggleElement = document.getElementById('enable');
3-
var githubUsernameElement = document.getElementById('githubUsername');
4-
var projectNameElement = document.getElementById('projectName');
5-
var lastWeekContributionElement = document.getElementById('lastWeekContribution');
6-
var startingDateElement = document.getElementById('startingDate');
7-
var endingDateElement = document.getElementById('endingDate');
8-
var showOpenLabelElement = document.getElementById('showOpenLabel');
9-
var userReasonElement = document.getElementById('userReason');
10-
var gsoc = 0; //0 means gsoc. 1 means gsoc
2+
let enableToggleElement = document.getElementById('enable');
3+
let githubUsernameElement = document.getElementById('githubUsername');
4+
let projectNameElement = document.getElementById('projectName');
5+
let lastWeekContributionElement = document.getElementById('lastWeekContribution');
6+
let startingDateElement = document.getElementById('startingDate');
7+
let endingDateElement = document.getElementById('endingDate');
8+
let showOpenLabelElement = document.getElementById('showOpenLabel');
9+
let userReasonElement = document.getElementById('userReason');
10+
let gsoc = 0; //0 means gsoc. 1 means gsoc
1111
function handleBodyOnLoad() {
1212
// prefill name
1313
chrome.storage.local.get(
@@ -64,19 +64,19 @@ function handleBodyOnLoad() {
6464
);
6565
}
6666
function handleEnableChange() {
67-
var value = enableToggleElement.checked;
67+
let value = enableToggleElement.checked;
6868
chrome.storage.local.set({ enableToggle: value });
6969
}
7070
function handleStartingDateChange() {
71-
var value = startingDateElement.value;
71+
let value = startingDateElement.value;
7272
chrome.storage.local.set({ startingDate: value });
7373
}
7474
function handleEndingDateChange() {
75-
var value = endingDateElement.value;
75+
let value = endingDateElement.value;
7676
chrome.storage.local.set({ endingDate: value });
7777
}
7878
function handleLastWeekContributionChange() {
79-
var value = lastWeekContributionElement.checked;
79+
let value = lastWeekContributionElement.checked;
8080
if (value) {
8181
startingDateElement.disabled = true;
8282
endingDateElement.disabled = true;
@@ -91,13 +91,13 @@ function handleLastWeekContributionChange() {
9191
chrome.storage.local.set({ lastWeekContribution: value });
9292
}
9393
function getLastWeek() {
94-
var today = new Date();
95-
var noDays_to_goback = gsoc == 0 ? 7 : 1;
96-
var lastWeek = new Date(today.getFullYear(), today.getMonth(), today.getDate() - noDays_to_goback);
97-
var lastWeekMonth = lastWeek.getMonth() + 1;
98-
var lastWeekDay = lastWeek.getDate();
99-
var lastWeekYear = lastWeek.getFullYear();
100-
var lastWeekDisplayPadded =
94+
let today = new Date();
95+
let noDays_to_goback = gsoc == 0 ? 7 : 1;
96+
let lastWeek = new Date(today.getFullYear(), today.getMonth(), today.getDate() - noDays_to_goback);
97+
let lastWeekMonth = lastWeek.getMonth() + 1;
98+
let lastWeekDay = lastWeek.getDate();
99+
let lastWeekYear = lastWeek.getFullYear();
100+
let lastWeekDisplayPadded =
101101
('0000' + lastWeekYear.toString()).slice(-4) +
102102
'-' +
103103
('00' + lastWeekMonth.toString()).slice(-2) +
@@ -106,12 +106,12 @@ function getLastWeek() {
106106
return lastWeekDisplayPadded;
107107
}
108108
function getToday() {
109-
var today = new Date();
110-
var week = new Date(today.getFullYear(), today.getMonth(), today.getDate());
111-
var weekMonth = week.getMonth() + 1;
112-
var weekDay = week.getDate();
113-
var weekYear = week.getFullYear();
114-
var weekDisplayPadded =
109+
let today = new Date();
110+
let week = new Date(today.getFullYear(), today.getMonth(), today.getDate());
111+
let weekMonth = week.getMonth() + 1;
112+
let weekDay = week.getDate();
113+
let weekYear = week.getFullYear();
114+
let weekDisplayPadded =
115115
('0000' + weekYear.toString()).slice(-4) +
116116
'-' +
117117
('00' + weekMonth.toString()).slice(-2) +
@@ -120,20 +120,20 @@ function getToday() {
120120
return weekDisplayPadded;
121121
}
122122
function handleGithubUsernameChange() {
123-
var value = githubUsernameElement.value;
123+
let value = githubUsernameElement.value;
124124
chrome.storage.local.set({ githubUsername: value });
125125
}
126126
function handleProjectNameChange() {
127-
var value = projectNameElement.value;
127+
let value = projectNameElement.value;
128128
chrome.storage.local.set({ projectName: value });
129129
}
130130
function handleOpenLabelChange() {
131-
var value = showOpenLabelElement.checked;
131+
let value = showOpenLabelElement.checked;
132132
chrome.storage.local.set({ showOpenLabel: value });
133133
chrome.storage.local.set({ showClosedLabel: value });
134134
}
135135
function handleUserReasonChange() {
136-
var value = userReasonElement.value;
136+
let value = userReasonElement.value;
137137
chrome.storage.local.set({ userReason: value });
138138
}
139139

0 commit comments

Comments
 (0)