Skip to content

Commit 67925df

Browse files
authored
Merge pull request #71 from Preeti9764/fix-bug-issue#69
Fixes issue #69 : Enhanced feedback to Selection/Deselection of CheckBox
2 parents 4471bee + 3e7d4da commit 67925df

File tree

2 files changed

+41
-9
lines changed

2 files changed

+41
-9
lines changed

src/index.css

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,3 +50,17 @@ li {
5050
list-style-type: disc !important;
5151
margin-left: 1rem;
5252
}
53+
.selectedLabel {
54+
font-weight: 400;
55+
color: #333333;
56+
}
57+
58+
.unselectedLabel {
59+
font-weight: 300;
60+
color: #666666;
61+
}
62+
63+
.selectedLabel, .unselectedLabel {
64+
transition: color 0.3s ease-in-out, font-weight 0.3s ease-in-out;
65+
}
66+

src/scripts/main.js

Lines changed: 27 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -92,19 +92,27 @@ function handleEndingDateChange() {
9292
}
9393
function handleLastWeekContributionChange() {
9494
var value = lastWeekContributionElement.checked;
95+
var labelElement = document.querySelector("label[for='lastWeekContribution']");
96+
9597
if (value) {
96-
startingDateElement.disabled = true;
97-
endingDateElement.disabled = true;
98-
endingDateElement.value = getToday();
99-
startingDateElement.value = getLastWeek();
100-
handleEndingDateChange();
101-
handleStartingDateChange();
98+
startingDateElement.disabled = true;
99+
endingDateElement.disabled = true;
100+
endingDateElement.value = getToday();
101+
startingDateElement.value = getLastWeek();
102+
handleEndingDateChange();
103+
handleStartingDateChange();
104+
labelElement.classList.add("selectedLabel");
105+
labelElement.classList.remove("unselectedLabel");
102106
} else {
103-
startingDateElement.disabled = false;
104-
endingDateElement.disabled = false;
107+
startingDateElement.disabled = false;
108+
endingDateElement.disabled = false;
109+
labelElement.classList.add("unselectedLabel");
110+
labelElement.classList.remove("selectedLabel");
105111
}
112+
106113
chrome.storage.local.set({ lastWeekContribution: value });
107114
}
115+
108116
function getLastWeek() {
109117
var today = new Date();
110118
var noDays_to_goback = gsoc == 0 ? 7 : 1;
@@ -145,9 +153,19 @@ function handleProjectNameChange() {
145153
}
146154
function handleOpenLabelChange() {
147155
var value = showOpenLabelElement.checked;
156+
var labelElement = document.querySelector("label[for='showOpenLabel']");
157+
158+
if (value) {
159+
labelElement.classList.add("selectedLabel");
160+
labelElement.classList.remove("unselectedLabel");
161+
} else {
162+
labelElement.classList.add("unselectedLabel");
163+
labelElement.classList.remove("selectedLabel");
164+
}
165+
148166
chrome.storage.local.set({ showOpenLabel: value });
149-
chrome.storage.local.set({ showClosedLabel: value });
150167
}
168+
151169
function handleUserReasonChange() {
152170
var value = userReasonElement.value;
153171
chrome.storage.local.set({ userReason: value });

0 commit comments

Comments
 (0)