Skip to content

Commit 7f288fd

Browse files
committed
replaced var with let
Signed-off-by: Vedansh Saini <[email protected]>
1 parent 140f9e3 commit 7f288fd

File tree

3 files changed

+53
-53
lines changed

3 files changed

+53
-53
lines changed

src/scripts/main.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
var enableToggleElement = document.getElementById('enable');
2-
var githubUsernameElement = document.getElementById('githubUsername');
3-
var projectNameElement = document.getElementById('projectName');
4-
var lastWeekContributionElement = document.getElementById('lastWeekContribution');
1+
let enableToggleElement = document.getElementById('enable');
2+
let githubUsernameElement = document.getElementById('githubUsername');
3+
let projectNameElement = document.getElementById('projectName');
4+
let lastWeekContributionElement = document.getElementById('lastWeekContribution');
55
let yesterdayContributionElement = document.getElementById('yesterdayContribution');
6-
var startingDateElement = document.getElementById('startingDate');
7-
var endingDateElement = document.getElementById('endingDate');
8-
var showOpenLabelElement = document.getElementById('showOpenLabel');
9-
var userReasonElement = document.getElementById('userReason');
6+
let startingDateElement = document.getElementById('startingDate');
7+
let endingDateElement = document.getElementById('endingDate');
8+
let showOpenLabelElement = document.getElementById('showOpenLabel');
9+
let userReasonElement = document.getElementById('userReason');
1010

1111
function handleBodyOnLoad() {
1212
chrome.storage.local.get(
@@ -156,12 +156,12 @@ function handleYesterdayContributionChange() {
156156
}
157157

158158
function getLastWeek() {
159-
var today = new Date();
160-
var lastWeek = new Date(today.getFullYear(), today.getMonth(), today.getDate() - 1);
161-
var lastWeekMonth = lastWeek.getMonth() + 1;
162-
var lastWeekDay = lastWeek.getDate();
163-
var lastWeekYear = lastWeek.getFullYear();
164-
var lastWeekDisplayPadded =
159+
let today = new Date();
160+
let lastWeek = new Date(today.getFullYear(), today.getMonth(), today.getDate() - 1);
161+
let lastWeekMonth = lastWeek.getMonth() + 1;
162+
let lastWeekDay = lastWeek.getDate();
163+
let lastWeekYear = lastWeek.getFullYear();
164+
let lastWeekDisplayPadded =
165165
('0000' + lastWeekYear.toString()).slice(-4) +
166166
'-' +
167167
('00' + lastWeekMonth.toString()).slice(-2) +

src/scripts/popup.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
function getLastWeek() {
2-
var today = new Date();
3-
var lastWeek = new Date(today.getFullYear(), today.getMonth(), today.getDate() - 7);
4-
var lastWeekMonth = lastWeek.getMonth() + 1;
5-
var lastWeekDay = lastWeek.getDate();
6-
var lastWeekYear = lastWeek.getFullYear();
7-
var lastWeekDisplayPadded =
2+
let today = new Date();
3+
let lastWeek = new Date(today.getFullYear(), today.getMonth(), today.getDate() - 7);
4+
let lastWeekMonth = lastWeek.getMonth() + 1;
5+
let lastWeekDay = lastWeek.getDate();
6+
let lastWeekYear = lastWeek.getFullYear();
7+
let lastWeekDisplayPadded =
88
('0000' + lastWeekYear.toString()).slice(-4) +
99
'-' +
1010
('00' + lastWeekMonth.toString()).slice(-2) +
@@ -14,11 +14,11 @@ function getLastWeek() {
1414
}
1515

1616
function getToday() {
17-
var today = new Date();
18-
var WeekMonth = today.getMonth() + 1;
19-
var WeekDay = today.getDate();
20-
var WeekYear = today.getFullYear();
21-
var WeekDisplayPadded =
17+
let today = new Date();
18+
let WeekMonth = today.getMonth() + 1;
19+
let WeekDay = today.getDate();
20+
let WeekYear = today.getFullYear();
21+
let WeekDisplayPadded =
2222
('0000' + WeekYear.toString()).slice(-4) +
2323
'-' +
2424
('00' + WeekMonth.toString()).slice(-2) +

src/scripts/scrumHelper.js

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -5,36 +5,36 @@ let hasInjectedContent = false;
55
function allIncluded(outputTarget = 'email') {
66
console.log('allIncluded called with outputTarget:', outputTarget);
77
console.log('Current window context:', window.location.href);
8-
var scrumBody = null;
9-
var scrumSubject = null;
10-
var startingDate = '';
11-
var endingDate = '';
12-
var githubUsername = '';
13-
var projectName = '';
14-
var lastWeekArray = [];
15-
var nextWeekArray = [];
16-
var reviewedPrsArray = [];
17-
var githubIssuesData = null;
18-
var lastWeekContribution = false;
8+
let scrumBody = null;
9+
let scrumSubject = null;
10+
let startingDate = '';
11+
let endingDate = '';
12+
let githubUsername = '';
13+
let projectName = '';
14+
let lastWeekArray = [];
15+
let nextWeekArray = [];
16+
let reviewedPrsArray = [];
17+
let githubIssuesData = null;
18+
let lastWeekContribution = false;
1919
let yesterdayContribution = false;
20-
var githubPrsReviewData = null;
21-
var githubUserData = null;
22-
var githubPrsReviewDataProcessed = {};
23-
var showOpenLabel = true;
24-
var showClosedLabel = true;
25-
var userReason = '';
26-
27-
var pr_merged_button =
20+
let githubPrsReviewData = null;
21+
let githubUserData = null;
22+
let githubPrsReviewDataProcessed = {};
23+
let showOpenLabel = true;
24+
let showClosedLabel = true;
25+
let userReason = '';
26+
27+
let pr_merged_button =
2828
'<div style="vertical-align:middle;display: inline-block;padding: 0px 4px;font-size:9px;font-weight: 600;color: #fff;text-align: center;background-color: #6f42c1;border-radius: 3px;line-height: 12px;margin-bottom: 2px;" class="State State--purple">closed</div>';
29-
var pr_unmerged_button =
29+
let pr_unmerged_button =
3030
'<div style="vertical-align:middle;display: inline-block;padding: 0px 4px;font-size:9px;font-weight: 600;color: #fff;text-align: center;background-color: #2cbe4e;border-radius: 3px;line-height: 12px;margin-bottom: 2px;" class="State State--green">open</div>';
3131

32-
var issue_closed_button =
32+
let issue_closed_button =
3333
'<div style="vertical-align:middle;display: inline-block;padding: 0px 4px;font-size:9px;font-weight: 600;color: #fff;text-align: center;background-color: #6f42c1;border-radius: 3px;line-height: 12px;margin-bottom: 2px;" class="State State--purple">closed</div>';
34-
var issue_opened_button =
34+
let issue_opened_button =
3535
'<div style="vertical-align:middle;display: inline-block;padding: 0px 4px;font-size:9px;font-weight: 600;color: #fff;text-align: center;background-color: #2cbe4e;border-radius: 3px;line-height: 12px;margin-bottom: 2px;" class="State State--green">open</div>';
3636

37-
// var linkStyle = '';
37+
// let linkStyle = '';
3838
function getChromeData() {
3939
console.log("Getting Chrome data for context:", outputTarget);
4040
chrome.storage.local.get(
@@ -459,18 +459,18 @@ function allIncluded(outputTarget = 'email') {
459459

460460
setTimeout(() => {
461461
// Generate content first
462-
var lastWeekUl = '<ul>';
463-
var i;
462+
let lastWeekUl = '<ul>';
463+
let i;
464464
for (i = 0; i < lastWeekArray.length; i++) lastWeekUl += lastWeekArray[i];
465465
for (i = 0; i < reviewedPrsArray.length; i++) lastWeekUl += reviewedPrsArray[i];
466466
lastWeekUl += '</ul>';
467467

468-
var nextWeekUl = '<ul>';
468+
let nextWeekUl = '<ul>';
469469
for (i = 0; i < nextWeekArray.length; i++) nextWeekUl += nextWeekArray[i];
470470
nextWeekUl += '</ul>';
471471

472-
var weekOrDay = lastWeekContribution ? 'last week' : (yesterdayContribution ? 'yesterday' : 'the period');
473-
var weekOrDay2 = lastWeekContribution ? 'this week' : 'today';
472+
let weekOrDay = lastWeekContribution ? 'last week' : (yesterdayContribution ? 'yesterday' : 'the period');
473+
let weekOrDay2 = lastWeekContribution ? 'this week' : 'today';
474474

475475
// Create the complete content
476476
let content;

0 commit comments

Comments
 (0)