Skip to content

Commit e37a73a

Browse files
committed
fixed the [object Object] in UI.
Signed-off-by: Vedansh Saini <[email protected]>
1 parent d8ff406 commit e37a73a

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

src/scripts/scrumHelper.js

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,19 +122,21 @@ function allIncluded(outputTarget = 'email') {
122122
if (outputTarget === 'popup') {
123123
console.log("No username found - popup context");
124124
// Show error in popup
125+
const scrumReport = document.getElementById('scrumReport');
125126
const generateBtn = document.getElementById('generateReport');
127+
if (scrumReport) {
128+
scrumReport.innerHTML = '<div class="error-message" style="color: #dc2626; font-weight: bold; padding: 10px;">Please enter your GitHub username to generate a report.</div>';
129+
}
126130
if (generateBtn) {
127131
generateBtn.innerHTML = '<i class="fa fa-refresh"></i> Generate Report';
128132
generateBtn.disabled = false;
129133
}
130-
if (window.Materialize && window.Materialize.toast) {
131-
Materialize.toast({ html: 'Please enter your GitHub username', classes: 'red' });
132-
} else {
133-
alert('Please enter your GitHub username');
134-
}
134+
scrumGenerationInProgress = false;
135135
} else {
136136
console.warn('No GitHub username found in storage');
137+
scrumGenerationInProgress = false;
137138
}
139+
return;
138140
}
139141
if (items.cacheInput) {
140142
cacheInput = items.cacheInput;
@@ -423,6 +425,17 @@ function allIncluded(outputTarget = 'email') {
423425

424426
if (outputTarget === 'popup') {
425427
const generateBtn = document.getElementById('generateReport');
428+
if (scrumReport) {
429+
let errorMsg = 'An error occurred while generating the report.';
430+
if (err) {
431+
if (typeof err === 'string') errorMsg = err;
432+
else if (err.message) errorMsg = err.message;
433+
else errorMsg = JSON.stringify(err)
434+
}
435+
scrumReport.innerHTML = `<div class="error-message" style="color: #dc2626; font-weight: bold; padding: 10px;">${err.message || 'An error occurred while generating the report.'}</div>`;
436+
generateBtn.innerHTML = '<i class="fa fa-refresh"></i> Generate Report';
437+
generateBtn.disabled = false;
438+
}
426439
if (generateBtn) {
427440
generateBtn.innerHTML = '<i class="fa fa-refresh"></i> Generate Report';
428441
generateBtn.disabled = false;

0 commit comments

Comments
 (0)