Skip to content

Commit afeacd4

Browse files
Update test_jellyfish.c
1 parent 6b65e52 commit afeacd4

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

code/tests/cases/test_jellyfish.c

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ FOSSIL_TEST_CASE(c_test_parse_jellyfish_file_valid) {
316316
" \"signature\": \"JFS1\",\n"
317317
" \"blocks\": [\n"
318318
" {\n"
319-
" \"input\": \"apple\",\n"
319+
" \"input\": \"apple.fish\",\n"
320320
" \"output\": \"fruit\",\n"
321321
" \"timestamp\": 12345678\n"
322322
" }\n"
@@ -329,19 +329,22 @@ FOSSIL_TEST_CASE(c_test_parse_jellyfish_file_valid) {
329329
int count = fossil_jellyfish_parse_jellyfish_file(test_file, out, 4);
330330

331331
ASSUME_ITS_EQUAL_SIZE(count, 1);
332-
ASSUME_ITS_EQUAL_CSTR(out[0].chain.memory[0].input, "apple");
333-
ASSUME_ITS_EQUAL_CSTR(out[0].chain.memory[0].output, "fruit");
332+
ASSUME_ITS_EQUAL_CSTR(out[0].model_files[0], "apple.fish");
333+
ASSUME_ITS_EQUAL_SIZE(out[0].model_count, 1);
334334

335335
remove(test_file);
336336
}
337337

338338
FOSSIL_TEST_CASE(c_test_load_mindset_file_valid) {
339339
const char *model_file = "test_model.fish";
340+
341+
// Save a test model to a file
340342
fossil_jellyfish_chain chain;
341343
fossil_jellyfish_init(&chain);
342344
fossil_jellyfish_learn(&chain, "sun", "star");
343345
fossil_jellyfish_save(&chain, model_file);
344346

347+
// Create mindset file referencing model
345348
const char *jelly_file = "test_valid.jellyfish";
346349
FILE *f = fopen(jelly_file, "w");
347350
fprintf(f,
@@ -357,20 +360,23 @@ FOSSIL_TEST_CASE(c_test_load_mindset_file_valid) {
357360
"}\n", model_file);
358361
fclose(f);
359362

363+
// Load mind from mindset file
360364
fossil_jellyfish_mind mind;
361365
memset(&mind, 0, sizeof(mind));
362366
int ok = fossil_jellyfish_load_mindset_file(jelly_file, &mind);
363367

364368
ASSUME_ITS_TRUE(ok == 1);
365369
ASSUME_ITS_EQUAL_SIZE(mind.model_count, 1);
366370
ASSUME_ITS_EQUAL_CSTR(mind.models[0].memory[0].input, "sun");
371+
ASSUME_ITS_EQUAL_CSTR(mind.models[0].memory[0].output, "star");
367372

368373
remove(jelly_file);
369374
remove(model_file);
370375
}
371376

372377
FOSSIL_TEST_CASE(c_test_load_mindset_file_missing_model) {
373378
const char *jelly_file = "bad_model_ref.jellyfish";
379+
374380
FILE *f = fopen(jelly_file, "w");
375381
fprintf(f,
376382
"{\n"
@@ -385,10 +391,10 @@ FOSSIL_TEST_CASE(c_test_load_mindset_file_missing_model) {
385391
"}\n");
386392
fclose(f);
387393

388-
fossil_jellyfish_mind mind;
389-
memset(&mind, 0, sizeof(mind));
394+
fossil_jellyfish_mind mind = {0};
390395
int ok = fossil_jellyfish_load_mindset_file(jelly_file, &mind);
391-
ASSUME_ITS_TRUE(ok == 0);
396+
397+
ASSUME_ITS_TRUE(ok == 0); // Should fail to load missing model
392398

393399
remove(jelly_file);
394400
}

0 commit comments

Comments
 (0)