resolve unused param for format char

Author: dreamer-coding

code/logic/fossil/io/soap.h

@@ -33,10 +33,9 @@ char *fossil_io_soap_sanitize(const char *text);
  * @brief Suggest proper alternatives for rot-brain words or grammar fixes.
  *
  * @param text The input text.
- * @param format_type Custom format for output (e.g., "*" or "#").
  * @return A dynamically allocated string with suggestions (must be freed by the caller).
  */
-char *fossil_io_soap_suggest(const char *text, char format_type);
+char *fossil_io_soap_suggest(const char *text);
 
 /**
  * @brief Add a custom word or phrase to the filter.
@@ -96,8 +95,8 @@ namespace fossil {
              * @param format_type Custom format for output (e.g., "*" or "#").
              * @return A dynamically allocated string with suggestions (must be freed by the caller).
              */
-            static std::string suggest(const std::string &text, char format_type = '*') {
-                return fossil_io_soap_suggest(text.c_str(), format_type);
+            static std::string suggest(const std::string &text) {
+                return fossil_io_soap_suggest(text.c_str());
             }
 
             /**
@@ -145,8 +144,8 @@ namespace fossil {
              * @param format_type Custom format for output (e.g., "*" or "#").
              * @return A dynamically allocated string with suggestions (must be freed by the caller).
              */
-            static char* suggest(const char* text, char format_type = '*') {
-                return fossil_io_soap_suggest(text, format_type);
+            static char* suggest(const char* text) {
+                return fossil_io_soap_suggest(text);
             }
 
             /**

code/logic/soap.c

@@ -298,11 +298,7 @@ char *fossil_io_soap_sanitize(const char *text) {
     return output;
 }
 
-/**
- * @brief Suggest proper alternatives for rot-brain words or grammar fixes.
- * @param format_type Custom format for output (e.g., "*" or "#").
- */
-char *fossil_io_soap_suggest(const char *text, char format_type) {
+char *fossil_io_soap_suggest(const char *text) {
     if (!text) return NULL;
 
     size_t len = strlen(text);

code/tests/cases/test_soap.c

@@ -94,15 +94,15 @@ FOSSIL_TEST_CASE(c_test_io_soap_sanitize_long_input) {
 FOSSIL_TEST_CASE(c_test_io_soap_suggest) {
     const char *input = "This is a rot-brain sentence.";
     const char *expected = "This is a stupid sentence.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(c_test_io_soap_suggest_no_offensive) {
     const char *input = "This is a clean sentence.";
     const char *expected = "This is a clean sentence.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
@@ -177,15 +177,15 @@ FOSSIL_TEST_CASE(c_test_io_soap_sanitize_with_tabs) {
 FOSSIL_TEST_CASE(c_test_io_soap_suggest_leetspeak) {
     const char *input = "Th1s 1s 4 l33tspeak s3nt3nc3.";
     const char *expected = "This is a leetspeak sentence.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(c_test_io_soap_suggest_mixed_case) {
     const char *input = "This Is A Rot-Brain Sentence.";
     const char *expected = "This Is A stupid Sentence.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
 
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
@@ -194,23 +194,23 @@ FOSSIL_TEST_CASE(c_test_io_soap_suggest_mixed_case) {
 FOSSIL_TEST_CASE(c_test_io_soap_suggest_with_special_chars) {
     const char *input = "This is a test with special chars #$%^&*!";
     const char *expected = "This is a test with special chars #$%^&*!";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(c_test_io_soap_suggest_with_newlines) {
     const char *input = "This is a test\nwith newlines.";
     const char *expected = "This is a test\nwith newlines.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(c_test_io_soap_suggest_with_tabs) {
     const char *input = "This is a test\twith tabs.";
     const char *expected = "This is a test\twith tabs.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }

code/tests/cases/test_soap.cpp

@@ -94,15 +94,15 @@ FOSSIL_TEST_CASE(cpp_test_io_soap_sanitize_long_input) {
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest) {
     const char *input = "This is a rot-brain sentence.";
     const char *expected = "This is a stupid sentence.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_no_offensive) {
     const char *input = "This is a clean sentence.";
     const char *expected = "This is a clean sentence.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
@@ -177,15 +177,15 @@ FOSSIL_TEST_CASE(cpp_test_io_soap_sanitize_with_tabs) {
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_leetspeak) {
     const char *input = "Th1s 1s 4 l33tspeak s3nt3nc3.";
     const char *expected = "This is a leetspeak sentence.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_mixed_case) {
     const char *input = "This Is A Rot-Brain Sentence.";
     const char *expected = "This Is A stupid Sentence.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
 
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
@@ -194,23 +194,23 @@ FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_mixed_case) {
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_with_special_chars) {
     const char *input = "This is a test with special chars #$%^&*!";
     const char *expected = "This is a test with special chars #$%^&*!";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_with_newlines) {
     const char *input = "This is a test\nwith newlines.";
     const char *expected = "This is a test\nwith newlines.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_with_tabs) {
     const char *input = "This is a test\twith tabs.";
     const char *expected = "This is a test\twith tabs.";
-    char *result = fossil_io_soap_suggest(input, '*');
+    char *result = fossil_io_soap_suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
@@ -260,14 +260,14 @@ FOSSIL_TEST_CASE(cpp_test_io_soap_sanitize_long_input_stl) {
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_stl) {
     std::string input = "This is a rot-brain sentence.";
     std::string expected = "This is a stupid sentence.";
-    std::string result = fossil::io::Soap::suggest(input, '*');
+    std::string result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected.c_str(), result.c_str());
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_no_offensive_stl) {
     std::string input = "This is a clean sentence.";
     std::string expected = "This is a clean sentence.";
-    std::string result = fossil::io::Soap::suggest(input, '*');
+    std::string result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected.c_str(), result.c_str());
 }
 
@@ -336,35 +336,35 @@ FOSSIL_TEST_CASE(cpp_test_io_soap_sanitize_with_tabs_stl) {
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_leetspeak_stl) {
     std::string input = "Th1s 1s 4 l33tspeak s3nt3nc3.";
     std::string expected = "This is a leetspeak sentence.";
-    std::string result = fossil::io::Soap::suggest(input, '*');
+    std::string result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected.c_str(), result.c_str());
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_mixed_case_stl) {
     std::string input = "This Is A Rot-Brain Sentence.";
     std::string expected = "This Is A stupid Sentence.";
-    std::string result = fossil::io::Soap::suggest(input, '*');
+    std::string result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected.c_str(), result.c_str());
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_with_special_chars_stl) {
     std::string input = "This is a test with special chars #$%^&*!";
     std::string expected = "This is a test with special chars #$%^&*!";
-    std::string result = fossil::io::Soap::suggest(input, '*');
+    std::string result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected.c_str(), result.c_str());
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_with_newlines_stl) {
     std::string input = "This is a test\nwith newlines.";
     std::string expected = "This is a test\nwith newlines.";
-    std::string result = fossil::io::Soap::suggest(input, '*');
+    std::string result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected.c_str(), result.c_str());
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_with_tabs_stl) {
     std::string input = "This is a test\twith tabs.";
     std::string expected = "This is a test\twith tabs.";
-    std::string result = fossil::io::Soap::suggest(input, '*');
+    std::string result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected.c_str(), result.c_str());
 }
 
@@ -419,15 +419,15 @@ FOSSIL_TEST_CASE(cpp_test_io_soap_sanitize_long_input_cstr) {
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_cstr) {
     const char *input = "This is a rot-brain sentence.";
     const char *expected = "This is a stupid sentence.";
-    char *result = fossil::io::Soap::suggest(input, '*');
+    char *result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_no_offensive_cstr) {
     const char *input = "This is a clean sentence.";
     const char *expected = "This is a clean sentence.";
-    char *result = fossil::io::Soap::suggest(input, '*');
+    char *result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
@@ -502,39 +502,39 @@ FOSSIL_TEST_CASE(cpp_test_io_soap_sanitize_with_tabs_cstr) {
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_leetspeak_cstr) {
     const char *input = "Th1s 1s 4 l33tspeak s3nt3nc3.";
     const char *expected = "This is a leetspeak sentence.";
-    char *result = fossil::io::Soap::suggest(input, '*');
+    char *result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_mixed_case_cstr) {
     const char *input = "This Is A Rot-Brain Sentence.";
     const char *expected = "This Is A stupid Sentence.";
-    char *result = fossil::io::Soap::suggest(input, '*');
+    char *result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_with_special_chars_cstr) {
     const char *input = "This is a test with special chars #$%^&*!";
     const char *expected = "This is a test with special chars #$%^&*!";
-    char *result = fossil::io::Soap::suggest(input, '*');
+    char *result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_with_newlines_cstr) {
     const char *input = "This is a test\nwith newlines.";
     const char *expected = "This is a test\nwith newlines.";
-    char *result = fossil::io::Soap::suggest(input, '*');
+    char *result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }
 
 FOSSIL_TEST_CASE(cpp_test_io_soap_suggest_with_tabs_cstr) {
     const char *input = "This is a test\twith tabs.";
     const char *expected = "This is a test\twith tabs.";
-    char *result = fossil::io::Soap::suggest(input, '*');
+    char *result = fossil::io::Soap::suggest(input);
     ASSUME_ITS_EQUAL_CSTR(expected, result);
     free(result);
 }