Skip to content

Conversation

@ethanleelge
Copy link
Contributor

@ethanleelge ethanleelge commented Feb 11, 2025

Description

Remove the decimal part of the platform version and convert it to an integer.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@ethanleelge ethanleelge added the chore [PR/Issue] Refactoring, maintenance the code label Feb 11, 2025
@ethanleelge ethanleelge self-assigned this Feb 11, 2025
@ethanleelge ethanleelge changed the title Check if the Check if the platform version is a decimal or not Check platform version Feb 11, 2025
@ethanleelge ethanleelge force-pushed the platform_version_check branch 2 times, most recently from 6ccf9e6 to b6725a0 Compare February 11, 2025 08:10
@soimkim
Copy link
Contributor

soimkim commented Feb 11, 2025

@ethanleelge , Description 작성 부탁드립니다.
제목도 Platform 버전을 정수로 표기하는 것으로 변경 부탁드립니다.

@ethanleelge ethanleelge changed the title Check platform version Fix the platform version as an integer Feb 11, 2025
Signed-off-by: Ethan Lee <[email protected]>
@ethanleelge ethanleelge force-pushed the platform_version_check branch from b6725a0 to 10200f8 Compare February 11, 2025 11:31
@ethanleelge
Copy link
Contributor Author

이전 추가된 코드는 제거하고,
pattern = re.compile(r'.PLATFORM_VERSION\s=\s*(\d+.?\d?)(.\d)\S*\s*')
--> pattern = re.compile(r'.PLATFORM_VERSION\s=\s*(\d+).?\d*\S*\s*')
로 수정했습니다.


except Exception:
pass
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후 불필요한 빈칸이 추가되지 않도록 해주시면 감사합니다.

@soimkim soimkim merged commit 40c50a9 into main Feb 11, 2025
4 checks passed
@soimkim soimkim deleted the platform_version_check branch February 11, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants