Skip to content

Commit 357947b

Browse files
authored
Fix the parsing bug for swift's Package.resolved (#107)
* Fix the parsing bug for swift's Package.resolved * Remove tox wheel to update tox 4.x * Add allowlist_externals for tox 4.x Signed-off-by: Jiyeong Seok <[email protected]>
1 parent f867974 commit 357947b

File tree

4 files changed

+9
-12
lines changed

4 files changed

+9
-12
lines changed

.github/workflows/pull-request.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ jobs:
4646
run: |
4747
python -m pip install --upgrade pip
4848
pip install tox
49-
pip install tox-wheel
5049
sudo npm install -g license-checker
5150
- name: Run Tox
5251
run: |
@@ -66,7 +65,6 @@ jobs:
6665
run: |
6766
python -m pip install --upgrade pip
6867
pip install tox
69-
pip install tox-wheel
7068
- name: Run Tox
7169
run: |
7270
tox -e run_windows

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from codecs import open
88
import os
99
import shutil
10-
from setuptools import setup, find_packages
10+
from setuptools import setup, find_namespace_packages
1111

1212
with open('README.md', 'r', 'utf-8') as f:
1313
reamdme = f.read()
@@ -37,7 +37,7 @@
3737
name=_PACKAEG_NAME,
3838
version='3.12.2',
3939
package_dir={"": "src"},
40-
packages=find_packages(where='src'),
40+
packages=find_namespace_packages(where='src'),
4141
description='FOSSLight Dependency Scanner',
4242
long_description=reamdme,
4343
long_description_content_type='text/markdown',

src/fosslight_dependency/package_manager/Swift.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,9 @@ def parse_oss_information(self, f_name):
7070

7171
oss_name = f"{self.package_manager_name}:{oss_origin_name}"
7272

73-
revision = key['state']['revision']
74-
version = key['state']['version']
75-
if version is None:
76-
oss_version = revision
77-
else:
78-
oss_version = version
73+
oss_version = key['state'].get('version', None)
74+
if oss_version is None:
75+
oss_version = key['state'].get('revision', None)
7976

8077
dn_loc = homepage
8178
license_name = ''

tox.ini

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,12 @@ skipdist = true
66
toxworkdir = {toxinidir}/tests/
77

88
[testenv]
9-
wheel = true
109
install_command = pip install {opts} {packages}
1110
setenv =
1211
PYTHONPATH=.
12+
allowlist_externals =
13+
{toxinidir}/dist/cli
14+
{toxinidir}\dist\cli.exe
1315

1416
[pytest]
1517
filterwarnings = ignore::DeprecationWarning
@@ -84,4 +86,4 @@ commands =
8486
# Test for nuget (for packageReference)
8587
{toxinidir}\dist\cli.exe -p tests\test_nuget -o tests\result\nuget1
8688
# Test for nuget2 (for packages.config)
87-
{toxinidir}\dist\cli.exe -p tests\test_nuget2 -o tests\result\nuget2
89+
{toxinidir}\dist\cli.exe -p tests\test_nuget2 -o tests\result\nuget2

0 commit comments

Comments
 (0)