Fix issues with npm ls output (#132)

* Fix issues with npm ls output (#134)

---------

Signed-off-by: Jiyeong Seok <[email protected]>
Signed-off-by: Ruan Heyns <[email protected]>
Co-authored-by: Ruan Heyns <[email protected]>
Co-authored-by: Ruan Heyns <[email protected]>

Author: 3 people

src/fosslight_dependency/package_manager/Npm.py

@@ -79,6 +79,9 @@ def parse_rel_dependencies(self, rel_name, rel_ver, rel_dependencies):
         _version = 'version'
 
         for rel_dep_name in rel_dependencies.keys():
+            # Optional, non-installed dependencies are listed as empty objects
+            if rel_dependencies[rel_dep_name] == {}:
+                continue
             if f'{rel_name}({rel_ver})' not in self.relation_tree:
                 self.relation_tree[f'{rel_name}({rel_ver})'] = []
             self.relation_tree[f'{rel_name}({rel_ver})'].append(f'{rel_dep_name}({rel_dependencies[rel_dep_name][_version]})')
@@ -91,13 +94,17 @@ def parse_transitive_relationship(self):
         _version = 'version'
         _name = 'name'
 
-        cmd = 'npm ls -a --prod --json'
-        rel_tree = subprocess.check_output(cmd, shell=True, encoding='utf8')
+        cmd = 'npm ls -a --prod --json -s'
+        result = subprocess.run(cmd, shell=True, capture_output=True, text=True)
+        rel_tree = result.stdout
         if rel_tree is None:
             logger.error(f"It returns the error: {cmd}")
-            logger.error(f"Fail to run {cmd}")
+            logger.error(f"No output for {cmd}")
             return False
 
+        if result.returncode == 1:
+            logger.warning(f'npm ls returns an error code: {result.stderr}')
+
         try:
             rel_json = json.loads(rel_tree)
             self.package_name = f'{rel_json[_name]}({rel_json[_version]})'
@@ -110,6 +117,7 @@ def parse_direct_dependencies(self):
             self.parse_transitive_relationship()
         except Exception as e:
             logger.warning(f'Cannot print direct/transitive dependency: {e}')
+            self.direct_dep = False
 
     def parse_oss_information(self, f_name):
         with open(f_name, 'r', encoding='utf8') as json_file: