Skip to content

Commit 7a44413

Browse files
authored
Fix the android detect mode bug (#266)
* Fix the android detect mode bug * Fix reuese error --------- Signed-off-by: 석지영/책임연구원/SW공학(연)Open Source TP <[email protected]>
1 parent 0b88834 commit 7a44413

File tree

4 files changed

+43
-26
lines changed

4 files changed

+43
-26
lines changed

.reuse/dep5

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ License: Apache-2.0
1616

1717
Files: requirements*.txt
1818
Copyright: 2021 LG Electronics
19-
License: Apache-2.0
19+
License: LicenseRef-3rd_party_licenses
2020

2121
Files: setup.cfg
2222
Copyright: 2021 LG Electronics
@@ -123,6 +123,6 @@ Copyright: 2024 junegunn(Junegunn Choi)
123123
License: MIT
124124

125125
Files: LICENSES/LicenseRef-3rd_party_licenses.txt
126-
Copyright: NOASSERTION
127-
License: CC0-1.0
128-
Comment: This license text is unused
126+
Copyright: 2021 LG Electronics
127+
License: Apache-2.0
128+
Comment: Third-party license information file

THIRD_PARTY_NOTICE

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# SPDX-FileCopyrightText: 2021 LG Electronics Inc.
2+
# SPDX-License-Identifier: LicenseRef-3rd_party_licenses
3+
4+
This file acknowledges third-party packages and their licenses.
5+
For detailed license information, see LICENSES/LicenseRef-3rd_party_licenses.txt

src/fosslight_dependency/_package_manager.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ def run_gradle_task(self):
154154
shutil.move(module_gradle_backup, module_build_gradle)
155155
if os.path.isfile(self.input_file_name):
156156
logger.info(f'Found {self.input_file_name}, skip to run plugin.')
157+
self.set_direct_dependencies(False)
157158
ret_task = True
158159
return ret_task
159160

src/fosslight_dependency/run_dependency_scanner.py

Lines changed: 33 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -258,34 +258,45 @@ def run_dependency_scanner(package_manager='', input_dir='', output_dir_file='',
258258
fail_pm = defaultdict(lambda: defaultdict(list))
259259
cover_comment = ''
260260
for pm, manifest_file_name_list in found_package_manager.items():
261-
for manifest_dir, manifest_file_name in manifest_file_name_list.items():
262-
input_dir = manifest_dir
263-
if manifest_file_name == pass_key:
264-
continue
265-
os.chdir(input_dir)
261+
if not manifest_file_name_list and not autodetect:
266262
ret, package_dep_item_list, cover_comment = analyze_dependency(pm, input_dir, output_path,
267263
pip_activate_cmd, pip_deactivate_cmd,
268264
output_custom_dir, app_name, github_token,
269-
manifest_file_name, direct)
265+
[], direct)
270266
if ret:
271-
success_pm[pm][input_dir].extend(manifest_file_name)
267+
success_pm[pm][input_dir].extend(['manual mode (-m option)'])
272268
scan_item.append_file_items(package_dep_item_list)
273-
274-
dup_pm = None
275-
if pm == const.GRADLE and const.ANDROID in found_package_manager:
276-
dup_pm = const.ANDROID
277-
elif pm == const.ANDROID and const.GRADLE in found_package_manager:
278-
dup_pm = const.GRADLE
279-
280-
if dup_pm:
281-
if dup_pm in fail_pm and input_dir in fail_pm[dup_pm]:
282-
fail_pm[dup_pm].pop(input_dir, None)
283-
if not fail_pm[dup_pm]:
284-
fail_pm.pop(dup_pm, None)
285-
else:
286-
found_package_manager[dup_pm][manifest_dir] = pass_key
287269
else:
288-
fail_pm[pm][input_dir].extend(manifest_file_name)
270+
fail_pm[pm][input_dir].extend(['manual mode (-m option)'])
271+
else:
272+
for manifest_dir, manifest_file_name in manifest_file_name_list.items():
273+
input_dir = manifest_dir
274+
if manifest_file_name == pass_key:
275+
continue
276+
os.chdir(input_dir)
277+
ret, package_dep_item_list, cover_comment = analyze_dependency(pm, input_dir, output_path,
278+
pip_activate_cmd, pip_deactivate_cmd,
279+
output_custom_dir, app_name, github_token,
280+
manifest_file_name, direct)
281+
if ret:
282+
success_pm[pm][input_dir].extend(manifest_file_name)
283+
scan_item.append_file_items(package_dep_item_list)
284+
285+
dup_pm = None
286+
if pm == const.GRADLE and const.ANDROID in found_package_manager:
287+
dup_pm = const.ANDROID
288+
elif pm == const.ANDROID and const.GRADLE in found_package_manager:
289+
dup_pm = const.GRADLE
290+
291+
if dup_pm:
292+
if dup_pm in fail_pm and input_dir in fail_pm[dup_pm]:
293+
fail_pm[dup_pm].pop(input_dir, None)
294+
if not fail_pm[dup_pm]:
295+
fail_pm.pop(dup_pm, None)
296+
else:
297+
found_package_manager[dup_pm][manifest_dir] = pass_key
298+
else:
299+
fail_pm[pm][input_dir].extend(manifest_file_name)
289300

290301
success_pm = {k: dict(v) for k, v in success_pm.items()}
291302
fail_pm = {k: dict(v) for k, v in fail_pm.items()}

0 commit comments

Comments
 (0)