Skip to content

Commit 8046ee8

Browse files
committed
modify to generate a single oss for multiple license names for npm,maven
1 parent 774fb6c commit 8046ee8

File tree

2 files changed

+23
-34
lines changed

2 files changed

+23
-34
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
if __name__ == "__main__":
1414
setup(
1515
name = 'fosslight_dependency',
16-
version = '3.0.1',
16+
version = '3.0.2',
1717
packages = find_packages(),
1818
description = 'FOSSLight Dependency',
1919
long_description = 'It is a script file to scan dependencies through package manager file and generate a result report.',

unified_script/dependency_unified.py

Lines changed: 22 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import logging
2020
import requests
2121

22-
VERSION = "3.0.1"
22+
VERSION = "3.0.2"
2323

2424
# Check the manifest file
2525
manifest_array = [["pip", "requirements.txt"], ["npm", "package.json"], ["maven", "pom.xml"],
@@ -731,9 +731,9 @@ def parse_and_generate_output_npm(tmp_file_name):
731731
oss_name = "npm:" + oss_init_name
732732

733733
if d['licenses']:
734-
license_name = d['licenses']
734+
licenses = d['licenses']
735735
else:
736-
license_name = ''
736+
licenses = ''
737737

738738
if d['repository']:
739739
dn_loc = d['repository']
@@ -748,23 +748,20 @@ def parse_and_generate_output_npm(tmp_file_name):
748748
else:
749749
copyright_text = ''
750750

751-
multi_license = check_multi_license(license_name)
751+
multi_license = check_multi_license(licenses)
752752

753753
if multi_license == 1:
754-
for l_idx in range(0, len(license_name)):
755-
license_name = license_name[l_idx].replace(",", "")
756-
757-
insert_oss_report(wb.active,
758-
[str(idx), 'package.json', oss_name, oss_version, license_name, dn_loc,
759-
homepage, copyright_text, '', '', ''])
760-
idx += 1
754+
license_list = []
755+
for l_idx in licenses:
756+
license_list.append(l_idx.replace(",", ""))
757+
license_name = ', '.join(license_list)
761758
else:
762759
license_name = license_name.replace(",", "")
763760

764-
insert_oss_report(wb.active,
765-
[str(idx), 'package.json', oss_name, oss_version, license_name, dn_loc, homepage,
766-
copyright_text, '', '', ''])
767-
idx += 1
761+
insert_oss_report(wb.active,
762+
[str(idx), 'package.json', oss_name, oss_version, license_name, dn_loc, homepage,
763+
copyright_text, '', '', ''])
764+
idx += 1
768765

769766
save_oss_report(wb)
770767

@@ -786,33 +783,25 @@ def parse_and_generate_output_maven(input_fp):
786783

787784
oss_name = groupid + ":" + artifactid
788785

789-
license_num = 1
790786
licenses = d.find("licenses")
791787
if len(licenses):
788+
license_list = []
792789
for key_license in licenses.iter("license"):
793-
license_name = key_license.findtext("name")
794-
dn_loc = dn_url + groupid + "/" + artifactid + "/" + version
795-
homepage = dn_url + groupid + "/" + artifactid
796-
797-
license_name = license_name.replace(",", "")
790+
license_name_i = key_license.findtext("name")
791+
license_list.append(license_name_i.replace(",", ""))
798792

799-
insert_oss_report(wb.active,
800-
[str(idx), 'pom.xml', oss_name, oss_version, license_name, dn_loc, homepage, '', '',
801-
'', ''])
802-
803-
license_num += 1
804-
idx += 1
793+
license_name = ', '.join(license_list)
805794
else:
806795
# Case that doesn't include License tag value.
807796
license_name = ''
808-
dn_loc = dn_url + groupid + "/" + artifactid + "/" + version
809-
homepage = dn_url + groupid + "/" + artifactid
797+
798+
dn_loc = dn_url + groupid + "/" + artifactid + "/" + version
799+
homepage = dn_url + groupid + "/" + artifactid
810800

811-
insert_oss_report(wb.active,
812-
[str(idx), 'pom.xml', oss_name, oss_version, license_name, dn_loc, homepage, '', '', '',
813-
''])
801+
insert_oss_report(wb.active,
802+
[str(idx), 'pom.xml', oss_name, oss_version, license_name, dn_loc, homepage, '', '', '', ''])
814803

815-
idx += 1
804+
idx += 1
816805

817806
save_oss_report(wb)
818807

0 commit comments

Comments
 (0)