Merge pull request #97 from fosslight/develop

Fix error when it fails to create venv for Pypi

Author: dd-jy

src/fosslight_dependency/_package_manager.py

@@ -255,9 +255,8 @@ def check_and_run_license_scanner(platform, license_scanner_bin, file_dir):
                 license_name = ""
                 return license_name
             else:
-                ret = os.system(run_license_scanner)
-                if ret != 0:
-                    logger.info("=> (No error) This is the information that the license was not found.")
+                ret = subprocess.run(run_license_scanner, shell=True, stderr=subprocess.PIPE)
+                if ret.returncode != 0 or ret.stderr:
                     return ""
 
             fp = open(tmp_output_file_name, "r", encoding='utf8')

src/fosslight_dependency/package_manager/Pypi.py

@@ -110,10 +110,13 @@ def create_virtualenv(self):
         cmd = cmd_separator.join(cmd_list)
 
         try:
-            cmd_ret = subprocess.call(cmd, shell=True)
-            if cmd_ret != 0:
+            cmd_ret = subprocess.run(cmd, shell=True, stderr=subprocess.PIPE)
+            if cmd_ret.returncode != 0:
+                ret = False
+                err_msg = f"return code({cmd_ret.returncode})"
+            elif cmd_ret.stderr.decode('utf-8').rstrip().startswith('ERROR:'):
                 ret = False
-                err_msg = f"return code({cmd_ret})"
+                err_msg = f"stderr msg({cmd_ret.stderr})"
         except Exception as e:
             ret = False
             err_msg = e
@@ -234,6 +237,7 @@ def parse_oss_information(self, f_name):
         sheet_list = []
         comment = ''
         try:
+            oss_init_name = ''
             with open(f_name, 'r', encoding='utf-8') as json_file:
                 json_data = json.load(json_file)
 
@@ -267,7 +271,7 @@ def parse_oss_information(self, f_name):
                                    license_name, dn_loc, homepage, '', '', comment])
 
         except Exception as ex:
-            logger.error(f"Failed to parse oss information: {ex}")
+            logger.warning(f"Fail to parse oss information: {oss_init_name}({ex})")
 
         return sheet_list