Skip to content

Commit f18cc23

Browse files
committed
Fix the magic num
Signed-off-by: Jiyeong Seok <[email protected]>
1 parent cec85e8 commit f18cc23

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ openpyxl
66
progress
77
pyyaml
88
beautifulsoup4
9-
fosslight_util>=1.3.13
9+
fosslight_util>=1.4.1
1010
fosslight_dependency>=3.7.4
1111
fosslight_binary>=4.0.7
1212
fosslight_reuse>=2.2.1

src/fosslight_scanner/_run_compare.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ def write_result_html(output_file, compared_result, before_yaml, after_yaml):
9393

9494
status = [ADD, DELETE, CHANGE]
9595
row = 2
96+
MIN_ROW_NUM = 100
9697
for st in status:
9798
for oi in compared_result[st]:
9899
compared_row = parse_result_for_table(oi, st)
@@ -104,7 +105,7 @@ def write_result_html(output_file, compared_result, before_yaml, after_yaml):
104105
tr.insert(i, td)
105106
table_html.insert(row, tr)
106107
row += 1
107-
if row >= 102:
108+
if row >= MIN_ROW_NUM + 2:
108109
p = f.new_tag('p')
109110
p.string = "(!) There are so many different oss.\
110111
See the attached excel file for the full comparison result."

0 commit comments

Comments
 (0)