Skip to content

Commit 6b9971d

Browse files
committed
Replace excel_writer with fosslight_util
1 parent b42247d commit 6b9971d

File tree

4 files changed

+25
-109
lines changed

4 files changed

+25
-109
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
if __name__ == "__main__":
1515
setup(
1616
name='fosslight_source',
17-
version='1.4.2',
17+
version='1.4.3',
1818
package_dir={"": "src"},
1919
packages=find_packages(where='src'),
2020
description='FOSSLight Source',

src/fosslight_source/_write_oss_report_src.py

Lines changed: 0 additions & 71 deletions
This file was deleted.

src/fosslight_source/convert_scancode.py

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@
1414
from fosslight_util.set_log import init_log
1515
from fosslight_util.set_log import init_log_item
1616
import yaml
17-
from ._write_oss_report_src import write_result_to_csv, write_result_to_excel
1817
from ._parsing_scancode_file_item import parsing_file_item
18+
from fosslight_util.write_excel import write_excel_and_csv
1919

2020
logger = logging.getLogger(constant.LOGGER_NAME)
2121
_PKG_NAME = "fosslight_source"
2222
_ERROR_PREFIX = "* Error : "
2323

2424

25-
def convert_json_to_excel(scancode_json, excel_name, csv_name):
25+
def convert_json_to_excel(scancode_json, excel_name):
2626
file_list = []
2727
_result_log = init_log_item(_PKG_NAME)
2828
msg = ""
@@ -34,7 +34,7 @@ def convert_json_to_excel(scancode_json, excel_name, csv_name):
3434
file_list = get_detected_licenses_from_scancode(
3535
scancode_json)
3636
if len(file_list) > 0:
37-
sheet_list["SRC"] = file_list
37+
sheet_list["SRC"] = [scan_item.get_row_to_print() for scan_item in file_list]
3838
elif os.path.isdir(scancode_json):
3939
for root, dirs, files in os.walk(scancode_json):
4040
for file in files:
@@ -45,18 +45,14 @@ def convert_json_to_excel(scancode_json, excel_name, csv_name):
4545
result_file)
4646
if len(file_list) > 0:
4747
file_name = os.path.basename(file)
48-
sheet_list["SRC_" + file_name] = file_list
48+
sheet_list["SRC_" + file_name] = [scan_item.get_row_to_print() for scan_item in file_list]
4949
except Exception as ex:
5050
pass
5151

52-
if len(sheet_list) > 0:
53-
write_result_to_excel(excel_name, sheet_list)
54-
_result_log["OSS Report"] = excel_name
55-
56-
if platform.system() != "Windows":
57-
write_result_to_csv(csv_name, sheet_list)
58-
else:
59-
msg = "There is no item to print in OSS-Report."
52+
success_to_write, writing_msg = write_excel_and_csv(excel_name, sheet_list)
53+
logger.warn("* Writing excel :"+str(success_to_write)+ " "+writing_msg)
54+
if success_to_write:
55+
_result_log["OSS Report"] = excel_name+".xlsx"
6056

6157
except Exception as ex:
6258
success = False
@@ -116,16 +112,13 @@ def main():
116112
if output_file_name == "":
117113
output_dir = os.getcwd()
118114
oss_report_name = "OSS-Report_" + start_time
119-
csv_file_name = "result_" + start_time
120115
else:
121116
oss_report_name = output_file_name
122-
csv_file_name = output_file_name
123117
output_dir = os.path.dirname(os.path.abspath(output_file_name))
124118

125119
logger = init_log(os.path.join(output_dir, "fosslight_src_log_"+start_time+".txt"))
126120

127-
convert_json_to_excel(path_to_find_bin,
128-
oss_report_name + ".xlsx", csv_file_name + ".csv")
121+
convert_json_to_excel(path_to_find_bin, oss_report_name)
129122

130123

131124
if __name__ == '__main__':

src/fosslight_source/run_scancode.py

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,15 @@
1717
from fosslight_util.set_log import init_log
1818
from fosslight_util.set_log import init_log_item
1919
from fosslight_util.timer_thread import TimerThread
20-
from ._write_oss_report_src import write_result_to_csv, write_result_to_excel
2120
from ._parsing_scancode_file_item import parsing_file_item
21+
from fosslight_util.write_excel import write_excel_and_csv
2222

2323
logger = logging.getLogger(constant.LOGGER_NAME)
2424
warnings.filterwarnings("ignore", category=FutureWarning)
2525
_PKG_NAME = "fosslight_source"
2626
_ERROR_PREFIX = "* Error : "
2727

28+
2829
def print_help_msg():
2930
print("* Required : -p path_to_scan")
3031
print("* Optional : -j ")
@@ -72,12 +73,10 @@ def run_scan(path_to_scan, output_file_name="",
7273

7374
if output_file_name == "":
7475
output_file = "OSS-Report_" + start_time
75-
output_csv_file = "result_" + start_time
7676
output_json_file = "scancode_" + start_time
7777
output_dir = os.getcwd()
7878
else:
7979
output_file = output_file_name
80-
output_csv_file = output_file_name
8180
output_json_file = output_file_name
8281
output_dir = os.path.dirname(os.path.abspath(output_file_name))
8382

@@ -92,7 +91,6 @@ def run_scan(path_to_scan, output_file_name="",
9291

9392
num_cores = multiprocessing.cpu_count() - 1 if num_cores < 0 else num_cores
9493

95-
sheet_list = {}
9694
if os.path.isdir(path_to_scan):
9795
try:
9896
output_json_file = output_json_file+".json" if _write_json_file\
@@ -104,32 +102,28 @@ def run_scan(path_to_scan, output_file_name="",
104102
processes=num_cores,
105103
output_json_pp=output_json_file,
106104
only_findings=True)
107-
108-
if rc:
105+
if not rc:
106+
msg += _ERROR_PREFIX+"Source code analysis failed.\n"
107+
success = False
108+
if results:
109+
sheet_list = {}
109110
for key, value in results.items():
110111
if key == "files":
111112
rc, result_list, parsing_msg = parsing_file_item(value)
112113
_result_log["Parsing Log"] = parsing_msg
113114
if rc:
114-
if len(result_list) > 0:
115-
sheet_list["SRC"] = result_list
116-
write_result_to_excel(
117-
output_file + ".xlsx", sheet_list)
118-
_result_log["OSS Report"] = output_file
119-
else:
120-
msg = "* There is no item"\
121-
" to print in OSS-Report."
122-
if not _windows:
123-
write_result_to_csv(output_csv_file + ".csv", sheet_list)
124-
else:
125-
msg = _ERROR_PREFIX+"Source code analysis failed."
126-
success = False
115+
sheet_list["SRC"] = [scan_item.get_row_to_print() for scan_item in result_list]
116+
success_to_write, writing_msg = write_excel_and_csv(
117+
output_file, sheet_list)
118+
logger.warn("* Writing excel :"+str(success_to_write)+ " "+writing_msg)
119+
if success_to_write:
120+
_result_log["OSS Report"] = output_file +".xlsx"
127121
except Exception as ex:
128122
success = False
129-
msg = _ERROR_PREFIX + str(ex)
123+
msg = _ERROR_PREFIX + str(ex)+"\n"
130124
else:
131125
success = False
132-
msg = _ERROR_PREFIX+"Check the path to scan. :" + path_to_scan
126+
msg = _ERROR_PREFIX+"Check the path to scan. :" + path_to_scan+"\n"
133127

134128
scan_result_msg = str(success)+" "+msg
135129
_result_log["Scan Result"] = scan_result_msg.strip()

0 commit comments

Comments
 (0)