Skip to content

Commit f6ff9f1

Browse files
authored
Merge pull request #62 from fosslight/temp
Amend to print output file name and deal with format option error
2 parents 68a3d64 + 5c49fa2 commit f6ff9f1

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
scancode-toolkit
22
typecode_libmagic
33
XlsxWriter
4-
fosslight_util>=1.3.8
4+
fosslight_util>=1.3.12
55
PyYAML
66
wheel

src/fosslight_source/cli.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@ def main():
8080

8181
start_time = datetime.now().strftime('%Y%m%d_%H%M%S')
8282
success, msg, output_path, output_file, output_extension = check_output_format(output_file_name, format)
83+
if not success:
84+
logger.error(f"Format error. {msg}")
85+
sys.exit(1)
8386
logger, _result_log = init_log(os.path.join(output_path, "fosslight_src_log_"+start_time+".txt"),
8487
True, logging.INFO, logging.DEBUG, _PKG_NAME, path_to_scan)
8588

@@ -111,7 +114,6 @@ def create_report_file(start_time, scanned_result, license_list, selected_scanne
111114
:param need_license: if requested, output matched text (only for scancode).
112115
"""
113116
extended_header = {}
114-
_result_log = {}
115117
sheet_list = {}
116118
_json_ext = ".json"
117119

@@ -143,11 +145,12 @@ def create_report_file(start_time, scanned_result, license_list, selected_scanne
143145
sheet_list["matched_text"] = get_license_list_to_print(license_list)
144146

145147
output_file_without_ext = os.path.join(output_path, output_file)
146-
success_to_write, writing_msg = write_output_file(output_file_without_ext, output_extension, sheet_list, extended_header)
147-
logger.info("Writing Output file(" + output_file + output_extension + "):"
148-
+ str(success_to_write) + " " + writing_msg)
148+
success_to_write, writing_msg, result_file = write_output_file(output_file_without_ext, output_extension,
149+
sheet_list, extended_header)
149150
if success_to_write:
150-
_result_log["Output file"] = output_file_without_ext + output_extension
151+
logger.info(f"Writing Output file({result_file}, success:{success_to_write}")
152+
else:
153+
logger.error(f"Fail to generate result file. msg:({writing_msg})")
151154

152155

153156
def run_all_scanners(path_to_scan, output_file_name="", _write_json_file=False, num_cores=-1,

src/fosslight_source/run_scancode.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,12 +106,12 @@ def run_scan(path_to_scan, output_file_name="",
106106

107107
output_file_without_ext = os.path.join(output_path, output_file)
108108
if not called_by_cli:
109-
success_to_write, writing_msg = write_output_file(output_file_without_ext, output_extension,
110-
sheet_list)
111-
logger.info("Writing Output file(" + output_file + output_extension + "):" + str(success_to_write)
112-
+ " " + writing_msg)
109+
success_to_write, writing_msg, result_file = write_output_file(output_file_without_ext,
110+
output_extension, sheet_list)
113111
if success_to_write:
114-
_result_log["Output file"] = output_file_without_ext + output_extension
112+
logger.info(f"Writing Output file({result_file}, success:{success_to_write}")
113+
else:
114+
logger.error(f"Fail to generate result file. msg:({writing_msg})")
115115

116116
except Exception as ex:
117117
success = False

0 commit comments

Comments
 (0)