Skip to content

Commit 55ef9a7

Browse files
authored
Fix not to create csv if format is empty
1 parent 8dededc commit 55ef9a7

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

src/fosslight_util/output_format.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Copyright (c) 2021 LG Electronics Inc.
44
# SPDX-License-Identifier: Apache-2.0
55
import os
6-
from fosslight_util.write_excel import write_result_to_excel, write_excel_and_csv, write_result_to_csv
6+
from fosslight_util.write_excel import write_result_to_excel, write_result_to_csv
77
from fosslight_util.write_opossum import write_opossum
88
from fosslight_util.write_yaml import write_yaml
99

@@ -62,11 +62,11 @@ def check_output_format(output='', format='', customized_format={}):
6262
def write_output_file(output_file_without_ext, file_extension, sheet_list, extended_header={}):
6363
success = True
6464
msg = ''
65+
if file_extension == '':
66+
file_extension = '.xlsx'
6567
result_file = output_file_without_ext + file_extension
6668

67-
if file_extension == '':
68-
success, msg, result_file = write_excel_and_csv(output_file_without_ext, sheet_list, False, extended_header)
69-
elif file_extension == '.xlsx':
69+
if file_extension == '.xlsx':
7070
success, msg = write_result_to_excel(result_file, sheet_list, extended_header)
7171
elif file_extension == '.csv':
7272
success, msg, result_file = write_result_to_csv(result_file, sheet_list)

src/fosslight_util/write_excel.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -196,15 +196,13 @@ def create_worksheet(workbook, sheet_name, header_row):
196196
return worksheet
197197

198198

199-
def merge_excels(find_excel_dir, final_out, csv=True):
199+
def merge_excels(find_excel_dir, final_out):
200200
success = True
201201
msg = ""
202-
output_files = []
203202
FIND_EXTENSION = '.xlsx'
204203
added_sheet_names = []
205204
try:
206205
files = os.listdir(find_excel_dir)
207-
out_dir = os.path.dirname(final_out)
208206

209207
if len([name for name in files if name.endswith(FIND_EXTENSION)]) > 0:
210208
writer = pd.ExcelWriter(final_out)
@@ -220,19 +218,13 @@ def merge_excels(find_excel_dir, final_out, csv=True):
220218
sheet_name_to_copy = f"{f_short_name}_{sheet_name}"
221219
df_excel = pd.read_excel(
222220
file, sheet_name=sheet_name, engine='openpyxl')
223-
if csv:
224-
csv_file = os.path.join(out_dir, f"{sheet_name_to_copy}.csv")
225-
df_excel.to_csv(csv_file, index=False)
226-
output_files.append(csv_file)
227221
if sheet_name not in added_sheet_names:
228222
sheet_name_to_copy = sheet_name
229223
df_excel.to_excel(writer, sheet_name_to_copy,
230224
index=False)
231225
writer.save()
232-
output_files.append(final_out)
233226
except Exception as ex:
234227
msg = str(ex)
235228
success = False
236-
if success:
237-
msg = ",".join(output_files)
229+
238230
return success, msg

0 commit comments

Comments
 (0)