Merge pull request #161 from foundation-model-stack/fix_validation_info_loading_bug

JRosenkranz · web-flow · commit 3ca15db10260 · 2025-11-05T08:59:07.000-05:00
fixed bug with loading validation info outputs
diff --git a/aiu_fms_testing_utils/testing/validation.py b/aiu_fms_testing_utils/testing/validation.py
@@ -218,6 +218,7 @@ def load_validation_information(
         f"Not enough validation files at {validation_files_path} for a batch size of {batch_size}"
     )
 
+    validation_files_paths.sort(key=lambda p: int(p.name.split(".pt")[0]))
     validation_info = []
     for i, validation_file_path in enumerate(validation_files_paths):
         if i == batch_size:
diff --git a/tests/testing/test_validation.py b/tests/testing/test_validation.py
@@ -37,7 +37,7 @@ def test_validation_info_round_trip(validation_type, post_iteration_hook):
     model.reset_parameters()
 
     seq_length = 64
-    batch_size = 8
+    batch_size = 16
     max_new_tokens = 128
 
     # prepare input_ids

Original file line number	Diff line number	Diff line change
`@@ -218,6 +218,7 @@ def load_validation_information(`
`218`	`218`	`f"Not enough validation files at {validation_files_path} for a batch size of {batch_size}"`
`219`	`219`	`)`
`220`	`220`
	`221`	`+ validation_files_paths.sort(key=lambda p: int(p.name.split(".pt")[0]))`
`221`	`222`	`validation_info = []`
`222`	`223`	`for i, validation_file_path in enumerate(validation_files_paths):`
`223`	`224`	`if i == batch_size:`