Skip to content

Commit 0585642

Browse files
fix: yaml parsing converts floats like 1.0 into integer 1 causing assertion failure (#536)
Signed-off-by: Harikrishnan Balagopal <[email protected]> Co-authored-by: Dushyant Behl <[email protected]>
1 parent 53e5b36 commit 0585642

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

tuning/data/data_config.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,11 @@ def _validate_dataset_config(dataset_config) -> DataSetConfig:
100100
c.builder = builder
101101
if "sampling" in kwargs and kwargs["sampling"] is not None:
102102
ratio = kwargs["sampling"]
103-
assert isinstance(ratio, float) and (
104-
0 <= ratio <= 1.0
103+
# YAML parsing causes 1.0 (float) to be cast to 1 (int)
104+
assert isinstance(ratio, (float, int)) and (
105+
0.0 <= ratio <= 1.0
105106
), f"sampling ratio: {ratio} should be float and in range [0.0,1.0]"
106-
c.sampling = ratio
107+
c.sampling = float(ratio)
107108
if "rename_columns" in kwargs and kwargs["rename_columns"] is not None:
108109
rename = kwargs["rename_columns"]
109110
assert isinstance(

0 commit comments

Comments
 (0)