Skip to content

Commit 0be40e0

Browse files
authored
Merge pull request #219 from tedhtchang/remove-url-dep-ref
Fix PyPi publish error caused by direct url reference
2 parents 4334d6c + 853ba6e commit 0be40e0

File tree

3 files changed

+10
-13
lines changed

3 files changed

+10
-13
lines changed

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,24 @@ This repo provides basic tuning scripts with support for specific models. The re
88
## Installation
99

1010
```
11-
pip install -e .
11+
pip install fms-hf-tuning
1212
```
1313

1414
> Note: After installing, if you wish to use [FlashAttention](https://github.com/Dao-AILab/flash-attention), then you need to install these requirements:
1515
```
16-
pip install -e ".[dev]"
17-
pip install -e ".[flash-attn]"
16+
pip install fms-hf-tuning[dev]
17+
pip install fms-hf-tuning[flash-attn]
1818
```
1919
[FlashAttention](https://github.com/Dao-AILab/flash-attention) requires the [CUDA Toolit](https://developer.nvidia.com/cuda-toolkit) to be pre-installed.
2020

2121
If you wish to use [aim](https://github.com/aimhubio/aim), then you need to install it:
2222
```
23-
pip install -e ".[aim]"
23+
pip install fms-hf-tuning[aim]
2424
```
2525

2626
If you wish to use [fms-acceleration](https://github.com/foundation-model-stack/fms-acceleration), you need to install it.
2727
```
28-
pip install -e ".[fms-accel]"
28+
pip install git+https://github.com/foundation-model-stack/fms-acceleration.git#subdirectory=plugins/framework
2929
```
3030
`fms-acceleration` is a collection of plugins that packages that accelerate fine-tuning / training of large models, as part of the `fms-hf-tuning` suite. For more details on see [this section below](#fms-acceleration).
3131

@@ -389,7 +389,7 @@ Equally you can pass in a JSON configuration for running tuning. See [build doc]
389389

390390
To access `fms-acceleration` features the `[fms-accel]` dependency must first be installed:
391391
```
392-
$ pip install -e .[fms-accel]
392+
$ pip install https://github.com/foundation-model-stack/fms-acceleration.git#subdirectory=plugins/framework
393393
```
394394

395395
Furthermore, the required `fms-acceleration` plugin must be installed. This is done via the command line utility `fms_acceleration.cli`. To show available plugins:

pyproject.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@ dependencies = [
4444
dev = ["wheel>=0.42.0,<1.0", "packaging>=23.2,<24", "ninja>=1.11.1.1,<2.0", "scikit-learn>=1.0, <2.0", "boto3>=1.34, <2.0"]
4545
flash-attn = ["flash-attn>=2.5.3,<3.0"]
4646
aim = ["aim>=3.19.0,<4.0"]
47-
fms-accel = [
48-
"fms_acceleration @ git+https://github.com/foundation-model-stack/fms-acceleration.git#subdirectory=plugins/framework"
49-
]
5047

5148
[tool.setuptools.packages.find]
5249
exclude = ["tests", "tests.*"]

tuning/config/acceleration_configs/acceleration_framework_config.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,10 @@ def get_framework(self):
178178
else:
179179
if not self.is_empty():
180180
raise ValueError(
181-
"No acceleration framework package found. To use, first "
182-
"ensure that 'pip install -e.[fms-accel]' is done first to "
183-
"obtain the acceleration framework dependency. Additional "
184-
"acceleration plugins make be required depending on the requsted "
181+
"No acceleration framework package found. To use, first ensure that "
182+
"'pip install git+https://github.com/foundation-model-stack/fms-acceleration.git#subdirectory=plugins/framework' " # pylint: disable=line-too-long
183+
"is done first to obtain the acceleration framework dependency. Additional "
184+
"acceleration plugins make be required depending on the requested "
185185
"acceleration. See README.md for instructions."
186186
)
187187

0 commit comments

Comments
 (0)