Fixed errors

Signed-off-by: romit <[email protected]>

Author: romitjain

tests/acceleration/test_acceleration_framework.py

@@ -266,7 +266,7 @@ def test_framework_raises_if_used_with_missing_package():
                 copy.deepcopy(MODEL_ARGS),
                 copy.deepcopy(DATA_ARGS),
                 copy.deepcopy(TRAIN_ARGS),
-                PEFT_LORA_ARGS,
+                copy.deepcopy(PEFT_LORA_ARGS),
                 quantized_lora_config=quantized_lora_config,
             )
 
@@ -322,7 +322,7 @@ def test_framework_raises_due_to_invalid_arguments(
                 model_args,
                 copy.deepcopy(DATA_ARGS),
                 train_args,
-                peft_config,
+                copy.deepcopy(peft_config),
                 quantized_lora_config=quantized_lora_config,
             )
 
@@ -379,7 +379,7 @@ def test_framework_initialized_properly_peft(
         train_args = copy.deepcopy(TRAIN_ARGS)
         train_args.output_dir = tempdir
         train_args.save_strategy = "no"
-        train_args.fp16 = True
+        train_args.bf16 = True
         peft_args = copy.deepcopy(PEFT_LORA_ARGS)
         peft_args.target_modules = ["q_proj", "k_proj"]
 
@@ -430,7 +430,7 @@ def test_framework_initialized_properly_foak():
         train_args = copy.deepcopy(TRAIN_ARGS)
         train_args.output_dir = tempdir
         train_args.save_strategy = "no"
-        train_args.fp16 = True
+        train_args.bf16 = True
         peft_args = copy.deepcopy(PEFT_LORA_ARGS)
         peft_args.target_modules = ["q_proj", "k_proj"]
 
@@ -693,7 +693,6 @@ def test_error_raised_with_fused_lora_enabled_without_quantized_argument():
             train_args = copy.deepcopy(TRAIN_ARGS)
             train_args.output_dir = tempdir
             train_args.save_strategy = "no"
-            train_args.fp16 = True
             peft_args = copy.deepcopy(PEFT_LORA_ARGS)
             peft_args.target_modules = ["q_proj", "k_proj"]
 

tests/artifacts/predefined_data_configs/tokenize_and_apply_input_masking_streaming.yaml

@@ -8,7 +8,7 @@ datasets:
     data_handlers:
       - name: tokenize_and_apply_input_masking
         arguments:
-          # remove_columns: all
+          remove_columns: all
           batched: false
           fn_kwargs:
             input_column_name: input

tests/build/test_utils.py

@@ -72,8 +72,8 @@ def test_accelerate_launch_args_user_set_num_processes_ignored(
     assert os.getenv("CUDA_VISIBLE_DEVICES") == "0"
 
 
-@patch.dict(os.environ, {"SET_NUM_PROCESSES_TO_NUM_GPUS": "False"})
-def test_accelerate_launch_args_user_set_num_processes(job_config):
+def test_accelerate_launch_args_user_set_num_processes(job_config, monkeypatch):
+    monkeypatch.setenv("SET_NUM_PROCESSES_TO_NUM_GPUS", "False")
     job_config_copy = copy.deepcopy(job_config)
     job_config_copy["accelerate_launch_args"]["num_processes"] = "3"
 
@@ -100,7 +100,10 @@ def test_accelerate_launch_args_default_fsdp_config_multigpu(job_config):
 
 
 @patch("os.path.exists")
-def test_process_accelerate_launch_custom_config_file(patch_path_exists):
+def test_process_accelerate_launch_custom_config_file(patch_path_exists, monkeypatch):
+    monkeypatch.setenv("SET_NUM_PROCESSES_TO_NUM_GPUS", "False")
+    monkeypatch.setenv("CUDA_VISIBLE_DEVICES", "")
+
     patch_path_exists.return_value = True
 
     dummy_config_path = "dummy_fsdp_config.yaml"

tests/utils/test_embedding_resize.py

@@ -47,6 +47,8 @@ def _inference(
 ) -> str:
     device = "cuda" if torch.cuda.is_available() else "cpu"
     tokenized_input = tokenizer(input_text, return_tensors="pt").to(device)
+    model = model.to(device)
+
     generated_output = model.generate(
         **tokenized_input,
         max_new_tokens=max_new_tokens,

tox.ini

@@ -61,5 +61,25 @@ deps =
     .[aim,mlflow,clearml,scanner-dev,fms-accel-all]
 setenv =
     CUDA_VISIBLE_DEVICES=0
+commands_pre = 
+    pip install --no-build-isolation .[flash-attn]
+commands =
+    pytest tests/acceleration
+    pytest tests/build
+    pytest tests/data
+    pytest tests/trackers
+    pytest tests/trainercontroller
+    pytest tests/utils
+    pytest tests/test_sft_trainer.py
+
+[testenv:gpu]
+description = run all unit tests including requring GPU support
+deps = 
+    pytest>=7
+    .[aim,mlflow,clearml,scanner-dev,fms-accel-all]
+setenv =
+    CUDA_VISIBLE_DEVICES=0
+commands_pre = 
+    pip install --no-build-isolation .[flash-attn]
 commands =
     pytest {posargs:tests}