Fix lint

Signed-off-by: Thara Palanivel <[email protected]>

Author: tharapalanivel

fms_mo/run_quant.py

@@ -308,15 +308,9 @@ def main():
 
         logger = set_log_level(opt_args.log_level, __name__)
 
-        logger.debug(
-            "Input args parsed: \nmodel_args %s, data_args %s, opt_args %s, fms_mo_args %s, gptq_args %s, fp8_args %s",
-            model_args,
-            data_args,
-            opt_args,
-            fms_mo_args,
-            gptq_args,
-            fp8_args,
-        )
+        logger.debug(f"Input args parsed: \nmodel_args {model_args}, data_args {data_args}, \
+                     opt_args {opt_args}, fms_mo_args {fms_mo_args}, gptq_args {gptq_args}, \
+                     fp8_args {fp8_args}")
     except Exception as e:  # pylint: disable=broad-except
         logger.error(traceback.format_exc())
         write_termination_log(
@@ -342,7 +336,7 @@ def main():
         sys.exit(INTERNAL_ERROR_EXIT_CODE)
     except FileNotFoundError as e:
         logger.error(traceback.format_exc())
-        write_termination_log("Unable to load file: {}".format(e))
+        write_termination_log(f"Unable to load file: {e}")
         sys.exit(USER_ERROR_EXIT_CODE)
     except HFValidationError as e:
         logger.error(traceback.format_exc())

fms_mo/utils/config_utils.py

@@ -20,6 +20,7 @@
 
 
 def update_config(config, **kwargs):
+    """Updates config from key-value pairs provided through kwargs"""
     if isinstance(config, (tuple, list)):
         for c in config:
             update_config(c, **kwargs)

fms_mo/utils/error_logging.py

@@ -38,4 +38,4 @@ def write_termination_log(text, log_file="error.log"):
         with open(log_file, "a", encoding="utf-8") as handle:
             handle.write(text)
     except Exception as e:  # pylint: disable=broad-except
-        logging.warning("Unable to write termination log due to error {}".format(e))
+        logging.warning(f"Unable to write termination log due to error {e}")

tests/test_run_quant.py

@@ -85,9 +85,10 @@ def test_run_train_fails_training_data_path_not_exist():
 )
 
 
-# Note: job_config dict gets modified during process training args
 @pytest.fixture(name="job_config", scope="session")
 def fixture_job_config():
+    """Fixture to get happy path dummy config as a dict, note that job_config dict gets 
+    modified during process training args"""
     with open(HAPPY_PATH_DUMMY_CONFIG_PATH, "r", encoding="utf-8") as f:
         dummy_job_config_dict = json.load(f)
     return dummy_job_config_dict
@@ -97,15 +98,16 @@ def fixture_job_config():
 
 
 def test_parse_arguments(job_config):
+    """Test that arg parser can parse json job config correctly"""
     parser = get_parser()
     job_config_copy = copy.deepcopy(job_config)
     (
         model_args,
         data_args,
         opt_args,
-        fms_mo_args,
-        gptq_args,
-        fp8_args,
+        _,
+        _,
+        _,
     ) = parse_arguments(parser, job_config_copy)
     assert str(model_args.torch_dtype) == "torch.bfloat16"
     assert data_args.training_data_path == "data_train"
@@ -114,6 +116,7 @@ def test_parse_arguments(job_config):
 
 
 def test_parse_arguments_defaults(job_config):
+    """Test that defaults set in fms_mo/training_args.py are retained"""
     parser = get_parser()
     job_config_defaults = copy.deepcopy(job_config)
     assert "torch_dtype" not in job_config_defaults
@@ -123,10 +126,10 @@ def test_parse_arguments_defaults(job_config):
     (
         model_args,
         data_args,
-        opt_args,
+        _,
         fms_mo_args,
-        gptq_args,
-        fp8_args,
+        _,
+        _,
     ) = parse_arguments(parser, job_config_defaults)
     assert str(model_args.torch_dtype) == "torch.bfloat16"
     assert model_args.model_revision == "main"