Skip to content

Commit ff5c375

Browse files
BrandonGrothBrandonGroth
committed
fix: Fixed logger.error string formatting in quantizer_error
Signed-off-by: Brandon Groth <[email protected]>
1 parent 9695bfe commit ff5c375

File tree

1 file changed

+43
-44
lines changed

1 file changed

+43
-44
lines changed

‎tests/quantizers/test_quantizer_utils.py‎

Lines changed: 43 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -115,11 +115,11 @@ def quantizer_error(
115115
except AssertionError as e_dtype:
116116
# Debugging info
117117
logger.error("\nTensor Datatype Error:")
118-
logger.error("Quantizer Tuple =", setup)
119-
logger.error("Base Options =", base_options)
120-
logger.error("Other Options =", other_options)
121-
logger.error("FMS Model Optimizer datatype =", qtensor_fms_mo.dtype)
122-
logger.error("Torch datatype =", qtensor_torch.dtype)
118+
logger.error("Quantizer Tuple = %s", setup)
119+
logger.error("Base Options = %s", base_options)
120+
logger.error("Other Options = %s", other_options)
121+
logger.error("FMS Model Optimizer datatype = %s", qtensor_fms_mo.dtype)
122+
logger.error("Torch datatype = %s", qtensor_torch.dtype)
123123
raise e_dtype # Reraise exception
124124

125125
# Check if there any non-numbers in FMS Model Optimizer qtensor
@@ -148,48 +148,48 @@ def quantizer_error(
148148
except AssertionError as e_nan_inf:
149149
# Debugging info
150150
logger.error("\nTensor Non-Number Error:")
151-
logger.error("Quantizer Tuple =", setup)
152-
logger.error("Base Options =", base_options)
153-
logger.error("Other Options =", other_options)
151+
logger.error("Quantizer Tuple = %s", setup)
152+
logger.error("Base Options = %s", base_options)
153+
logger.error("Other Options = %s", other_options)
154154
if num_nan_fms_mo > 0:
155-
logger.error("FMS Model Optimizer # of NaN =", num_nan_fms_mo)
156-
logger.error("Original Tensor =\n", tensor[nan_indices_fms_mo].detach())
155+
logger.error("FMS Model Optimizer # of NaN = %s", num_nan_fms_mo)
156+
logger.error("Original Tensor =\n%s", tensor[nan_indices_fms_mo].detach())
157157
logger.error(
158-
"FMS Model Optimizer Tensor =\n",
158+
"FMS Model Optimizer Tensor =\n%s",
159159
qtensor_fms_mo[nan_indices_fms_mo].detach(),
160160
)
161161
logger.error(
162-
"Torch Tensor =\n", qtensor_torch[nan_indices_fms_mo].detach()
162+
"Torch Tensor =\n%s", qtensor_torch[nan_indices_fms_mo].detach()
163163
)
164164
if num_inf_fms_mo > 0:
165-
logger.error("FMS Model Optimizer # of INF =", num_inf_fms_mo)
166-
logger.error("Original Tensor =\n", tensor[inf_indices_fms_mo].detach())
165+
logger.error("FMS Model Optimizer # of INF = %s", num_inf_fms_mo)
166+
logger.error("Original Tensor =\n%s", tensor[inf_indices_fms_mo].detach())
167167
logger.error(
168-
"FMS Model Optimizer Tensor =\n",
168+
"FMS Model Optimizer Tensor =\n%s",
169169
qtensor_fms_mo[inf_indices_fms_mo].detach(),
170170
)
171171
logger.error(
172-
"Torch Tensor =\n", qtensor_torch[inf_indices_fms_mo].detach()
172+
"Torch Tensor =\n%s", qtensor_torch[inf_indices_fms_mo].detach()
173173
)
174174
if num_nan_torch > 0:
175-
logger.error("Torch # of NaN =", num_nan_torch)
176-
logger.error("Original Tensor =\n", tensor[nan_indices_torch].detach())
175+
logger.error("Torch # of NaN = %s", num_nan_torch)
176+
logger.error("Original Tensor =\n%s", tensor[nan_indices_torch].detach())
177177
logger.error(
178-
"FMS Model Optimizer Tensor =\n",
178+
"FMS Model Optimizer Tensor =\n%s",
179179
qtensor_fms_mo[nan_indices_torch].detach(),
180180
)
181181
logger.error(
182-
"Torch Tensor =\n", qtensor_torch[nan_indices_torch].detach()
182+
"Torch Tensor =\n%s", qtensor_torch[nan_indices_torch].detach()
183183
)
184184
if num_inf_torch > 0:
185-
logger.error("Torch # of INF =", num_inf_torch)
186-
logger.error("Original Tensor =\n", tensor[inf_indices_torch].detach())
185+
logger.error("Torch # of INF = %s", num_inf_torch)
186+
logger.error("Original Tensor =\n%s", tensor[inf_indices_torch].detach())
187187
logger.error(
188-
"FMS Model Optimizer Tensor =\n",
188+
"FMS Model Optimizer Tensor =\n%s",
189189
qtensor_fms_mo[inf_indices_torch].detach(),
190190
)
191191
logger.error(
192-
"Torch Tensor =\n", qtensor_torch[inf_indices_torch].detach()
192+
"Torch Tensor =\n%s", qtensor_torch[inf_indices_torch].detach()
193193
)
194194
raise e_nan_inf # Reraise exception
195195

@@ -221,15 +221,15 @@ def quantizer_error(
221221
except AssertionError as e_constant_qtensor:
222222
# Debugging info
223223
logger.error("\nTensor Constant Tensor Error:")
224-
logger.error("Quantizer Tuple =", setup)
225-
logger.error("Base Options =", base_options)
226-
logger.error("Other Options =", other_options)
227-
logger.error("Original Tensor =\n", tensor.detach())
224+
logger.error("Quantizer Tuple = %s", setup)
225+
logger.error("Base Options = %s", base_options)
226+
logger.error("Other Options = %s", other_options)
227+
logger.error("Original Tensor =\n%s", tensor.detach())
228228
logger.error(
229-
"FMS Model Optimizer Tensor unique vals =\n",
229+
"FMS Model Optimizer Tensor unique vals =\n%s",
230230
fms_mo_unique_vals.detach(),
231231
)
232-
logger.error("Torch Tensor unique vals =\n", torch_unique_vals.detach())
232+
logger.error("Torch Tensor unique vals =\n%s", torch_unique_vals.detach())
233233
raise e_constant_qtensor # reraise exception
234234

235235
# In rare instances due to banker's rounding (ie torch.round), tensors can differ by 1 qlevel
@@ -289,33 +289,32 @@ def quantizer_error(
289289

290290
except AssertionError as e_value:
291291
# Debugging info
292-
logger.error("\nTensor Value Error: ", e_string)
293-
logger.error("Quantizer Tuple =", setup)
294-
logger.error("Base Options =", base_options)
295-
logger.error("Other Options =", other_options)
292+
logger.error("\nTensor Value Error: %s", e_string)
293+
logger.error("Quantizer Tuple = %s", setup)
294+
logger.error("Base Options = %s", base_options)
295+
logger.error("Other Options = %s", other_options)
296296
logger.error(
297-
"Total Non-zero Indices =", total_nonzero_indices, "/", diff.numel()
297+
"Total Non-zero Indices = %s/%s", total_nonzero_indices, diff.numel()
298298
)
299299
logger.error(
300-
"Total Non-scale Indices =", total_scale_indices, "/", diff.numel()
300+
"Total Non-scale Indices = %s/%s", total_scale_indices, diff.numel()
301301
)
302302
logger.error(
303-
"Total Non-scale, Non-zero Indices =",
303+
"Total Non-scale, Non-zero Indices = %s/%s",
304304
total_nonscale_nonzero_indices,
305-
"/",
306305
diff.numel(),
307306
)
308-
logger.error("Nonzero Indicies =\n", nonzero_diff_indices)
309-
logger.error("Original Tensor =\n", tensor[nonzero_diff_indices].detach())
307+
logger.error("Nonzero Indicies =\n%s", nonzero_diff_indices)
308+
logger.error("Original Tensor =\n%s", tensor[nonzero_diff_indices].detach())
310309
logger.error(
311-
"FMS Model Optimizer Tensor =\n",
310+
"FMS Model Optimizer Tensor =\n%s",
312311
qtensor_fms_mo[nonzero_diff_indices].detach(),
313312
)
314313
logger.error(
315-
"Torch Tensor =\n", qtensor_torch[nonzero_diff_indices].detach()
314+
"Torch Tensor =\n%s", qtensor_torch[nonzero_diff_indices].detach()
316315
)
317-
logger.error("Total Diff vals =", diff.unique().numel())
318-
logger.error("Diff unique vals =\n", diff.unique().detach())
316+
logger.error("Total Diff vals =%s", diff.unique().numel())
317+
logger.error("Diff unique vals =\n%s", diff.unique().detach())
319318
raise e_value # Reraise exception
320319

321320

0 commit comments

Comments
 (0)