Skip to content

Conversation

@tomchiverton
Copy link
Contributor

@pfreitag
Copy link
Member

pfreitag commented May 1, 2025

@tomchiverton thanks for this - I was a little confused when I first read your update which says "Note in Lucee 6.2 or later the default log level is ERROR, so no messages will appear by default."

I had thought this meant the default type for cflog was changed to error, but you mean that the lucee appender only writes logs to file with type=error or type=fatal.

So a few suggested updates.

  1. Instead of putting this in the description, let's move it to the lucee engine notes
  2. Let's clarify this a bit, maybe something like this: "In Lucee6.2+ the default appender log level is ERROR, so only logs with type error or fatal would be written to the log file by default"

@tomchiverton
Copy link
Contributor Author

How do I add an engine specific note ?

@pfreitag
Copy link
Member

pfreitag commented May 1, 2025

@tomchiverton under "engines" then "lucee", there is a key called "notes":

"lucee": {"minimum_version":"", "notes":"", "docs":"https://docs.lucee.org/reference/tags/log.html"},

@carehart
Copy link
Contributor

carehart commented May 31, 2025

Looks like doing that last step fell between the cracks. @tomchiverton, would you want to do it (to close out your pr) or would you want one of us to proceed with a new one?

BTW, guys, I don't "live" in github. If a new pr isn't necessary (for someone else to make the change), feel free to clarify. I'm just trying to help, not playing traffic cop. :-) I came on this while reviewing the Lucee breaking changes docs.

Also, it seems it could be helpful to mention in the note that the new default log level for Lucee CAN be changed (rather than leaving the implication that every cflog/write log must be changed), adding a pointer to where it's discussed: https://dev.lucee.org/t/application-log-defaults-to-error-in-6-2/14773

@tomchiverton
Copy link
Contributor Author

I've spent the last half hour fighting Microsoft's website to let me edit two files, with 50% success so far :/

@tomchiverton
Copy link
Contributor Author

I think GitHub's AI infested git client has let me make the required four line change now ?

@carehart
Copy link
Contributor

carehart commented Jun 1, 2025

I think GitHub's AI infested git client has let me make the required four line change now ?

Sorry to hear it was so painful...but think of the good karma. :-) And thanks.

Pete, would you consider adding the link to that point about modifying the overall Lucee log level instead? That's an option some may prefer to changing code. But it will be as unobvious to most folks as the changed behavior that this doc tweak is noting.

@pfreitag pfreitag merged commit c0a2204 into foundeo:master Jun 2, 2025
4 checks passed
@pfreitag
Copy link
Member

pfreitag commented Jun 2, 2025

Thanks for updating that @tomchiverton - @carehart yep, I've updated it again to include that link.

@carehart
Copy link
Contributor

carehart commented Jun 2, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants