refactor: extract learner building logic into factory modules

Reorganise learner construction by splitting monolithic functions into focused factory modules. Move files from src/utils to src/factories to better reflect their purpose as data builders rather than general utilities.

- Extract reference number, learner details, health details, prior attainment, and employment logic into separate factory modules
- Simplify pushLearners by composing learner objects from factory functions
- Update imports to reflect new factory structure
- Clean up formatting in main.js and buildLearningDeliveryArray

Author: JasonWarrenUK

main.js

@@ -92,6 +92,7 @@ function createWindow() {
     win.webContents.toggleDevTools();
   });
 }
+
 app.whenReady().then(() => {
   createWindow();
   app.on("activate", () => {
@@ -208,6 +209,4 @@ ipcMain.on("openSave", (event) => {
   saveDialogue();
 });
 
-app.on("window-all-closed", () => {
-  app.quit();
-});
+app.on("window-all-closed", () => { app.quit() });

src/utils/buildEmploymentArray.js src/factories/buildEmploymentArray.jssrc/utils/buildEmploymentArray.js renamed to src/factories/buildEmploymentArray.js

@@ -0,0 +1,13 @@
+function buildHealthDetails(dataArray, i) {
+  return {
+    LLDDHealthProb: dataArray[i][13] != "99" ? 1 : 9,
+    LLDDandHealthProblem: dataArray[i][13] != "99"
+      ? [{
+        LLDDCat: dataArray[i][13],
+        PrimaryLLDD: 1
+      }]
+      : undefined
+  }
+}
+
+module.exports = { buildHealthDetails };

src/factories/buildHealthDetails.js

@@ -0,0 +1,17 @@
+function buildLearnerDetails(dataArray, i) {
+  return {
+    FamilyName: dataArray[i][4].trim(),
+    GivenNames: dataArray[i][3].trim(),
+    DateOfBirth: dataArray[i][6],
+    Ethnicity: dataArray[i][8],
+    Sex: dataArray[i][5],
+    NINumber: dataArray[i][7].replace(/\s+/g, "").trim(),
+    PlanLearnHours: dataArray[i][16] || undefined,
+    PostcodePrior: dataArray[i][9].trim(),
+    Postcode: dataArray[i][10].trim(),
+    AddLine1: dataArray[i][11].replace(/[^a-zA-Z0-9\s]/g, "").trim().substring(0, 50),
+    TelNo: dataArray[i][12] || undefined
+  }
+}
+
+module.exports = { buildLearnerDetails };

src/factories/buildLearnerDetails.js

@@ -396,10 +396,10 @@ function buildLearningDeliveryArray(dataArray, i) {
               },
             ]
             : []),
-        ],
+        ]
       }] : []
     ),
   ]
 }
 
-module.exports = { buildLearningDeliveryArray };
+module.exports = { buildLearningDeliveryArray };

src/utils/buildLearningDeliveryArray.js …/factories/buildLearningDeliveryArray.jssrc/utils/buildLearningDeliveryArray.js renamed to src/factories/buildLearningDeliveryArray.js src/utils/buildLearningDeliveryArray.js renamed to src/factories/buildLearningDeliveryArray.js

@@ -0,0 +1,10 @@
+function buildPriorAttainment(dataArray, i) {
+  return {
+    PriorAttain: {
+      PriorLevel: dataArray[i][15],
+      DateLevelApp: dataArray[i][14],
+    },
+  }
+}
+
+module.exports = { buildPriorAttainment };

src/factories/buildPriorAttainment.js

@@ -0,0 +1,9 @@
+function buildReferenceNumbers(dataArray, i) {
+  return {
+    LearnRefNumber: dataArray[i][223],
+    ULN: dataArray[i][2],
+    PrevLearnRefNumber: dataArray[i][222]
+  }
+}
+
+module.exports = { buildReferenceNumbers };

src/factories/buildReferenceNumbers.js

@@ -1,43 +1,19 @@
-const { buildEmploymentArray } = require("./buildEmploymentArray");
-const { buildLearningDeliveryArray } = require("./buildLearningDeliveryArray");
+const { buildEmploymentArray } = require("../factories/buildEmploymentArray");
+const { buildHealthDetails } = require("../factories/buildHealthDetails");
+const { buildLearnerDetails } = require("../factories/buildLearnerDetails");
+const { buildLearningDeliveryArray } = require("../factories/buildLearningDeliveryArray");
+const { buildPriorAttainment } = require("../factories/buildPriorAttainment");
+const { buildReferenceNumbers } = require("../factories/buildReferenceNumbers");
 
 function pushLearners(dataArray, xmlBase) {
-  for (let i = 1; i < dataArray.length; i++) {
-    const refNumber = i
-      .toString()
-      .padStart(4, "0");
-
-    const employmentStatusArray = buildEmploymentArray(dataArray, i);
-    const learningDeliveryArray = buildLearningDeliveryArray(dataArray, i);
-
+  for (let i = 1; i <= dataArray.length; i++) {
     const learner = {
-      LearnRefNumber: refNumber,
-      ULN: dataArray[i][2],
-      FamilyName: dataArray[i][4].trim(),
-      GivenNames: dataArray[i][3].trim(),
-      DateOfBirth: dataArray[i][6],
-      Ethnicity: dataArray[i][8],
-      Sex: dataArray[i][5],
-      LLDDHealthProb: dataArray[i][12],
-      NINumber: dataArray[i][7].replace(/\s+/g, "").trim(),
-      PlanLearnHours: dataArray[i][16] || undefined,
-      PostcodePrior: dataArray[i][9].trim(),
-      Postcode: dataArray[i][10].trim(),
-      AddLine1: dataArray[i][11]
-        .replace(/[^a-zA-Z0-9\s]/g, "")
-        .trim()
-        .substring(0, 50),
-      TelNo: dataArray[i][12] || undefined,
-      LLDDHealthProb: dataArray[i][13] != "99" ? 1 : 9,
-      PriorAttain: {
-        PriorLevel: dataArray[i][15],
-        DateLevelApp: dataArray[i][14],
-      },
-      LLDDandHealthProblem: dataArray[i][13] != "99"
-        ? [{ LLDDCat: dataArray[i][13], PrimaryLLDD: 1 }]
-        : undefined,
-      LearnerEmploymentStatus: employmentStatusArray,
-      LearningDelivery: learningDeliveryArray
+      ...buildReferenceNumbers(dataArray, i),
+      ...buildLearnerDetails(dataArray, i),
+      ...buildHealthDetails(dataArray, i),
+      ...buildPriorAttainment(dataArray, i),
+      LearnerEmploymentStatus: buildEmploymentArray(dataArray, i),
+      LearningDelivery: buildLearningDeliveryArray(dataArray, i)
     }
 
     xmlBase.Learner.push(learner);