Skip to content

Commit 59633c7

Browse files
authored
chore: use Version::new over .parse (#220)
1 parent d8dc871 commit 59633c7

File tree

2 files changed

+5
-11
lines changed
  • crates

2 files changed

+5
-11
lines changed

crates/artifacts/solc/src/lib.rs

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2033,25 +2033,20 @@ mod tests {
20332033

20342034
#[test]
20352035
fn can_sanitize_byte_code_hash() {
2036-
let version: Version = "0.6.0".parse().unwrap();
2037-
20382036
let settings = Settings { metadata: Some(BytecodeHash::Ipfs.into()), ..Default::default() };
20392037

20402038
let input =
20412039
SolcInput { language: SolcLanguage::Solidity, sources: Default::default(), settings };
20422040

2043-
let i = input.clone().sanitized(&version);
2041+
let i = input.clone().sanitized(&Version::new(0, 6, 0));
20442042
assert_eq!(i.settings.metadata.unwrap().bytecode_hash, Some(BytecodeHash::Ipfs));
20452043

2046-
let version: Version = "0.5.17".parse().unwrap();
2047-
let i = input.sanitized(&version);
2044+
let i = input.sanitized(&Version::new(0, 5, 17));
20482045
assert!(i.settings.metadata.unwrap().bytecode_hash.is_none());
20492046
}
20502047

20512048
#[test]
20522049
fn can_sanitize_cbor_metadata() {
2053-
let version: Version = "0.8.18".parse().unwrap();
2054-
20552050
let settings = Settings {
20562051
metadata: Some(SettingsMetadata::new(BytecodeHash::Ipfs, true)),
20572052
..Default::default()
@@ -2060,7 +2055,7 @@ mod tests {
20602055
let input =
20612056
SolcInput { language: SolcLanguage::Solidity, sources: Default::default(), settings };
20622057

2063-
let i = input.clone().sanitized(&version);
2058+
let i = input.clone().sanitized(&Version::new(0, 8, 18));
20642059
assert_eq!(i.settings.metadata.unwrap().cbor_metadata, Some(true));
20652060

20662061
let i = input.sanitized(&Version::new(0, 8, 0));
@@ -2233,13 +2228,12 @@ mod tests {
22332228
// <https://github.com/foundry-rs/foundry/issues/9322>
22342229
#[test]
22352230
fn can_sanitize_optimizer_inliner() {
2236-
let version: Version = "0.8.4".parse().unwrap();
22372231
let settings = Settings::default().with_via_ir_minimum_optimization();
22382232

22392233
let input =
22402234
SolcInput { language: SolcLanguage::Solidity, sources: Default::default(), settings };
22412235

2242-
let i = input.clone().sanitized(&version);
2236+
let i = input.clone().sanitized(&Version::new(0, 8, 4));
22432237
assert!(i.settings.optimizer.details.unwrap().inliner.is_none());
22442238

22452239
let i = input.sanitized(&Version::new(0, 8, 5));

crates/compilers/src/compilers/solc/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ mod tests {
459459
sources: Default::default(),
460460
};
461461

462-
let v: Version = "0.8.12".parse().unwrap();
462+
let v = Version::new(0, 8, 12);
463463
let input = SolcVersionedInput::build(
464464
Default::default(),
465465
Default::default(),

0 commit comments

Comments
 (0)