Commit 4645871
authored
test: remove
In preparation to deprecate `testFail*`:
foundry-rs/foundry#9574
- Removes `deployMockERC721` and `deployMockERC20` from `StdUtils` as
their tests includes large amount of `testFail*` tests and is generally
outdated. I haven't been able to find the `deploy*` methods being used
in any public project on Github.
- Implements workaround for other cases
Alternatively we could upstream Solady's mocks and tests (which have
been updated to not use `testFail*` but this feels out of place and
would be incomplete (ERC4626, ERC6909, etc..
https://github.com/Vectorized/solady/tree/main/test/utils/mocks). I
think it is most common for people to rely on the mocks their library
comes with (be it Solmate, Solady or OpenZeppelin) or write their own
wrapper around the token implementation.testFail* tests (#643)1 parent 999be66 commit 4645871
File tree
7 files changed
+20
-1651
lines changed- src
- mocks
- test
- mocks
7 files changed
+20
-1651
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | 7 | | |
10 | 8 | | |
11 | 9 | | |
| |||
119 | 117 | | |
120 | 118 | | |
121 | 119 | | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | 120 | | |
138 | 121 | | |
139 | 122 | | |
| |||
This file was deleted.
0 commit comments