Skip to content

Commit de3fd9d

Browse files
authored
chore(ci): clean up workflow + harden workflow by setting default permission to read only (#65)
* harden ci and clean up * drop no-std compatibility requirement in ci test, no source code change however * fix * no actions: write required I think
1 parent d59d4b5 commit de3fd9d

File tree

3 files changed

+24
-108
lines changed

3 files changed

+24
-108
lines changed

.github/scripts/install_test_binaries.sh

Lines changed: 0 additions & 51 deletions
This file was deleted.

.github/workflows/ci.yml

Lines changed: 24 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
name: CI
22

3+
permissions:
4+
contents: read
5+
36
on:
47
push:
58
branches: [main]
@@ -27,20 +30,12 @@ jobs:
2730
- rust: "1.88" # MSRV
2831
flags: "--all-features"
2932
steps:
30-
- uses: actions/checkout@v3
31-
- uses: dtolnay/rust-toolchain@master
32-
with:
33-
toolchain: ${{ matrix.rust }}
34-
- name: Install Anvil
35-
uses: foundry-rs/foundry-toolchain@v1
33+
- uses: actions/checkout@v5
3634
with:
37-
version: nightly
38-
- name: Install test binaries
39-
shell: bash
40-
run: ./.github/scripts/install_test_binaries.sh
41-
- uses: Swatinem/rust-cache@v2
35+
persist-credentials: false
36+
- uses: dtolnay/rust-toolchain@stable
4237
with:
43-
cache-on-failure: true
38+
toolchain: ${{ matrix.rust }}
4439
# Only run tests on latest stable and above
4540
- name: Install cargo-nextest
4641
if: ${{ matrix.rust != '1.88' }} # MSRV
@@ -56,34 +51,23 @@ jobs:
5651
runs-on: ubuntu-latest
5752
timeout-minutes: 30
5853
steps:
59-
- uses: actions/checkout@v4
54+
- uses: actions/checkout@v5
55+
with:
56+
persist-credentials: false
6057
- uses: dtolnay/rust-toolchain@stable
6158
- uses: Swatinem/rust-cache@v2
6259
with:
6360
cache-on-failure: true
6461
- run: cargo test --workspace --doc
6562
- run: cargo test --all-features --workspace --doc
6663

67-
no-std:
68-
runs-on: ubuntu-latest
69-
timeout-minutes: 30
70-
steps:
71-
- uses: actions/checkout@v3
72-
- uses: dtolnay/rust-toolchain@stable
73-
with:
74-
target: riscv32imac-unknown-none-elf
75-
- uses: taiki-e/install-action@cargo-hack
76-
- uses: Swatinem/rust-cache@v2
77-
with:
78-
cache-on-failure: true
79-
- name: check
80-
run: ./scripts/check_no_std.sh
81-
8264
feature-checks:
8365
runs-on: ubuntu-latest
8466
timeout-minutes: 30
8567
steps:
86-
- uses: actions/checkout@v3
68+
- uses: actions/checkout@v5
69+
with:
70+
persist-credentials: false
8771
- uses: dtolnay/rust-toolchain@stable
8872
- uses: taiki-e/install-action@cargo-hack
8973
- uses: Swatinem/rust-cache@v2
@@ -96,23 +80,24 @@ jobs:
9680
runs-on: ubuntu-latest
9781
timeout-minutes: 30
9882
steps:
99-
- uses: actions/checkout@v4
100-
- uses: dtolnay/rust-toolchain@master
83+
- uses: actions/checkout@v5
10184
with:
102-
toolchain: stable
103-
components: clippy
85+
persist-credentials: false
86+
- uses: dtolnay/rust-toolchain@clippy
10487
- uses: Swatinem/rust-cache@v2
10588
with:
10689
cache-on-failure: true
107-
- run: cargo +stable clippy --workspace --all-targets --all-features
90+
- run: cargo clippy --workspace --all-targets --all-features
10891
env:
10992
RUSTFLAGS: -Dwarnings
11093

11194
docs:
11295
runs-on: ubuntu-latest
11396
timeout-minutes: 30
11497
steps:
115-
- uses: actions/checkout@v3
98+
- uses: actions/checkout@v5
99+
with:
100+
persist-credentials: false
116101
- uses: dtolnay/rust-toolchain@nightly
117102
- uses: Swatinem/rust-cache@v2
118103
with:
@@ -125,7 +110,9 @@ jobs:
125110
runs-on: ubuntu-latest
126111
timeout-minutes: 30
127112
steps:
128-
- uses: actions/checkout@v3
113+
- uses: actions/checkout@v5
114+
with:
115+
persist-credentials: false
129116
- uses: dtolnay/rust-toolchain@nightly
130117
with:
131118
components: rustfmt
@@ -137,10 +124,10 @@ jobs:
137124
ci-success:
138125
runs-on: ubuntu-latest
139126
if: always()
127+
permissions: {}
140128
needs:
141129
- test
142130
- doctest
143-
- no-std
144131
- feature-checks
145132
- clippy
146133
- docs

scripts/check_no_std.sh

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)