simplify claude's shit lol

Author: 0xrusowsky

crates/lint/src/sol/info/unsafe_cheatcodes.rs

@@ -3,8 +3,7 @@ use crate::{
     linter::{EarlyLintPass, LintContext},
     sol::{Severity, SolLint},
 };
-use solar_ast::{Expr, ExprKind, ItemFunction, visit::Visit};
-use std::ops::ControlFlow;
+use solar_ast::{Expr, ExprKind};
 
 declare_forge_lint!(
     UNSAFE_CHEATCODE_USAGE,
@@ -13,43 +12,25 @@ declare_forge_lint!(
     "usage of unsafe cheatcodes that can perform dangerous operations"
 );
 
-impl<'ast> EarlyLintPass<'ast> for UnsafeCheatcodes {
-    fn check_item_function(&mut self, ctx: &LintContext<'_>, func: &'ast ItemFunction<'ast>) {
-        if let Some(body) = &func.body {
-            let mut checker = UnsafeCheatcodeChecker {
-                ctx,
-                unsafe_cheatcodes: &[
-                    "ffi",
-                    "readFile",
-                    "readLine",
-                    "writeFile",
-                    "writeLine",
-                    "removeFile",
-                    "closeFile",
-                    "setEnv",
-                    "deriveKey",
-                ],
-            };
-            let _ = checker.visit_block(body);
-        }
-    }
-}
+const UNSAFE_CHEATCODES: [&'static str; 9] = [
+    "ffi",
+    "readFile",
+    "readLine",
+    "writeFile",
+    "writeLine",
+    "removeFile",
+    "closeFile",
+    "setEnv",
+    "deriveKey",
+];
 
-struct UnsafeCheatcodeChecker<'a, 's> {
-    ctx: &'a LintContext<'s>,
-    unsafe_cheatcodes: &'a [&'a str],
-}
-
-impl<'ast> Visit<'ast> for UnsafeCheatcodeChecker<'_, '_> {
-    type BreakValue = ();
-
-    fn visit_expr(&mut self, expr: &'ast Expr<'ast>) -> ControlFlow<Self::BreakValue> {
+impl<'ast> EarlyLintPass<'ast> for UnsafeCheatcodes {
+    fn check_expr(&mut self, ctx: &LintContext<'_>, expr: &'ast Expr<'ast>) {
         if let ExprKind::Call(lhs, _args) = &expr.kind
             && let ExprKind::Member(_lhs, member) = &lhs.kind
-            && self.unsafe_cheatcodes.iter().any(|&c| c == member.as_str())
+            && UNSAFE_CHEATCODES.iter().any(|&c| c == member.as_str())
         {
-            self.ctx.emit(&UNSAFE_CHEATCODE_USAGE, member.span);
+            ctx.emit(&UNSAFE_CHEATCODE_USAGE, member.span);
         }
-        self.walk_expr(expr)
     }
 }