chore(lint): use solar's built-in code suggestions (#11919)

Author: 0xrusowsky

crates/forge/tests/cli/lint.rs

@@ -156,7 +156,7 @@ note[mixed-case-function]: function names should use mixedCase
  [FILE]:9:14
   |
 9 |     function functionMIXEDCaseInfo() public {}
-  |              ^^^^^^^^^^^^^^^^^^^^^
+  |              ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `functionMixedCaseInfo`
   |
   = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
 
@@ -214,7 +214,7 @@ note[mixed-case-function]: function names should use mixedCase
  [FILE]:9:14
   |
 9 |     function functionMIXEDCaseInfo() public {}
-  |              ^^^^^^^^^^^^^^^^^^^^^
+  |              ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `functionMixedCaseInfo`
   |
   = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-function
 
@@ -497,7 +497,7 @@ note[mixed-case-variable]: mutable variables should use mixedCase
  [FILE]:6:20
   |
 6 |     uint256 public CounterB_Fail_Lint;
-  |                    ^^^^^^^^^^^^^^^^^^
+  |                    ^^^^^^^^^^^^^^^^^^ help: consider using: `counterBFailLint`
   |
   = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
 
@@ -556,53 +556,113 @@ forgetest!(lint_json_output_no_ansi_escape_codes, |prj, cmd| {
     cmd.arg("lint").arg("--json").assert_json_stderr(true,
         str![[r#"
 {
-  "$message_type": "diagnostic",
-  "message": "wrap modifier logic to reduce code size",
-  "code": {
+    "$message_type": "diagnostic",
+    "message": "wrap modifier logic to reduce code size",
+    "code": {
     "code": "unwrapped-modifier-logic",
     "explanation": null
-  },
-  "level": "note",
-  "spans": [
+    },
+    "level": "note",
+    "spans": [
     {
-      "file_name": "src/UnwrappedModifierTest.sol",
-      "byte_start": 183,
-      "byte_end": 192,
-      "line_start": 8,
-      "line_end": 8,
-      "column_start": 22,
-      "column_end": 31,
-      "is_primary": true,
-      "text": [
+        "file_name": "src/UnwrappedModifierTest.sol",
+        "byte_start": 174,
+        "byte_end": 355,
+        "line_start": 8,
+        "line_end": 12,
+        "column_start": 13,
+        "column_end": 14,
+        "is_primary": true,
+        "text": [
+        {
+            "text": "            modifier onlyOwner() {",
+            "highlight_start": 13,
+            "highlight_end": 35
+        },
+        {
+            "text": "                require(isOwner[msg.sender], \"Not owner\");",
+            "highlight_start": 1,
+            "highlight_end": 59
+        },
+        {
+            "text": "                require(msg.sender != address(0), \"Zero address\");",
+            "highlight_start": 1,
+            "highlight_end": 67
+        },
         {
-          "text": "            modifier onlyOwner() {",
-          "highlight_start": 22,
-          "highlight_end": 31
+            "text": "                _;",
+            "highlight_start": 1,
+            "highlight_end": 19
+        },
+        {
+            "text": "            }",
+            "highlight_start": 1,
+            "highlight_end": 14
         }
-      ],
-      "label": null,
-      "suggested_replacement": null
+        ],
+        "label": null,
+        "suggested_replacement": null
     }
-  ],
-  "children": [
+    ],
+    "children": [
     {
-      "message": "wrap modifier logic to reduce code size\n\n- modifier onlyOwner() {\n-     require(isOwner[msg.sender], \"Not owner\");\n-     require(msg.sender != address(0), \"Zero address\");\n-     _;\n- }\n+ modifier onlyOwner() {\n+     _onlyOwner();\n+     _;\n+ }\n+ \n+ function _onlyOwner() internal {\n+     require(isOwner[msg.sender], \"Not owner\");\n+     require(msg.sender != address(0), \"Zero address\");\n+ }\n\n",
-      "code": null,
-      "level": "note",
-      "spans": [],
-      "children": [],
-      "rendered": null
+        "message": "https://book.getfoundry.sh/reference/forge/forge-lint#unwrapped-modifier-logic",
+        "code": null,
+        "level": "help",
+        "spans": [],
+        "children": [],
+        "rendered": null
     },
     {
-      "message": "https://book.getfoundry.sh/reference/forge/forge-lint#unwrapped-modifier-logic",
-      "code": null,
-      "level": "help",
-      "spans": [],
-      "children": [],
-      "rendered": null
+        "message": "wrap modifier logic to reduce code size",
+        "code": null,
+        "level": "help",
+        "spans": [
+        {
+            "file_name": "src/UnwrappedModifierTest.sol",
+            "byte_start": 174,
+            "byte_end": 355,
+            "line_start": 8,
+            "line_end": 12,
+            "column_start": 13,
+            "column_end": 14,
+            "is_primary": true,
+            "text": [
+            {
+                "text": "            modifier onlyOwner() {",
+                "highlight_start": 13,
+                "highlight_end": 35
+            },
+            {
+                "text": "                require(isOwner[msg.sender], \"Not owner\");",
+                "highlight_start": 1,
+                "highlight_end": 59
+            },
+            {
+                "text": "                require(msg.sender != address(0), \"Zero address\");",
+                "highlight_start": 1,
+                "highlight_end": 67
+            },
+            {
+                "text": "                _;",
+                "highlight_start": 1,
+                "highlight_end": 19
+            },
+            {
+                "text": "            }",
+                "highlight_start": 1,
+                "highlight_end": 14
+            }
+            ],
+            "label": null,
+            "suggested_replacement": "modifier onlyOwner() {\n                _onlyOwner();\n                _;\n            }\n\n            function _onlyOwner() internal {\n                require(isOwner[msg.sender], \"Not owner\");\n                require(msg.sender != address(0), \"Zero address\");\n            }"
+        }
+        ],
+        "children": [],
+        "rendered": null
     }
-  ],
-  "rendered": "note[unwrapped-modifier-logic]: wrap modifier logic to reduce code size\n  |\n8 |             modifier onlyOwner() {\n  |\n  = note: wrap modifier logic to reduce code size\n          \n          - modifier onlyOwner() {\n          -     require(isOwner[msg.sender], \"Not owner\");\n          -     require(msg.sender != address(0), \"Zero address\");\n          -     _;\n          - }\n          + modifier onlyOwner() {\n          +     _onlyOwner();\n          +     _;\n          + }\n          + \n          + function _onlyOwner() internal {\n          +     require(isOwner[msg.sender], \"Not owner\");\n          +     require(msg.sender != address(0), \"Zero address\");\n          + }\n          \n  = help: https://book.getfoundry.sh/reference/forge/forge-lint#unwrapped-modifier-logic\n\n --> [..]\n  |                      ^^^^^^^^^\n          \n"
+    ],
+    "rendered": "note[unwrapped-modifier-logic]: wrap modifier logic to reduce code size\n\n  --> src/UnwrappedModifierTest.sol:8:13\n   |\n 8 | /             modifier onlyOwner() {\n 9 | |                 require(isOwner[msg.sender], \"Not owner\");\n10 | |                 require(msg.sender != address(0), \"Zero address\");\n11 | |                 _;\n12 | |             }\n   | |_____________^\n   |\nhelp: wrap modifier logic to reduce code size\n   |\n 8 ~             modifier onlyOwner() {\n 9 +                 _onlyOwner();\n10 +                 _;\n11 +             }\n12 + \n13 +             function _onlyOwner() internal {\n14 +                 require(isOwner[msg.sender], \"Not owner\");\n15 +                 require(msg.sender != address(0), \"Zero address\");\n16 +             }\n   |\n   = help: https://book.getfoundry.sh/reference/forge/forge-lint#unwrapped-modifier-logic\n"
 }
 "#]],
 );