fix: propagate color config to TraceWriter (#9679)

Author: DaniPopes

Cargo.lock

@@ -18,6 +18,11 @@ use std::{
     },
 };
 
+/// Returns the current color choice.
+pub fn color_choice() -> ColorChoice {
+    Shell::get().color_choice()
+}
+
 /// Returns the currently set verbosity level.
 pub fn verbosity() -> Verbosity {
     Shell::get().verbosity()

crates/common/src/io/shell.rs

@@ -201,12 +201,22 @@ pub fn render_trace_arena_inner(
     }
 
     let mut w = TraceWriter::new(Vec::<u8>::new())
+        .color_cheatcodes(true)
+        .use_colors(convert_color_choice(shell::color_choice()))
         .write_bytecodes(with_bytecodes)
         .with_storage_changes(with_storage_changes);
     w.write_arena(&arena.resolve_arena()).expect("Failed to write traces");
     String::from_utf8(w.into_writer()).expect("trace writer wrote invalid UTF-8")
 }
 
+fn convert_color_choice(choice: shell::ColorChoice) -> revm_inspectors::ColorChoice {
+    match choice {
+        shell::ColorChoice::Auto => revm_inspectors::ColorChoice::Auto,
+        shell::ColorChoice::Always => revm_inspectors::ColorChoice::Always,
+        shell::ColorChoice::Never => revm_inspectors::ColorChoice::Never,
+    }
+}
+
 /// Specifies the kind of trace.
 #[derive(Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub enum TraceKind {

crates/evm/traces/src/lib.rs

@@ -2829,3 +2829,10 @@ forgetest!(test_fail_deprecation_warning, |prj, cmd| {
         .stderr_eq(r#"Warning: `testFail*` has been deprecated and will be removed in the next release. Consider changing to test_Revert[If|When]_Condition and expecting a revert. Found deprecated testFail* function(s): testFail_deprecated, testFail_deprecated2.
 "#);
 });
+
+#[cfg(not(feature = "isolate-by-default"))]
+forgetest_init!(colored_traces, |prj, cmd| {
+    cmd.args(["test", "--mt", "test_Increment", "--color", "always", "-vvvvv"])
+        .assert_success()
+        .stdout_eq(file!["../fixtures/colored_traces.svg": TermSvg]);
+});

crates/forge/tests/cli/test_cmd.rs

@@ -30,7 +30,7 @@ serde_json.workspace = true
 tracing.workspace = true
 tracing-subscriber = { workspace = true, features = ["env-filter"] }
 rand.workspace = true
-snapbox = { version = "0.6", features = ["json", "regex"] }
+snapbox = { version = "0.6", features = ["json", "regex", "term-svg"] }
 tempfile.workspace = true
 
 [dev-dependencies]