perf: lazy cheatcodes SignaturesIdentifier, save only if online (#11708)

Author: DaniPopes

crates/cheatcodes/src/inspector.rs

@@ -72,7 +72,7 @@ use std::{
     io::BufReader,
     ops::Range,
     path::PathBuf,
-    sync::Arc,
+    sync::{Arc, OnceLock},
 };
 
 mod utils;
@@ -498,7 +498,7 @@ pub struct Cheatcodes {
     /// Unlocked wallets used in scripts and testing of scripts.
     pub wallets: Option<Wallets>,
     /// Signatures identifier for decoding events and functions
-    pub signatures_identifier: Option<SignaturesIdentifier>,
+    signatures_identifier: OnceLock<Option<SignaturesIdentifier>>,
     /// Used to determine whether the broadcasted call has non-fixed gas limit.
     /// Holds values for (seen opcode GAS, seen opcode CALL) pair.
     /// If GAS opcode is followed by CALL opcode then both flags are marked true and call
@@ -558,7 +558,7 @@ impl Cheatcodes {
             arbitrary_storage: Default::default(),
             deprecated: Default::default(),
             wallets: Default::default(),
-            signatures_identifier: SignaturesIdentifier::new(true).ok(),
+            signatures_identifier: Default::default(),
             dynamic_gas_limit_sequence: Default::default(),
         }
     }
@@ -585,6 +585,11 @@ impl Cheatcodes {
         self.active_delegations.push(authorization);
     }
 
+    /// Returns the signatures identifier.
+    pub fn signatures_identifier(&self) -> Option<&SignaturesIdentifier> {
+        self.signatures_identifier.get_or_init(|| SignaturesIdentifier::new(true).ok()).as_ref()
+    }
+
     /// Decodes the input data and applies the cheatcode.
     fn apply_cheatcode(
         &mut self,

crates/cheatcodes/src/test/expect.rs

@@ -898,7 +898,7 @@ pub(crate) fn handle_expect_emit(
 
             // Try to decode the events if we have a signature identifier
             let (expected_decoded, actual_decoded) = if let Some(signatures_identifier) =
-                &state.signatures_identifier
+                state.signatures_identifier()
                 && !event_to_fill_or_check.anonymous
             {
                 (

crates/evm/traces/src/identifier/signatures.rs

@@ -274,7 +274,10 @@ impl SignaturesIdentifier {
 
 impl SignaturesIdentifierInner {
     fn save(&self) {
-        if let Some(path) = &self.cache_path {
+        // We only identify new signatures if the client is enabled.
+        if let Some(path) = &self.cache_path
+            && self.client.is_some()
+        {
             self.cache
                 .try_read()
                 .expect("SignaturesIdentifier cache is locked while attempting to save")