fix(lint): lint only files that we build (#11247)

Author: grandizzy

crates/forge/src/cmd/build.rs

@@ -112,19 +112,16 @@ impl BuildArgs {
             sh_println!("{}", serde_json::to_string_pretty(&output.output())?)?;
         }
 
-        if !config.lint.lint_on_build {
-            return Ok(output);
-        }
-
-        // Only run the `SolidityLinter` if there are no compilation errors
-        if !output.output().errors.iter().any(|e| e.is_error()) {
-            self.lint(&project, &config).map_err(|err| eyre!("Lint failed: {err}"))?;
+        // Only run the `SolidityLinter` if lint on build and no compilation errors.
+        if config.lint.lint_on_build && !output.output().errors.iter().any(|e| e.is_error()) {
+            self.lint(&project, &config, self.paths.as_deref())
+                .map_err(|err| eyre!("Lint failed: {err}"))?;
         }
 
         Ok(output)
     }
 
-    fn lint(&self, project: &Project, config: &Config) -> Result<()> {
+    fn lint(&self, project: &Project, config: &Config, files: Option<&[PathBuf]>) -> Result<()> {
         let format_json = shell::is_json();
         if project.compiler.solc.is_some() && !shell::is_quiet() {
             let linter = SolidityLinter::new(config.project_paths())
@@ -160,6 +157,10 @@ impl BuildArgs {
                 .project_paths::<SolcLanguage>()
                 .input_files_iter()
                 .filter(|p| {
+                    // Lint only specified build files, if any.
+                    if let Some(files) = files {
+                        return files.iter().any(|file| &curr_dir.join(file) == p);
+                    }
                     skip.is_match(p)
                         && !(ignored.contains(p) || ignored.contains(&curr_dir.join(p)))
                 })

crates/forge/tests/cli/lint.rs

@@ -48,6 +48,24 @@ const ONLY_IMPORTS: &str = r#"
     import "./ContractWithLints.sol";
         "#;
 
+const COUNTER_A: &str = r#"
+    // SPDX-License-Identifier: MIT
+    pragma solidity ^0.8.0;
+
+    contract CounterA {
+        uint256 public CounterA_Fail_Lint;
+    }
+        "#;
+
+const COUNTER_B: &str = r#"
+    // SPDX-License-Identifier: MIT
+    pragma solidity ^0.8.0;
+
+    contract CounterB {
+        uint256 public CounterB_Fail_Lint;
+    }
+        "#;
+
 forgetest!(can_use_config, |prj, cmd| {
     prj.wipe_contracts();
     prj.add_source("ContractWithLints", CONTRACT).unwrap();
@@ -388,6 +406,48 @@ note[unused-import]: unused imports should be removed
 "#]]);
 });
 
+// <https://github.com/foundry-rs/foundry/issues/11234>
+forgetest!(can_lint_only_built_files, |prj, cmd| {
+    prj.wipe_contracts();
+    prj.add_source("CounterAWithLints", COUNTER_A).unwrap();
+    prj.add_source("CounterBWithLints", COUNTER_B).unwrap();
+
+    // Both contracts should be linted on build.
+    cmd.forge_fuse().args(["build"]).assert_success().stderr_eq(str![[r#"
+note[mixed-case-variable]: mutable variables should use mixedCase
+ [FILE]:6:24
+  |
+6 |         uint256 public CounterA_Fail_Lint;
+  |                        ------------------
+  |
+  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
+
+note[mixed-case-variable]: mutable variables should use mixedCase
+ [FILE]:6:24
+  |
+6 |         uint256 public CounterB_Fail_Lint;
+  |                        ------------------
+  |
+  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
+
+
+"#]]);
+    // Only contract CounterBWithLints that we build should be linted.
+    cmd.forge_fuse().args(["build", "src/CounterBWithLints.sol"]).assert_success().stderr_eq(str![
+        [r#"
+note[mixed-case-variable]: mutable variables should use mixedCase
+ [FILE]:6:24
+  |
+6 |         uint256 public CounterB_Fail_Lint;
+  |                        ------------------
+  |
+  = help: https://book.getfoundry.sh/reference/forge/forge-lint#mixed-case-variable
+
+
+"#]
+    ]);
+});
+
 // ------------------------------------------------------------------------------------------------
 
 #[tokio::test]