Skip to content

Commit f182a95

Browse files
authored
chore: aggregate PRs (#11597)
This PR aggregates changes from the following PRs: - Closes #11572 by @\Forostovec - Closes #11589 by @\sashass1315 - Closes #11592 by @\sashaodessa - Closes #11595 by @\eeemmmmmm
1 parent cff3dec commit f182a95

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

crates/cast/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -749,7 +749,7 @@ impl<P: Provider<AnyNetwork>> Cast<P> {
749749
pub async fn codesize(&self, who: Address, block: Option<BlockId>) -> Result<String> {
750750
let code =
751751
self.provider.get_code_at(who).block_id(block.unwrap_or_default()).await?.to_vec();
752-
Ok(format!("{}", code.len()))
752+
Ok(code.len().to_string())
753753
}
754754

755755
/// # Example

crates/common/src/provider/runtime_transport.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
//! Runtime transport that connects on first request, which can take either of an HTTP,
2-
//! WebSocket, or IPC transport and supports retries based on CUPS logic.
2+
//! WebSocket, or IPC transport. Retries are handled by a client layer (e.g.,
3+
//! `RetryBackoffLayer`) when used.
34
45
use crate::{DEFAULT_USER_AGENT, REQUEST_TIMEOUT};
56
use alloy_json_rpc::{RequestPacket, ResponsePacket};
@@ -67,7 +68,8 @@ pub enum RuntimeTransportError {
6768
/// A runtime transport is a custom [`alloy_transport::Transport`] that only connects when the
6869
/// *first* request is made. When the first request is made, it will connect to the runtime using
6970
/// either an HTTP WebSocket, or IPC transport depending on the URL used.
70-
/// It also supports retries for rate-limiting and timeout-related errors.
71+
/// Retries for rate-limiting and timeout-related errors are handled by an external
72+
/// client layer (e.g., `RetryBackoffLayer`) when configured.
7173
#[derive(Clone, Debug, Error)]
7274
pub struct RuntimeTransport {
7375
/// The inner actual transport used.
@@ -239,8 +241,8 @@ impl RuntimeTransport {
239241

240242
/// Sends a request using the underlying transport.
241243
/// If this is the first request, it will connect to the appropriate transport depending on the
242-
/// URL scheme. When sending the request, retries will be automatically handled depending
243-
/// on the parameters set on the [RuntimeTransport].
244+
/// URL scheme. Retries are performed by an external client layer (e.g., `RetryBackoffLayer`),
245+
/// if such a layer is configured by the caller.
244246
/// For sending the actual request, this action is delegated down to the
245247
/// underlying transport through Tower's [tower::Service::call]. See tower's [tower::Service]
246248
/// trait for more information.

crates/doc/src/preprocessor/infer_hyperlinks.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ impl<'a> InlineLink<'a> {
236236
}
237237

238238
fn captures(s: &'a str) -> impl Iterator<Item = Self> + 'a {
239-
RE_INLINE_LINK.captures(s).map(Self::from_capture).into_iter().flatten()
239+
RE_INLINE_LINK.captures_iter(s).filter_map(Self::from_capture)
240240
}
241241

242242
/// Parses the first inline link.

foundryup/install

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ if [[ ":$PATH:" != *":${FOUNDRY_BIN_DIR}:"* ]]; then
4747
# Add the foundryup directory to the path and ensure the old PATH variables remain.
4848
# If the shell is fish, echo fish_add_path instead of export.
4949
if [[ "$PREF_SHELL" == "fish" ]]; then
50-
echo >> "$PROFILE" && echo "fish_add_path -a $FOUNDRY_BIN_DIR" >> "$PROFILE"
50+
echo >> "$PROFILE" && echo "fish_add_path -a \"$FOUNDRY_BIN_DIR\"" >> "$PROFILE"
5151
else
5252
echo >> "$PROFILE" && echo "export PATH=\"\$PATH:$FOUNDRY_BIN_DIR\"" >> "$PROFILE"
5353
fi

0 commit comments

Comments
 (0)