expected vs actual

[wminshew]

as I was reading through the rust book this weekend, I thought it was interesting their assertEq! macros use left == right instead of the actual == expected forge uses. As I was recently using forge on my first project (https://github.com/0xSplits/splits-vesting), this nomenclature was actually something I found quite annoying -- having to figure out & remember which slot was expected & which was actual. I imagine this was inherited from dapptools so I think it's worth asking: is this pattern worth preserving? Left == right is, imo, immediately grokkable in a way that expected == actual isn't. At the very least if we keep expected & actual, should maybe update the first log to show actual == expected so people know they're reversed in the following logs (e.g. shows b then a, not a then b)

---- tests::it_adds_two stdout ----
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `4`,
 right: `5`', src/lib.rs:11:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

source: https://doc.rust-lang.org/book/ch11-01-writing-tests.html

vs

foundry/testdata/lib/ds-test/src/test.sol

Lines 74 to 76 in 3f13a98

	emit log("Error: a == b not satisfied [address]");
	emit log_named_address(" Expected", b);
	emit log_named_address(" Actual", a);

[wminshew]

very grateful to see this in my tests now 🙏