fix(cast): calldata-decode --json nested tuple formatting #11212

minhd-vu · 2025-08-05T17:55:59Z

Motivation

addresses improve cdd json parsing #9928
nested tuples with the --json flag were just being treated as strings

cargo run cdd --json 'sequenceBatchesValidium((bytes32,bytes32,uint64,bytes32)[],uint64,uint64,address,bytes)' 0xdb5b0ed700000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000000006772bf190000000000000000000000000000000000000000000000000000000000020716000000000000000000000000af9d27ffe4d51ed54ac8eec78f2785d7e11e5ab100000000000000000000000000000000000000000000000000000000000002c0000000000000000000000000000000000000000000000000000000000000000404366a6dc4b2f348a85e0066e46f0cc206fca6512e0ed7f17ca7afb88e9a4c27000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000093922dee6e380c28a50c008ab167b7800bb24c2026cd1b22f1c6fb884ceed7400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000060f85e59ecad6c1a6be343a945abedb7d5b5bfad7817c4d8cc668da7d391faf700000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000093dfbf04395fbec1f1aed4ad0f9d3ba880ff58a60485df5d33f8f5e0fb73188600000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000aa334a426ea9e21d5f84eb2d4723ca56b92382b9260ab2b6769b7c23d437b6b512322a25cecc954127e60cf91ef056ac1da25f90b73be81c3ff1872fa48d10c7ef1ccb4087bbeedb54b1417a24abbb76f6cd57010a65bb03c7b6602b1eaf0e32c67c54168232d4edc0bfa1b815b2af2a2d0a5c109d675a4f2de684e51df9abb324ab1b19a81bac80f9ce3a45095f3df3a7cf69ef18fc08e94ac3cbc1c7effeacca68e3bfe5d81e26a659b500000000000000000000000000000000000000000000

[
  "[(0x04366a6dc4b2f348a85e0066e46f0cc206fca6512e0ed7f17ca7afb88e9a4c27, 0x0000000000000000000000000000000000000000000000000000000000000000, 0, 0x0000000000000000000000000000000000000000000000000000000000000000), (0x093922dee6e380c28a50c008ab167b7800bb24c2026cd1b22f1c6fb884ceed74, 0x0000000000000000000000000000000000000000000000000000000000000000, 0, 0x0000000000000000000000000000000000000000000000000000000000000000), (0x60f85e59ecad6c1a6be343a945abedb7d5b5bfad7817c4d8cc668da7d391faf7, 0x0000000000000000000000000000000000000000000000000000000000000000, 0, 0x0000000000000000000000000000000000000000000000000000000000000000), (0x93dfbf04395fbec1f1aed4ad0f9d3ba880ff58a60485df5d33f8f5e0fb731886, 0x0000000000000000000000000000000000000000000000000000000000000000, 0, 0x0000000000000000000000000000000000000000000000000000000000000000)]",
  "1735573273",
  "132886",
  "0xAF9d27ffe4d51eD54AC8eEc78f2785D7E11E5ab1",
  "0x334a426ea9e21d5f84eb2d4723ca56b92382b9260ab2b6769b7c23d437b6b512322a25cecc954127e60cf91ef056ac1da25f90b73be81c3ff1872fa48d10c7ef1ccb4087bbeedb54b1417a24abbb76f6cd57010a65bb03c7b6602b1eaf0e32c67c54168232d4edc0bfa1b815b2af2a2d0a5c109d675a4f2de684e51df9abb324ab1b19a81bac80f9ce3a45095f3df3a7cf69ef18fc08e94ac3cbc1c7effeacca68e3bfe5d81e26a659b5"
]

Solution

correctly parse nested tuples with token_to_json

[
  [
    [
      "0x04366a6dc4b2f348a85e0066e46f0cc206fca6512e0ed7f17ca7afb88e9a4c27",
      "0x0000000000000000000000000000000000000000000000000000000000000000",
      "0",
      "0x0000000000000000000000000000000000000000000000000000000000000000"
    ],
    [
      "0x093922dee6e380c28a50c008ab167b7800bb24c2026cd1b22f1c6fb884ceed74",
      "0x0000000000000000000000000000000000000000000000000000000000000000",
      "0",
      "0x0000000000000000000000000000000000000000000000000000000000000000"
    ],
    [
      "0x60f85e59ecad6c1a6be343a945abedb7d5b5bfad7817c4d8cc668da7d391faf7",
      "0x0000000000000000000000000000000000000000000000000000000000000000",
      "0",
      "0x0000000000000000000000000000000000000000000000000000000000000000"
    ],
    [
      "0x93dfbf04395fbec1f1aed4ad0f9d3ba880ff58a60485df5d33f8f5e0fb731886",
      "0x0000000000000000000000000000000000000000000000000000000000000000",
      "0",
      "0x0000000000000000000000000000000000000000000000000000000000000000"
    ]
  ],
  "1735573273",
  "132886",
  "0xAF9d27ffe4d51eD54AC8eEc78f2785D7E11E5ab1",
  "0x334a426ea9e21d5f84eb2d4723ca56b92382b9260ab2b6769b7c23d437b6b512322a25cecc954127e60cf91ef056ac1da25f90b73be81c3ff1872fa48d10c7ef1ccb4087bbeedb54b1417a24abbb76f6cd57010a65bb03c7b6602b1eaf0e32c67c54168232d4edc0bfa1b815b2af2a2d0a5c109d675a4f2de684e51df9abb324ab1b19a81bac80f9ce3a45095f3df3a7cf69ef18fc08e94ac3cbc1c7effeacca68e3bfe5d81e26a659b5"
]

PR Checklist

Added Tests
Added Documentation
Breaking changes

minhd-vu · 2025-08-11T14:03:15Z

@DaniPopes could you review this when you get the chance 😄. I tried my best to implement your suggestion from this PR #9928.

crates/common/fmt/src/dynamic.rs

zerosnacks · 2025-08-18T14:15:36Z

Makes sense! Thanks for your PR - small nit

zerosnacks

lgtm! pending other reviewers

crates/common/fmt/src/dynamic.rs

0xrusowsky

LGTM, let's way for more reviews?

DaniPopes

LGTM, thanks!

fix(cast): calldata-decode --json nested tuple formatting

5c0c9a0

github-project-automation bot added this to Foundry Aug 5, 2025

minhd-vu added 6 commits August 5, 2025 13:57

fix: clippy

fd815cd

fix: remove redundant branches

445fcba

fix: idomatic

27e922f

chore: calldata_decode_array test

5d6f0ce

fix: rename test

bb635b5

Merge branch 'master' into cdd-json-tuples

4c8e8f4

minhd-vu marked this pull request as ready for review August 5, 2025 18:29

minhd-vu requested review from DaniPopes, klkvr, mattsse, grandizzy, yash-atreya and zerosnacks as code owners August 5, 2025 18:29

minhd-vu added 2 commits August 7, 2025 10:00

Merge branch 'master' into cdd-json-tuples

2dc9a56

Merge branch 'master' into cdd-json-tuples

0efcb7e

minhd-vu added 2 commits August 15, 2025 11:49

Merge branch 'master' into cdd-json-tuples

4ddc06c

Merge branch 'master' into cdd-json-tuples

12f6fd7

zerosnacks reviewed Aug 18, 2025

View reviewed changes

crates/common/fmt/src/dynamic.rs Outdated Show resolved Hide resolved

minhd-vu added 2 commits August 18, 2025 10:32

fix: avoid pulling in scope

790be3b

Merge branch 'master' into cdd-json-tuples

9297acc

minhd-vu requested review from onbjerg and 0xrusowsky as code owners August 19, 2025 14:05

zerosnacks previously approved these changes Aug 19, 2025

View reviewed changes

0xrusowsky reviewed Aug 19, 2025

View reviewed changes

crates/common/fmt/src/dynamic.rs Outdated Show resolved Hide resolved

zerosnacks mentioned this pull request Aug 19, 2025

improve cdd json parsing #9928

Closed

3 tasks

minhd-vu added 4 commits August 19, 2025 12:38

feat: move serialize_value_as_json to common

2b8677b

Merge branch 'master' into cdd-json-tuples

7d2ec01

docs: update doc comment

e869b27

Merge branch 'master' into cdd-json-tuples

79349ac

0xrusowsky approved these changes Aug 19, 2025

View reviewed changes

Merge branch 'master' into cdd-json-tuples

43bf347

DaniPopes approved these changes Aug 21, 2025

View reviewed changes

DaniPopes enabled auto-merge (squash) August 21, 2025 14:08

DaniPopes merged commit a966fba into foundry-rs:master Aug 21, 2025
22 checks passed

github-project-automation bot moved this to Done in Foundry Aug 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(cast): calldata-decode --json nested tuple formatting #11212

fix(cast): calldata-decode --json nested tuple formatting #11212

Uh oh!

minhd-vu commented Aug 5, 2025 •

edited

Loading

Uh oh!

minhd-vu commented Aug 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

zerosnacks commented Aug 18, 2025

Uh oh!

zerosnacks left a comment

Uh oh!

Uh oh!

0xrusowsky left a comment •

edited

Loading

Uh oh!

DaniPopes left a comment

Uh oh!

Uh oh!

Uh oh!

fix(cast): calldata-decode --json nested tuple formatting #11212

fix(cast): calldata-decode --json nested tuple formatting #11212

Uh oh!

Conversation

minhd-vu commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Solution

PR Checklist

Uh oh!

minhd-vu commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

zerosnacks commented Aug 18, 2025

Uh oh!

zerosnacks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0xrusowsky left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DaniPopes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

minhd-vu commented Aug 5, 2025 •

edited

Loading

minhd-vu commented Aug 11, 2025 •

edited

Loading

0xrusowsky left a comment •

edited

Loading