feat(forge-selectors-list): add --no-group option #11270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xferrous
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
onbjerg
requested changes
Aug 25, 2025
There was a problem hiding this comment.
Hi, thanks for opening this PR!
The current implementation seems to show duplicate selectors, i.e. if I have two contracts with a function named transfer that has the exact same signature, transfer would show up twice. Let's make sure we deduplicate selectors if --no-group is passed.
Apologies for the delay.
onbjerg
added
Cmd-forge-selectors
|
I think showing duplicates might be desirable when the intent is to grep on the output and find contracts that implement a specific method. We'd also have to decide in the deduplication case what value do we show for contract name column? Should I deduplicate the rows, but fold the contract names so that it shows something like |
onbjerg
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently
forge selectors listshows one table of selectors per contract and that is fine. But the output is not greppable because if I wanted to see which contract had a particular selector, the contract name would be appearing before the table is printed.Solution
--no-groupoption only prints one table and adds acontractfield to each row which makes it greppable. And since it is a new option, the current behavior stays the same for everyone.PR Checklist