chore(test): add hints after test failed #11995
Open
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvekkk
requested review from
DaniPopes,
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
onbjerg
requested changes
Oct 6, 2025
Thanks! only new version ⬇️ |
onbjerg
requested changes
Oct 7, 2025
Co-authored-by: onbjerg <[email protected]>
Hi @onbjerg, I've updated all the test snapshots to include the tip message. Could you please help re-trigger the CI? Latest run was 1635/1636 - flaky tests passed on retry, the one failure seems to be an unrelated cast issue, but let me know if I missed something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During optimized #11993, I just realized there are much more magic function to help the test, but for the lazy people who don't like to read the whole docs like me, its really hard to know this, we just wait for all the test pass 😓. These hints may give alot help.