Skip to content

Conversation

@zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Nov 29, 2024

Motivation

Follow-up for #9430, can be merged before or after

Use the alloy-chains is_arbitrum built-in

Solution

Follow-up for https://github.com/foundry-rs/foundry/pull/9430/files#diff-a0d1dbafd7eaf82b3fd4d30722d2c7e369394883a704e8b41554d0a31b43629f to use is_arbitrum consistently

@zerosnacks zerosnacks marked this pull request as ready for review November 29, 2024 09:46
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zerosnacks zerosnacks merged commit fbbcc8c into master Nov 29, 2024
21 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/add_is_arbitrum_exception branch November 29, 2024 10:15
@zerosnacks zerosnacks self-assigned this Nov 29, 2024
rplusq pushed a commit to rplusq/foundry that referenced this pull request Nov 29, 2024
* use alloy-chains' is_arbitrum

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

3 participants