Skip to content

Commit 0befda5

Browse files
committed
Change declare arguments
commit-id:e1eef354
1 parent a9d6933 commit 0befda5

File tree

3 files changed

+14
-16
lines changed

3 files changed

+14
-16
lines changed

crates/sncast/src/main.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,9 @@ async fn run_async_command(cli: Cli, config: CastConfig, ui: &UI) -> Result<()>
291291
.expect("Failed to build contract");
292292

293293
let result = starknet_commands::declare::declare(
294-
declare,
294+
declare.contract,
295+
declare.fee_args,
296+
declare.nonce,
295297
&account,
296298
&artifacts,
297299
wait_config,

crates/sncast/src/starknet_commands/declare.rs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,11 @@ pub struct Declare {
4949
pub rpc: RpcArgs,
5050
}
5151

52+
#[expect(clippy::too_many_arguments)]
5253
pub async fn declare(
53-
declare: Declare,
54+
contract: String,
55+
fee_args: FeeArgs,
56+
nonce: Option<Felt>,
5457
account: &SingleOwnerAccount<&JsonRpcClient<HttpTransport>, LocalWallet>,
5558
artifacts: &HashMap<String, StarknetContractArtifacts>,
5659
wait_config: WaitForTx,
@@ -59,9 +62,9 @@ pub async fn declare(
5962
) -> Result<DeclareResponse, StarknetCommandError> {
6063
let contract_artifacts =
6164
artifacts
62-
.get(&declare.contract)
65+
.get(&contract)
6366
.ok_or(StarknetCommandError::ContractArtifactsNotFound(ErrorData {
64-
data: ByteArray::from(declare.contract.as_str()),
67+
data: ByteArray::from(contract.as_str()),
6568
}))?;
6669

6770
let contract_definition: SierraClass = serde_json::from_str(&contract_artifacts.sierra)
@@ -72,8 +75,8 @@ pub async fn declare(
7275
declare_with_artifacts(
7376
contract_definition,
7477
casm_contract_definition,
75-
declare.fee_args,
76-
declare.nonce,
78+
fee_args,
79+
nonce,
7780
account,
7881
wait_config,
7982
skip_on_already_declared,

crates/sncast/src/starknet_commands/script/run.rs

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
use crate::starknet_commands::declare::Declare;
21
use crate::starknet_commands::{call, declare, deploy, invoke, tx_status};
32
use crate::{WaitForTx, get_account};
43
use anyhow::{Context, Result, anyhow};
@@ -127,14 +126,6 @@ impl<'a> ExtensionLogic for CastScriptExtension<'a> {
127126
let fee_args: FeeArgs = input_reader.read::<ScriptFeeSettings>()?.into();
128127
let nonce = input_reader.read()?;
129128

130-
let declare = Declare {
131-
contract: contract.clone(),
132-
fee_args,
133-
nonce,
134-
package: None,
135-
rpc: RpcArgs::default(),
136-
};
137-
138129
let declare_tx_id = generate_declare_tx_id(contract.as_str());
139130

140131
if let Some(success_output) =
@@ -144,7 +135,9 @@ impl<'a> ExtensionLogic for CastScriptExtension<'a> {
144135
}
145136

146137
let declare_result = self.tokio_runtime.block_on(declare::declare(
147-
declare,
138+
contract.clone(),
139+
fee_args,
140+
nonce,
148141
self.account()?,
149142
self.artifacts,
150143
WaitForTx {

0 commit comments

Comments
 (0)