Skip to content

Commit 78eda65

Browse files
committed
Revert "Add events summary and signature lengths to trace file (#3645)"
This reverts commit 9f03c43.
1 parent 548f88a commit 78eda65

File tree

5 files changed

+10
-48
lines changed

5 files changed

+10
-48
lines changed

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ cairo-lang-starknet-classes = "2.12.0"
4545
cairo-lang-parser = "2.12.0"
4646
cairo-lang-sierra-to-casm = "2.12.0"
4747
cairo-vm = "2.2.0"
48-
cairo-annotations = "0.5.1"
48+
cairo-annotations = "=0.5.0"
4949
dirs = "6.0.0"
5050
dialoguer = "0.11.0"
5151
starknet-types-core = { version = "0.1.7", features = ["hash", "prime-bigint"] }

crates/cheatnet/src/runtime_extensions/call_to_blockifier_runtime_extension/execution/entry_point.rs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ pub fn execute_call_entry_point(
7777
// We skip recursion depth validation here.
7878
cheatnet_state
7979
.trace_data
80-
.enter_nested_call(entry_point.clone(), cheated_data.clone());
80+
.enter_nested_call(entry_point.clone(), cheated_data);
8181

8282
if let Some(cheat_status) = get_mocked_function_cheat_status(entry_point, cheatnet_state)
8383
&& let CheatStatus::Cheated(ret_data, _) = (*cheat_status).clone()
@@ -94,8 +94,6 @@ pub fn execute_call_entry_point(
9494
},
9595
&[],
9696
None,
97-
vec![],
98-
vec![],
9997
);
10098
let tracked_resource = *context
10199
.tracked_resource_stack
@@ -201,7 +199,6 @@ pub fn execute_call_entry_point(
201199
context,
202200
cheatnet_state,
203201
vm_trace,
204-
cheated_data.tx_info.signature.unwrap_or_default(),
205202
);
206203
Ok(call_info)
207204
}
@@ -305,7 +302,6 @@ fn remove_syscall_resources_and_exit_non_error_call(
305302
context: &mut EntryPointExecutionContext,
306303
cheatnet_state: &mut CheatnetState,
307304
vm_trace: Option<Vec<RelocatedTraceEntry>>,
308-
signature: Vec<Felt>,
309305
) {
310306
let versioned_constants = context.tx_context.block_context.versioned_constants();
311307
// We don't want the syscall resources to pollute the results
@@ -345,8 +341,6 @@ fn remove_syscall_resources_and_exit_non_error_call(
345341
CallResult::from_non_error(call_info),
346342
&call_info.execution.l2_to_l1_messages,
347343
vm_trace,
348-
signature,
349-
call_info.execution.events.clone(),
350344
);
351345
}
352346

@@ -368,8 +362,6 @@ fn exit_error_call(
368362
CallResult::from_err(error, &identifier),
369363
&[],
370364
vm_trace,
371-
vec![],
372-
vec![],
373365
);
374366
}
375367

crates/cheatnet/src/state.rs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ use crate::runtime_extensions::forge_runtime_extension::cheatcodes::cheat_execut
1010
};
1111
use crate::runtime_extensions::forge_runtime_extension::cheatcodes::spy_events::Event;
1212
use crate::runtime_extensions::forge_runtime_extension::cheatcodes::spy_messages_to_l1::MessageToL1;
13-
use blockifier::execution::call_info::{OrderedEvent, OrderedL2ToL1Message};
13+
use blockifier::execution::call_info::OrderedL2ToL1Message;
1414
use blockifier::execution::contract_class::RunnableCompiledClass;
1515
use blockifier::execution::entry_point::CallEntryPoint;
1616
use blockifier::execution::syscalls::vm_syscall_utils::SyscallUsageMap;
@@ -219,8 +219,6 @@ pub struct CallTrace {
219219
pub used_syscalls_sierra_gas: SyscallUsageMap,
220220
pub vm_trace: Option<Vec<RelocatedTraceEntry>>,
221221
pub gas_consumed: u64,
222-
pub events: Vec<OrderedEvent>,
223-
pub signature: Vec<Felt>,
224222
}
225223

226224
impl CairoSerialize for CallTrace {
@@ -251,8 +249,6 @@ impl CallTrace {
251249
result: CallResult::Success { ret_data: vec![] },
252250
vm_trace: None,
253251
gas_consumed: u64::default(),
254-
events: vec![],
255-
signature: vec![],
256252
}
257253
}
258254

@@ -567,8 +563,6 @@ impl TraceData {
567563
result: CallResult,
568564
l2_to_l1_messages: &[OrderedL2ToL1Message],
569565
vm_trace: Option<Vec<RelocatedTraceEntry>>,
570-
signature: Vec<Felt>,
571-
events: Vec<OrderedEvent>,
572566
) {
573567
let CallStackElement {
574568
call_trace: last_call,
@@ -588,8 +582,6 @@ impl TraceData {
588582

589583
last_call.result = result;
590584
last_call.vm_trace = vm_trace;
591-
last_call.signature = signature;
592-
last_call.events = events;
593585
}
594586

595587
pub fn add_deploy_without_constructor_node(&mut self) {

crates/forge-runner/src/build_trace_data.rs

Lines changed: 5 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,15 @@ use blockifier::execution::syscalls::vm_syscall_utils::{
55
SyscallSelector, SyscallUsage, SyscallUsageMap,
66
};
77

8-
use blockifier::execution::call_info::OrderedEvent;
98
use cairo_annotations::trace_data::{
109
CairoExecutionInfo, CallEntryPoint as ProfilerCallEntryPoint,
1110
CallTraceNode as ProfilerCallTraceNode, CallTraceV1 as ProfilerCallTrace,
1211
CallType as ProfilerCallType, CasmLevelInfo, ContractAddress,
1312
DeprecatedSyscallSelector as ProfilerDeprecatedSyscallSelector,
1413
EntryPointSelector as ProfilerEntryPointSelector, EntryPointType as ProfilerEntryPointType,
15-
ExecutionResources as ProfilerExecutionResources, SummedUpEvent,
16-
SyscallUsage as ProfilerSyscallUsage, TraceEntry as ProfilerTraceEntry,
17-
VersionedCallTrace as VersionedProfilerCallTrace, VmExecutionResources,
14+
ExecutionResources as ProfilerExecutionResources, SyscallUsage as ProfilerSyscallUsage,
15+
TraceEntry as ProfilerTraceEntry, VersionedCallTrace as VersionedProfilerCallTrace,
16+
VmExecutionResources,
1817
};
1918
use cairo_vm::vm::runners::cairo_runner::ExecutionResources;
2019
use cairo_vm::vm::trace::trace_entry::RelocatedTraceEntry;
@@ -28,7 +27,6 @@ use runtime::starknet::constants::{TEST_CONTRACT_CLASS_HASH, TEST_ENTRY_POINT_SE
2827
use starknet::core::utils::get_selector_from_name;
2928
use starknet_api::contract_class::EntryPointType;
3029
use starknet_api::core::{ClassHash, EntryPointSelector};
31-
use starknet_types_core::felt::Felt;
3230
use std::cell::RefCell;
3331
use std::fs;
3432
use std::path::PathBuf;
@@ -47,13 +45,8 @@ pub fn build_profiler_call_trace(
4745
) -> ProfilerCallTrace {
4846
let value = value.borrow();
4947

50-
let entry_point = build_profiler_call_entry_point(
51-
value.entry_point.clone(),
52-
contracts_data,
53-
fork_data,
54-
&value.events,
55-
&value.signature,
56-
);
48+
let entry_point =
49+
build_profiler_call_entry_point(value.entry_point.clone(), contracts_data, fork_data);
5750
let vm_trace = value
5851
.vm_trace
5952
.as_ref()
@@ -167,8 +160,6 @@ pub fn build_profiler_call_entry_point(
167160
value: CallEntryPoint,
168161
contracts_data: &ContractsData,
169162
fork_data: &ForkData,
170-
events: &[OrderedEvent],
171-
signature: &[Felt],
172163
) -> ProfilerCallEntryPoint {
173164
let CallEntryPoint {
174165
class_hash,
@@ -183,7 +174,6 @@ pub fn build_profiler_call_entry_point(
183174
let contract_name = get_contract_name(class_hash, contracts_data);
184175
let function_name = get_function_name(&entry_point_selector, contracts_data, fork_data);
185176
let calldata_len = calldata.0.len();
186-
let signature_len = signature.len();
187177

188178
ProfilerCallEntryPoint {
189179
class_hash: class_hash.map(|ch| cairo_annotations::trace_data::ClassHash(ch.0)),
@@ -194,8 +184,6 @@ pub fn build_profiler_call_entry_point(
194184
contract_name,
195185
function_name,
196186
calldata_len: Some(calldata_len),
197-
events_summary: Some(to_summed_up_events(events)),
198-
signature_len: Some(signature_len),
199187
}
200188
}
201189

@@ -356,13 +344,3 @@ pub fn save_trace_data(
356344
.context("Failed to write call trace to a file")?;
357345
Ok(dir_to_save_trace.join(&filename))
358346
}
359-
360-
fn to_summed_up_events(events: &[OrderedEvent]) -> Vec<SummedUpEvent> {
361-
events
362-
.iter()
363-
.map(|ev| SummedUpEvent {
364-
keys_len: ev.event.keys.len(),
365-
data_len: ev.event.data.0.len(),
366-
})
367-
.collect()
368-
}

0 commit comments

Comments
 (0)