Get gas resources from CallInfo (#3736)

Closes #3292
Closes #2960

commit-id:7967ca03

---

**Stack**:
- #3756
- #3755
- #3752
- #3751
- #3736 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

Author: ddoktorski

crates/cheatnet/src/runtime_extensions/call_to_blockifier_runtime_extension/rpc.rs

@@ -5,6 +5,7 @@ use crate::runtime_extensions::{
     },
     common::create_execute_calldata,
 };
+use blockifier::execution::call_info::ExecutionSummary;
 use blockifier::execution::{
     call_info::CallInfo,
     entry_point::{CallType, EntryPointExecutionResult},
@@ -18,22 +19,21 @@ use blockifier::state::errors::StateError;
 use cairo_vm::vm::runners::cairo_runner::ExecutionResources;
 use conversions::{byte_array::ByteArray, serde::serialize::CairoSerialize, string::IntoHexStr};
 use shared::utils::build_readable_text;
+use starknet_api::core::EntryPointSelector;
 use starknet_api::execution_resources::GasAmount;
 use starknet_api::{
     contract_class::EntryPointType,
     core::{ClassHash, ContractAddress},
 };
-use starknet_api::{core::EntryPointSelector, transaction::EventContent};
 use starknet_types_core::felt::Felt;
 
 #[derive(Clone, Debug, Default)]
 pub struct UsedResources {
     pub syscall_usage: SyscallUsageMap,
     pub execution_resources: ExecutionResources,
     pub gas_consumed: GasAmount,
-    pub l2_to_l1_payload_lengths: Vec<usize>,
+    pub execution_summary: ExecutionSummary,
     pub l1_handler_payload_lengths: Vec<usize>,
-    pub events: Vec<EventContent>,
 }
 
 /// Enum representing possible call execution result, along with the data

crates/cheatnet/src/runtime_extensions/forge_runtime_extension/mod.rs

@@ -1,6 +1,6 @@
 use self::contracts_data::ContractsData;
 use crate::runtime_extensions::call_to_blockifier_runtime_extension::rpc::UsedResources;
-use crate::runtime_extensions::common::{get_syscalls_gas_consumed, sum_syscall_usage};
+use crate::runtime_extensions::common::sum_syscall_usage;
 use crate::runtime_extensions::forge_runtime_extension::cheatcodes::replace_bytecode::ReplaceBytecodeError;
 use crate::runtime_extensions::{
     call_to_blockifier_runtime_extension::{
@@ -19,27 +19,23 @@ use crate::runtime_extensions::{
 };
 use crate::state::{CallTrace, CallTraceNode};
 use anyhow::{Context, Result, anyhow};
-use blockifier::blockifier_versioned_constants::VersionedConstants;
 use blockifier::bouncer::vm_resources_to_sierra_gas;
 use blockifier::context::TransactionContext;
-use blockifier::execution::call_info::{CallExecution, CallInfo};
+use blockifier::execution::call_info::CallInfo;
 use blockifier::execution::contract_class::TrackedResource;
-use blockifier::execution::entry_point::CallEntryPoint;
 use blockifier::execution::syscalls::vm_syscall_utils::{SyscallSelector, SyscallUsageMap};
 use blockifier::state::errors::StateError;
 use cairo_vm::vm::runners::cairo_runner::CairoRunner;
 use cairo_vm::vm::{
     errors::hint_errors::HintError, runners::cairo_runner::ExecutionResources,
     vm_core::VirtualMachine,
 };
-use conversions::IntoConv;
 use conversions::byte_array::ByteArray;
 use conversions::felt::{ToShortString, TryInferFormat};
 use conversions::serde::deserialize::BufferReader;
 use conversions::serde::serialize::CairoSerialize;
 use data_transformer::cairo_types::CairoU256;
 use rand::prelude::StdRng;
-use runtime::starknet::constants::TEST_CONTRACT_CLASS_HASH;
 use runtime::{
     CheatcodeHandlingResult, EnhancedHintError, ExtendedRuntime, ExtensionLogic,
     SyscallHandlingResult,
@@ -752,15 +748,6 @@ pub fn update_top_call_vm_trace(runtime: &mut ForgeRuntime, cairo_runner: &mut C
             Some(get_relocated_vm_trace(cairo_runner));
     }
 }
-fn add_syscall_execution_resources(
-    versioned_constants: &VersionedConstants,
-    execution_resources: &ExecutionResources,
-    syscall_usage: &SyscallUsageMap,
-) -> ExecutionResources {
-    let mut total_vm_usage = execution_resources.filter_unused_builtins();
-    total_vm_usage += &versioned_constants.get_additional_os_syscall_resources(syscall_usage);
-    total_vm_usage
-}
 
 fn add_sierra_gas_resources(top_call: &Rc<RefCell<CallTrace>>) -> u64 {
     let mut gas_consumed = top_call.borrow().gas_consumed;
@@ -788,78 +775,23 @@ fn add_execution_resources(top_call: Rc<RefCell<CallTrace>>) -> ExecutionResourc
 
 #[must_use]
 pub fn get_all_used_resources(
-    runtime: ForgeRuntime,
+    call_info: &CallInfo,
+    trace: &Rc<RefCell<CallTrace>>,
     transaction_context: &TransactionContext,
-    tracked_resource: TrackedResource,
 ) -> UsedResources {
-    let starknet_runtime = runtime.extended_runtime.extended_runtime.extended_runtime;
-    let top_call_l2_to_l1_messages = starknet_runtime.hint_handler.base.l2_to_l1_messages;
-    let top_call_events = starknet_runtime.hint_handler.base.events;
-
     let versioned_constants = transaction_context.block_context.versioned_constants();
 
-    // used just to obtain payloads of L2 -> L1 messages
-    let runtime_call_info = CallInfo {
-        execution: CallExecution {
-            l2_to_l1_messages: top_call_l2_to_l1_messages,
-            events: top_call_events,
-            ..Default::default()
-        },
-        call: CallEntryPoint {
-            class_hash: Some(Felt::from_hex(TEST_CONTRACT_CLASS_HASH).unwrap().into_()),
-            ..Default::default()
-        },
-        inner_calls: starknet_runtime.hint_handler.base.inner_calls,
-        tracked_resource,
-        ..Default::default()
-    };
-    let summary = runtime_call_info.summarize(versioned_constants);
-    let l2_to_l1_payload_lengths = summary.l2_to_l1_payload_lengths;
-
-    let l1_handler_payload_lengths =
-        get_l1_handlers_payloads_lengths(&runtime_call_info.inner_calls);
+    let summary = call_info.summarize(versioned_constants);
 
-    // call representing the test code
-    let top_call = runtime
-        .extended_runtime
-        .extended_runtime
-        .extension
-        .cheatnet_state
-        .trace_data
-        .current_call_stack
-        .top();
+    let l1_handler_payload_lengths = get_l1_handlers_payloads_lengths(&call_info.inner_calls);
 
-    let mut execution_resources = top_call.borrow().used_execution_resources.clone();
-    let mut sierra_gas_consumed = top_call.borrow().gas_consumed;
-    let top_call_syscalls = top_call.borrow().get_total_used_syscalls();
-
-    execution_resources = add_syscall_execution_resources(
-        versioned_constants,
-        &execution_resources,
-        &top_call.borrow().used_syscalls_vm_resources,
-    );
-    sierra_gas_consumed += get_syscalls_gas_consumed(
-        &top_call.borrow().used_syscalls_sierra_gas,
-        versioned_constants,
-    );
-
-    let events = runtime_call_info
-        .iter() // This method iterates over inner calls as well
-        .flat_map(|call_info| {
-            call_info
-                .execution
-                .events
-                .iter()
-                .map(|evt| evt.event.clone())
-        })
-        .collect();
+    let top_call_syscalls = trace.borrow().get_total_used_syscalls();
 
     UsedResources {
-        events,
         syscall_usage: top_call_syscalls,
-        execution_resources,
-        gas_consumed: GasAmount::from(sierra_gas_consumed),
+        execution_resources: call_info.resources.clone(),
+        gas_consumed: GasAmount::from(call_info.execution.gas_consumed),
+        execution_summary: summary,
         l1_handler_payload_lengths,
-        l2_to_l1_payload_lengths,
     }
 }

crates/forge-runner/src/gas.rs

@@ -9,13 +9,11 @@ use blockifier::fee::resources::{
 use blockifier::state::cached_state::CachedState;
 use blockifier::state::errors::StateError;
 use blockifier::transaction::objects::HasRelatedFeeType;
-use blockifier::utils::u64_from_usize;
 use cairo_vm::vm::runners::cairo_runner::ExecutionResources;
 use cheatnet::runtime_extensions::call_to_blockifier_runtime_extension::rpc::UsedResources;
 use cheatnet::runtime_extensions::forge_config_extension::config::RawAvailableResourceBoundsConfig;
 use cheatnet::state::ExtendedStateReader;
 use starknet_api::execution_resources::{GasAmount, GasVector};
-use starknet_api::transaction::EventContent;
 use starknet_api::transaction::fields::GasVectorComputationMode;
 
 #[tracing::instrument(skip_all, level = "debug")]
@@ -27,13 +25,14 @@ pub fn calculate_used_gas(
     let versioned_constants = transaction_context.block_context.versioned_constants();
 
     let message_resources = get_messages_resources(
-        &resources.l2_to_l1_payload_lengths,
+        &resources.execution_summary.l2_to_l1_payload_lengths,
         &resources.l1_handler_payload_lengths,
     );
 
     let state_resources = get_state_resources(transaction_context, state)?;
 
-    let archival_data_resources = get_archival_data_resources(resources.events);
+    let archival_data_resources =
+        get_archival_data_resources(resources.execution_summary.event_summary);
 
     let starknet_resources = StarknetResources {
         archival_data: archival_data_resources,
@@ -64,17 +63,7 @@ pub fn calculate_used_gas(
     ))
 }
 
-fn get_archival_data_resources(events: Vec<EventContent>) -> ArchivalDataResources {
-    // Based on from https://github.com/starkware-libs/sequencer/blob/fc0f06a07f3338ae1e11612dcaed9c59373bca37/crates/blockifier/src/execution/call_info.rs#L222
-    let mut event_summary = EventSummary {
-        n_events: events.len(),
-        ..Default::default()
-    };
-    for event in events {
-        event_summary.total_event_data_size += u64_from_usize(event.data.0.len());
-        event_summary.total_event_keys += u64_from_usize(event.keys.len());
-    }
-
+fn get_archival_data_resources(event_summary: EventSummary) -> ArchivalDataResources {
     // calldata length, signature length and code size are set to 0, because
     // we don't include them in estimations
     // ref: https://github.com/foundry-rs/starknet-foundry/blob/5ce15b029135545452588c00aae580c05eb11ca8/docs/src/testing/gas-and-resource-estimation.md?plain=1#L73

crates/forge-runner/src/running.rs

@@ -288,7 +288,7 @@ pub fn run_test_case(
                 tracked_resource,
             )?;
 
-            // TODO(#3292) this can be done better, we can take gas directly from call info
+            // TODO(#3744): Confirm if this is needed for the profiler
             let vm_resources_without_inner_calls = runner
                 .get_execution_resources()
                 .expect("Execution resources missing")
@@ -335,34 +335,38 @@ pub fn run_test_case(
         .clone();
 
     let transaction_context = get_context(&forge_runtime).tx_context.clone();
-    let used_resources =
-        get_all_used_resources(forge_runtime, &transaction_context, tracked_resource);
-    let gas_used = calculate_used_gas(
-        &transaction_context,
-        &mut cached_state,
-        used_resources.clone(),
-    )?;
 
     let fork_data = cached_state
         .state
         .fork_state_reader
+        .as_ref()
         .map(|fork_state_reader| ForkData::new(&fork_state_reader.compiled_contract_class_map()))
         .unwrap_or_default();
 
     Ok(match result {
-        Ok(result) => RunResult::Completed(Box::new(RunCompleted {
-            status: if result.execution.failed {
-                RunStatus::Panic(result.execution.retdata.0)
-            } else {
-                RunStatus::Success(result.execution.retdata.0)
-            },
-            call_trace: call_trace_ref,
-            gas_used,
-            used_resources,
-            encountered_errors,
-            fuzzer_args,
-            fork_data,
-        })),
+        Ok(result) => {
+            let used_resources =
+                get_all_used_resources(&result, &call_trace_ref, &transaction_context);
+            let gas_used = calculate_used_gas(
+                &transaction_context,
+                &mut cached_state,
+                used_resources.clone(),
+            )?;
+
+            RunResult::Completed(Box::new(RunCompleted {
+                status: if result.execution.failed {
+                    RunStatus::Panic(result.execution.retdata.0)
+                } else {
+                    RunStatus::Success(result.execution.retdata.0)
+                },
+                call_trace: call_trace_ref,
+                gas_used,
+                used_resources,
+                encountered_errors,
+                fuzzer_args,
+                fork_data,
+            }))
+        }
         Err(error) => RunResult::Error(RunError {
             error: Box::new(error),
             call_trace: call_trace_ref,

crates/forge-runner/src/running/copied_code.rs

@@ -60,6 +60,7 @@ pub fn get_call_result(
         TrackedResource::CairoSteps => 0,
         TrackedResource::SierraGas => syscall_handler.base.call.initial_gas - gas,
     };
+
     Ok(CallResult {
         failed,
         retdata: read_execution_retdata(runner, retdata_size, retdata_start)?,

crates/forge-runner/src/test_case_summary.rs

@@ -125,6 +125,7 @@ impl TestType for Single {
 }
 
 /// Summary of running a single test case
+#[expect(clippy::large_enum_variant)]
 #[derive(Debug, Clone)]
 pub enum TestCaseSummary<T: TestType> {
     /// Test case passed

crates/forge/tests/data/contracts/gas_constructor_checker.cairo

@@ -4,8 +4,10 @@ mod GasConstructorChecker {
     struct Storage {}
 
     #[constructor]
-    fn constructor(ref self: ContractState, _dummy_calldata: felt252) {
-        keccak::keccak_u256s_le_inputs(array![1].span());
-        keccak::keccak_u256s_le_inputs(array![1].span());
+    fn constructor(ref self: ContractState, compute_keccak: bool) {
+        if compute_keccak {
+            keccak::keccak_u256s_le_inputs(array![1].span());
+            keccak::keccak_u256s_le_inputs(array![1].span());
+        }
     }
 }

crates/forge/tests/data/contracts/hello_starknet_for_nested_calls.cairo

@@ -13,7 +13,6 @@ pub mod HelloStarknet {
     #[abi(embed_v0)]
     impl HelloStarknetImpl of super::IHelloStarknet<ContractState> {
         fn example_function(ref self: ContractState) {
-            core::pedersen::pedersen(1, 2);
             core::keccak::keccak_u256s_le_inputs(array![1].span());
             let _hash = compute_sha256_u32_array(array![0x68656c6c], 0x6f, 1);
             starknet::syscalls::get_block_hash_syscall(1).unwrap_syscall();