Link todos

Author: cptartur

crates/cheatnet/src/runtime_extensions/native/deploy.rs

@@ -145,7 +145,7 @@ pub fn deploy(
     //     .tx_context
     //     .block_context
     //     .versioned_constants;
-    // TODO support for reject
+    // TODO(#3790) support for reject
     // if should_reject_deploy(
     //     versioned_constants.disable_deploy_in_validation_mode,
     //     syscall_handler_base.context.execution_mode,

crates/cheatnet/src/runtime_extensions/native/execution.rs

@@ -115,7 +115,7 @@ pub fn execute_entry_point_call(
 
     let call_result = execution_result.map_err(EntryPointExecutionError::NativeUnexpectedError)?;
 
-    // TODO consider modifying this so it doesn't use take internally
+    // TODO(#3790) consider modifying this so it doesn't use take internally
     if let Some(error) = syscall_handler.unrecoverable_error() {
         return Err(EntryPointExecutionError::NativeUnrecoverableError(
             Box::new(error),

crates/cheatnet/src/runtime_extensions/native/native_syscall_handler.rs

@@ -33,7 +33,7 @@ pub struct CheatableNativeSyscallHandler<'a> {
 pub type BaseSyscallResult<T> = Result<T, SyscallExecutionError>;
 
 impl CheatableNativeSyscallHandler<'_> {
-    // TODO consider modifying this so it doesn't use take
+    // TODO(#3790) consider modifying this so it doesn't use take
     pub fn unrecoverable_error(&mut self) -> Option<SyscallExecutionError> {
         self.native_syscall_handler.unrecoverable_error.take()
     }
@@ -263,7 +263,7 @@ impl StarknetSyscallHandler for &mut CheatableNativeSyscallHandler<'_> {
             .tx_info
             .nonce
             .unwrap_or(original_data.tx_info.nonce);
-        // TODO impl conversions
+        // TODO(#3790) impl conversions
         let resource_bounds = cheated_data.tx_info.resource_bounds.map_or(
             original_data.tx_info.resource_bounds,
             |rb| {
@@ -469,7 +469,7 @@ impl StarknetSyscallHandler for &mut CheatableNativeSyscallHandler<'_> {
             return Err(self.handle_error(remaining_gas, err.into()));
         }
         let selector = EntryPointSelector(entry_point_selector);
-        // TODO restore blocking
+        // TODO(#3790) restore blocking
         // self
         //     .native_syscall_handler
         //     .base
@@ -544,7 +544,7 @@ impl StarknetSyscallHandler for &mut CheatableNativeSyscallHandler<'_> {
                 .native_syscall_handler
                 .base
                 .call
-                // TODO why we default to code_address??
+                // TODO(#3790) why we default to code_address??
                 .code_address
                 .unwrap_or(self.native_syscall_handler.base.call.storage_address);
             let event = self
@@ -576,7 +576,7 @@ impl StarknetSyscallHandler for &mut CheatableNativeSyscallHandler<'_> {
                 .native_syscall_handler
                 .base
                 .call
-                // TODO why we default to code_address??
+                // TODO(#3790) why we default to code_address??
                 .code_address
                 .unwrap_or(self.native_syscall_handler.base.call.storage_address);
             let message = self

crates/forge/tests/e2e/docs_snippets_validation.rs

@@ -13,7 +13,7 @@ use super::common::runner::{runner, setup_package};
 #[test]
 #[cfg_attr(
     feature = "cairo-native",
-    ignore = "TODO: Many snippets show vm resources witch cairo native doesn't support"
+    ignore = "TODO(#3790): Many snippets show vm resources witch cairo native doesn't support"
 )]
 fn test_docs_snippets() {
     let root_dir = get_nth_ancestor(2);

crates/sncast/src/helpers/scarb_utils.rs

@@ -172,7 +172,6 @@ pub fn build_and_load_artifacts(
             &target_dir.join(&config.profile),
             package,
             ui,
-            // TODO: Reconsider running sncast with native
             CompilationOpts::default()
         ).context("Failed to load artifacts. Make sure you have enabled sierra code generation in Scarb.toml")?
         .into_iter()
@@ -187,7 +186,6 @@ pub fn build_and_load_artifacts(
             &target_dir.join(default_profile),
             package,
             ui,
-            // TODO: Reconsider running sncast with native
             CompilationOpts::default(),
         ).context("Failed to load artifacts. Make sure you have enabled sierra code generation in Scarb.toml")?
         .into_iter()