Support devnet in `--network` flag #3786

MKowalski8 · 2025-10-03T15:18:46Z

Closes #3764

Introduced changes

Implement devnet detection for --network flag

Checklist

franciszekjob

Once 3603-3-devnet-interactions-docs is merged, let's mention ability to use --network devnet in the docs 👍 .

crates/sncast/src/helpers/devnet_detection.rs

crates/sncast/src/starknet_commands/verify/voyager.rs

crates/sncast/src/starknet_commands/verify/walnut.rs

crates/sncast/src/lib.rs

MKowalski8 · 2025-10-07T12:42:52Z

docs/src/starknet/sncast-overview.md

+The `--network` flag supports the following networks:
+
+- **mainnet** - Connects to Starknet mainnet using a free RPC provider
+- **sepolia** - Connects to Starknet Sepolia testnet using a free RPC provider
+- **devnet** - Attempts to auto-detect running starknet-devnet instances
+
+When using **mainnet** or **sepolia**, `sncast` will randomly select one of the free RPC providers.
+When using free providers you may experience rate limits and other unexpected behavior.
+
+For **devnet**, `sncast` will try to detect running `starknet-devnet` instance and connect to it, but it may fail. If detection fails, then use the `--url` flag instead.


Once 3603-3-devnet-interactions-docs is merged, let's mention ability to use --network devnet in the docs 👍 .

Since we have interaction-docs, after adding info about --network devnet there. Should I remove this changes in overview? I am aware that it is not the best place and we may want to preserve only short messages here

It's fine, leave it there too.

cptartur · 2025-10-07T14:54:52Z

crates/sncast/src/helpers/devnet_detection.rs

+
+fn detect_devnet_from_processes() -> Result<String, String> {
+    match find_devnet_process_info() {
+        Ok(info) => Ok(format!("http://{}:{}", info.host, info.port)),


You could probably do this

Suggested change

Ok(info) => Ok(format!("http://{}:{}", info.host, info.port)),

Ok(DevnetProcessInfo { host, port }) => Ok(format!("http://{}:{}", host, port)),

cptartur · 2025-10-07T16:48:51Z

crates/sncast/src/helpers/devnet_detection.rs

+
+    if host.is_none()
+        && let Ok(host_env) = std::env::var("HOST")
+        && !host_env.is_empty()


We validate port but take host directly, to be consistent we should probably either validate both or none.

What was the motivation for only validating one of them?

cptartur · 2025-10-07T16:50:32Z

crates/sncast/src/helpers/devnet_detection.rs

+    if port.is_none() {
+        port = std::env::var("PORT")
+            .ok()
+            .and_then(|port_env| parse_valid_port(&port_env));


This way we silently ignore user settings if they are invalid. If we aren't doing any nice error handling for invalid values I'd rather we panic than silently ignore them.

This goes for all places we do so, not only here

cptartur · 2025-10-07T16:53:15Z

crates/sncast/src/helpers/devnet_detection.rs

+    Command::new("curl")
+        .args(["-s", "-f", "--max-time", "1", &url])
+        .output()
+        .map(|output| output.status.success())
+        .unwrap_or(false)


Rather than rely on curl being installed, couldn't we use some library for HTTP requests?

We already have a dependency on reqwest

cptartur · 2025-10-07T17:00:04Z

crates/sncast/src/helpers/devnet_detection.rs

+        let value_str = after_pattern
+            .split_whitespace()
+            .next()
+            .unwrap_or("")


If the iterator returns nothing (we unwrap with default), doesn't that mean we won't find anything anyway?

Also a nit, but probably unwrap_or_default could do here.

cptartur · 2025-10-07T17:21:14Z

crates/sncast/src/response/explorer_link.rs

 where
    T: OutputLink + Clone,
 {
-    if (!config.show_explorer_links || rpc.is_localhost(&config.url))


Why do we no longer check for localhost?

cptartur · 2025-10-07T17:29:49Z

docs/src/starknet/sncast-overview.md

+
+- **mainnet** - Connects to Starknet mainnet using a free RPC provider
+- **sepolia** - Connects to Starknet Sepolia testnet using a free RPC provider
+- **devnet** - Attempts to auto-detect running starknet-devnet instances


We fail on multiple

Suggested change

- **devnet** - Attempts to auto-detect running starknet-devnet instances

- **devnet** - Attempts to auto-detect running starknet-devnet instance

cptartur · 2025-10-07T17:30:05Z

docs/src/starknet/sncast-overview.md

+- **devnet** - Attempts to auto-detect running starknet-devnet instances
+
+When using **mainnet** or **sepolia**, `sncast` will randomly select one of the free RPC providers.
+When using free providers you may experience rate limits and other unexpected behavior.


This could be > note

cptartur · 2025-10-07T17:31:06Z

docs/src/starknet/sncast-overview.md

+When using **mainnet** or **sepolia**, `sncast` will randomly select one of the free RPC providers.
+When using free providers you may experience rate limits and other unexpected behavior.
+
+For **devnet**, `sncast` will try to detect running `starknet-devnet` instance and connect to it, but it may fail. If detection fails, then use the `--url` flag instead.


Suggested change

For **devnet**, `sncast` will try to detect running `starknet-devnet` instance and connect to it, but it may fail. If detection fails, then use the `--url` flag instead.

For **devnet**, `sncast` will try to detect running `starknet-devnet` instance and connect to it, but detection is not guaranteed. If `sncast` is unable to detect your devnet instance, provide the `--url` directly.

cptartur · 2025-10-07T17:31:27Z

crates/sncast/src/helpers/devnet_detection.rs

+}
+
+#[cfg(test)]
+mod tests {


Didn't review the tests yet

franciszekjob · 2025-10-07T15:47:12Z

docs/src/starknet/sncast-overview.md

+The `--network` flag supports the following networks:
+
+- **mainnet** - Connects to Starknet mainnet using a free RPC provider
+- **sepolia** - Connects to Starknet Sepolia testnet using a free RPC provider
+- **devnet** - Attempts to auto-detect running starknet-devnet instances
+
+When using **mainnet** or **sepolia**, `sncast` will randomly select one of the free RPC providers.
+When using free providers you may experience rate limits and other unexpected behavior.
+
+For **devnet**, `sncast` will try to detect running `starknet-devnet` instance and connect to it, but it may fail. If detection fails, then use the `--url` flag instead.


It's fine, leave it there too.

franciszekjob · 2025-10-07T16:50:26Z

crates/sncast/src/helpers/devnet_detection.rs

+    if let Some(pos) = cmdline.find(flag) {
+        let after_pattern = &cmdline[pos + flag.len()..];
+        let value_str = after_pattern
+            .split_whitespace()
+            .next()
+            .unwrap_or("")
+            .trim_start_matches('=')
+            .trim_start_matches(':');
+
+        if !value_str.is_empty() {
+            return Some(value_str.to_string());
+        }
+    }
+    None
+}


Wouldn't regex be better here?

franciszekjob · 2025-10-07T18:16:27Z

crates/sncast/src/helpers/devnet_detection.rs

+        [] => Err(DevnetDetectionError::NoInstance),
+        [single] => Ok(single.clone()),
+        _ => Err(DevnetDetectionError::MultipleInstances),


Ok at the top:

Suggested change

[] => Err(DevnetDetectionError::NoInstance),

[single] => Ok(single.clone()),

_ => Err(DevnetDetectionError::MultipleInstances),

[single] => Ok(single.clone()),

[] => Err(DevnetDetectionError::NoInstance),

_ => Err(DevnetDetectionError::MultipleInstances),

franciszekjob · 2025-10-07T18:22:50Z

crates/sncast/src/helpers/devnet_detection.rs

We can make a separate module devnet, place this file and the one containing DevnetProvider.

franciszekjob · 2025-10-07T18:24:28Z

crates/sncast/src/helpers/devnet_detection.rs

+fn extract_docker_mapping(cmdline: &str) -> Option<(String, u16)> {
+    let port_flags = ["-p", "--publish"];
+
+    for flag in &port_flags {
+        if let Some(port_mapping) = extract_string_from_flag(cmdline, flag) {
+            let parts: Vec<&str> = port_mapping.split(':').collect();
+            if parts.len() == 3
+                && let Ok(host_port) = parts[1].parse::<u16>()
+            {
+                return Some((parts[0].to_string(), host_port));
+            } else if parts.len() == 2
+                && let Ok(host_port) = parts[0].parse::<u16>()
+            {
+                return Some((DEFAULT_DEVNET_HOST.to_string(), host_port));
+            }
+        }
+    }
+
+    None
+}


Same remark about regex usage

MKowalski8 added 11 commits October 3, 2025 17:09

Introduce devnet option for --network

120b679

Implement heuristic detection

61b534d

Update docs

807dcba

Changelog info

9a1ea80

Change displaying blockexplorer to heuristic detection

dcbb672

Fix clippy

7d95b14

Rewrite url detection

0e04f81

Better error message

a5510dd

Fix tests

a18a02d

Rename

7299ae0

Fix new clippy

f4b31ea

MKowalski8 changed the title ~~3764 support devnet via network flag~~ Support devnet in --network flag Oct 3, 2025

MKowalski8 and others added 8 commits October 6, 2025 12:57

Change docs

2d0aa6c

Return error when two instances found

eafe1ca

Merge branch 'master' into 3764-support-devnet-via-network-flag

88071ee

Merge fixes

a9b1b51

Fix comments

016fc2e

Prepare to review

7793096

Merge branch 'master' into 3764-support-devnet-via-network-flag

4613458

Rewrite docker data extracting

7aaf4d4

MKowalski8 marked this pull request as ready for review October 7, 2025 09:40

MKowalski8 requested a review from a team as a code owner October 7, 2025 09:40

MKowalski8 requested review from ddoktorski and cptartur October 7, 2025 09:40

Update docs

f73163e

franciszekjob requested changes Oct 7, 2025

View reviewed changes

MKowalski8 added 2 commits October 7, 2025 14:24

Nits from review

f8c1ac6

Change verification to return error

71357ba

MKowalski8 commented Oct 7, 2025

View reviewed changes

Change filtering to grep

ed83201

Merge branch 'master' into 3764-support-devnet-via-network-flag

079e8db

MKowalski8 requested a review from franciszekjob October 7, 2025 13:17

Fix fmt

3513d28

cptartur reviewed Oct 7, 2025

View reviewed changes

franciszekjob reviewed Oct 7, 2025

View reviewed changes

	Ok(info) => Ok(format!("http://{}:{}", info.host, info.port)),
	Ok(DevnetProcessInfo { host, port }) => Ok(format!("http://{}:{}", host, port)),

	- devnet - Attempts to auto-detect running starknet-devnet instances
	- devnet - Attempts to auto-detect running starknet-devnet instance

	For devnet, `sncast` will try to detect running `starknet-devnet` instance and connect to it, but it may fail. If detection fails, then use the `--url` flag instead.
	For devnet, `sncast` will try to detect running `starknet-devnet` instance and connect to it, but detection is not guaranteed. If `sncast` is unable to detect your devnet instance, provide the `--url` directly.

Support devnet in --network flag #3786

Are you sure you want to change the base?

Support devnet in --network flag #3786

Conversation

MKowalski8 commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Introduced changes

Checklist

Uh oh!

franciszekjob left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

franciszekjob Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Support devnet in `--network` flag #3786

Support devnet in `--network` flag #3786

MKowalski8 commented Oct 3, 2025 •

edited

Loading

franciszekjob left a comment •

edited

Loading

franciszekjob Oct 7, 2025 •

edited

Loading