Add oracles test #3847
Open
Add oracles test #3847
+595
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2025
Open
cptartur
force-pushed
the
spr/master/adef9534
branch
from
9c8d296 to
6aabc54
Compare
Open
cptartur
force-pushed
the
spr/master/adef9534
branch
from
6aabc54 to
d1cf4c1
Compare
This was referenced Nov 7, 2025
cptartur
force-pushed
the
spr/master/adef9534
branch
3 times, most recently
from
6fecbf4 to
0560da2
Compare
cptartur
requested review from
ddoktorski,
franciszekjob and
ksew1
and removed request for
ddoktorski
ksew1
reviewed
Nov 11, 2025
Closes #3825 commit-id:adef9534 # Conflicts: # Cargo.lock # Conflicts: # .tool-versions
cptartur
force-pushed
the
spr/master/adef9534
branch
from
0560da2 to
945b1fc
Compare
franciszekjob
approved these changes
Nov 12, 2025
Comment on lines
+5
to
+12
| assets = ["wasm_oracle.wasm"] | ||
|
|
||
| #[[target.starknet-contract]] | ||
| #sierra = true | ||
|
|
||
| [dependencies] | ||
| oracle = "1" | ||
| starknet = "2.4.0" |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| assets = ["wasm_oracle.wasm"] | |
| #[[target.starknet-contract]] | |
| #sierra = true | |
| [dependencies] | |
| oracle = "1" | |
| starknet = "2.4.0" | |
| assets = ["wasm_oracle.wasm"] | |
| [dependencies] | |
| oracle = "1" | |
| starknet = "2.12.0" |
| [workspace] | ||
|
|
||
| [package] | ||
| name = "wasm_oracle" |
Contributor
There was a problem hiding this comment.
super tiny nit: maybe drop “wasm” in the name - it’s more about the format than what this module does. Something like hello_oracles or simple_oracle would fit better 😅
Contributor
There was a problem hiding this comment.
I know these tests are enough but are there any other (more complicated) scenarios that we could cover?
ksew1
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3825
Stack:
RawFeltVec#3849